More CodeAction moves in preparation for cohosting#11135
Merged
davidwengier merged 6 commits intodotnet:mainfrom Nov 1, 2024
Merged
More CodeAction moves in preparation for cohosting#11135davidwengier merged 6 commits intodotnet:mainfrom
davidwengier merged 6 commits intodotnet:mainfrom
Conversation
Cohosting needs to get code actions in devenv, and will use the service in OOP
No need for cohosting to have to import a service for one method (in devenv)
As before, cohosting will need to do this in devenv
DustinCampbell
approved these changes
Nov 1, 2024
ryzngard
approved these changes
Nov 1, 2024
Member
Author
|
Thank you both |
davidwengier
added a commit
that referenced
this pull request
Nov 4, 2024
My bad. In #11135 I failed to notice that the `GenerateRazorCodeActionContextAsync` also modified the original code actions request, to handle an oddity of VS LSP, where it sends the users selected range (or cursor position) as a different property, and uses the `Range` property as the whole line.
This was referenced Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, I was wrong when I said the last PR was the final piece before cohosting actually gets implemented, but this one is, I swear!
Code actions have to run in devenv for Roslyn, so the main thing here is re-architecting so that the endpoints call the delegated servers, because calling into the service. Each commit is an isolated step on the way.