Allow Razor cohosting to work with non-Razor SDK projects#9733
Merged
drewnoakes merged 6 commits intodotnet:mainfrom Aug 21, 2025
Merged
Allow Razor cohosting to work with non-Razor SDK projects#9733drewnoakes merged 6 commits intodotnet:mainfrom
drewnoakes merged 6 commits intodotnet:mainfrom
Conversation
…ojects that don't use the Razor SDK
drewnoakes
reviewed
Aug 19, 2025
...io.ProjectSystem.Managed/ProjectSystem/DesignTimeTargets/Microsoft.CSharp.DesignTime.targets
Outdated
Show resolved
Hide resolved
| <!-- .NET Framework uses a different editor in VS --> | ||
| <ItemGroup Condition="'$(TargetFrameworkIdentifier)' != '.NETFramework' And 'UsingMicrosoftNETSdkRazor' != 'true'"> | ||
| <!-- Collect all Razor and CSHTML files --> | ||
| <_RazorOrCshtmlFiles Include="**\*.razor;**\*.cshtml" /> |
Member
There was a problem hiding this comment.
Are these items already in an item group somewhere that we can piggy back off? It'd be nice to avoid adding more globs.
Member
Author
There was a problem hiding this comment.
I don't think there is any consistency here, they could be in Content or None, but they could be nowhere. My last contribution to this repo was actually around the same issue, because Maui and Bing did weird and different things: #7417
This really is a last resort catch all we're having to write.
...io.ProjectSystem.Managed/ProjectSystem/DesignTimeTargets/Microsoft.CSharp.DesignTime.targets
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Aug 19, 2025
...io.ProjectSystem.Managed/ProjectSystem/DesignTimeTargets/Microsoft.CSharp.DesignTime.targets
Outdated
Show resolved
Hide resolved
davidwengier
commented
Aug 20, 2025
...io.ProjectSystem.Managed/ProjectSystem/DesignTimeTargets/Microsoft.CSharp.DesignTime.targets
Outdated
Show resolved
Hide resolved
…/DesignTimeTargets/Microsoft.CSharp.DesignTime.targets
davidwengier
commented
Aug 20, 2025
...io.ProjectSystem.Managed/ProjectSystem/DesignTimeTargets/Microsoft.CSharp.DesignTime.targets
Outdated
Show resolved
Hide resolved
…/DesignTimeTargets/Microsoft.CSharp.DesignTime.targets
drewnoakes
reviewed
Aug 20, 2025
...io.ProjectSystem.Managed/ProjectSystem/DesignTimeTargets/Microsoft.CSharp.DesignTime.targets
Outdated
Show resolved
Hide resolved
…/DesignTimeTargets/Microsoft.CSharp.DesignTime.targets Co-authored-by: Drew Noakes <git@drewnoakes.com>
2 tasks
drewnoakes
approved these changes
Aug 21, 2025
drewnoakes
added a commit
to drewnoakes/project-system
that referenced
this pull request
Sep 3, 2025
drewnoakes
added a commit
that referenced
this pull request
Sep 3, 2025
[dev18.0.x] Revert "Merge pull request #9733 from davidwengier/RazorForNonRazorSdk"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of dotnet/razor#11834
Microsoft Reviewers: Open in CodeFlow