Skip to content

Disable SOD Pizza App Publish AOT for net7.0 #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LoopedBard3 merged 2 commits into from
Oct 21, 2021
Merged

Disable SOD Pizza App Publish AOT for net7.0 #2091

LoopedBard3 merged 2 commits into from
Oct 21, 2021

Conversation

@LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Oct 21, 2021 •
edited
Loading

Disable SOD Pizza App Publish AOT because build with wasm-tools installed on net7.0 causes failure. Reenable once this failure is corrected.

Errors:

[2021/10/21 12:28:22][INFO] C:\h\w\BDF90A35\p\dotnet\sdk\7.0.100-alpha.1.21518.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error MSB4018: The "ProcessFrameworkReferences" task failed unexpectedly. [C:\h\w\BDF90A35\w\9FD008B5\e\app\BlazingPizza.Client\BlazingPizza.Client.csproj]
[2021/10/21 12:28:22][INFO] C:\h\w\BDF90A35\p\dotnet\sdk\7.0.100-alpha.1.21518.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error MSB4018: System.InvalidOperationException: Nullable object must have a value. [C:\h\w\BDF90A35\w\9FD008B5\e\app\BlazingPizza.Client\BlazingPizza.Client.csproj]
[2021/10/21 12:28:22][INFO] C:\h\w\BDF90A35\p\dotnet\sdk\7.0.100-alpha.1.21518.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error MSB4018:    at System.Nullable`1.get_Value() [C:\h\w\BDF90A35\w\9FD008B5\e\app\BlazingPizza.Client\BlazingPizza.Client.csproj]
[2021/10/21 12:28:22][INFO] C:\h\w\BDF90A35\p\dotnet\sdk\7.0.100-alpha.1.21518.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ProcessFrameworkReferences.ExecuteCore() [C:\h\w\BDF90A35\w\9FD008B5\e\app\BlazingPizza.Client\BlazingPizza.Client.csproj]
[2021/10/21 12:28:22][INFO] C:\h\w\BDF90A35\p\dotnet\sdk\7.0.100-alpha.1.21518.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error MSB4018:    at Microsoft.NET.Build.Tasks.TaskBase.Execute() [C:\h\w\BDF90A35\w\9FD008B5\e\app\BlazingPizza.Client\BlazingPizza.Client.csproj]
[2021/10/21 12:28:22][INFO] C:\h\w\BDF90A35\p\dotnet\sdk\7.0.100-alpha.1.21518.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [C:\h\w\BDF90A35\w\9FD008B5\e\app\BlazingPizza.Client\BlazingPizza.Client.csproj]
[2021/10/21 12:28:22][INFO] C:\h\w\BDF90A35\p\dotnet\sdk\7.0.100-alpha.1.21518.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [C:\h\w\BDF90A35\w\9FD008B5\e\app\BlazingPizza.Client\BlazingPizza.Client.csproj]

@LoopedBard3
Disable SOD Pizza App Publish AOT because build with wasm-tools cause…
e0d331a 
…s failure. Reenable once this failure is corrected.
@LoopedBard3 LoopedBard3 added the bug Something isn't working label Oct 21, 2021
@LoopedBard3 LoopedBard3 self-assigned this Oct 21, 2021
@LoopedBard3 LoopedBard3 requested a review from billwert October 21, 2021 21:19
@LoopedBard3
Revert commenting of SOD Pizza Pub AOT test, instead have it only run…
911e9be 
… when the FrameworkVersion is less than 7.0 ('need to test in pipeline').
@LoopedBard3 LoopedBard3 reopened this Oct 21, 2021
@LoopedBard3 LoopedBard3 changed the title Disable SOD Pizza App Publish AOT Disable SOD Pizza App Publish AOT for net7.0 Oct 21, 2021
@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Oct 21, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 21, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@LoopedBard3 LoopedBard3 mentioned this pull request Oct 21, 2021
Closed
@LoopedBard3 LoopedBard3 merged commit a453235 into dotnet:main Oct 21, 2021
LoopedBard3 added a commit to LoopedBard3/performance that referenced this pull request Oct 25, 2021
@LoopedBard3
Commented out SOD pizza app publish AOT because it is failing due to …
691cd9b 
…wasm-tools. (dotnet#2091) Adding a condition worked for the perf repo but not for runs occuring on top of the runtime repo so I am just removing it completely for the time being.
@LoopedBard3 LoopedBard3 mentioned this pull request Oct 25, 2021
Merged
LoopedBard3 added a commit that referenced this pull request Oct 25, 2021
@LoopedBard3
Commented out SOD pizza app publish AOT because it is failing due to …
9eb6fe6 
…wasm-tools. (#2091) Adding a condition worked for the perf repo but not for runs occuring on top of the runtime repo so I am just removing it completely for the time being. (#2095)
@LoopedBard3 LoopedBard3 deleted the Wasm-Fix branch February 28, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@billwert billwert billwert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LoopedBard3 LoopedBard3

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LoopedBard3 @billwert