Skip to content

Cleanup: Delete ExcludeFromStyleCop from project files#9247

Merged
JaynieBai merged 2 commits intodotnet:mainfrom
ladipro:project-file-cleanup
Oct 11, 2023
Merged

Cleanup: Delete ExcludeFromStyleCop from project files#9247
JaynieBai merged 2 commits intodotnet:mainfrom
ladipro:project-file-cleanup

Conversation

@ladipro
Copy link
Copy Markdown
Member

@ladipro ladipro commented Sep 21, 2023

Context

The ExcludeFromStyleCop is not effective anymore. Even if it was, it's not clear why we would want to exclude so many files from style checks.

Changes Made

Deleted all occurrences of <ExcludeFromStyleCop>true</ExcludeFromStyleCop> from project files.

Testing

Build (CLI and VS).

Copy link
Copy Markdown
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️❤️❤️

(But let's take this after the 17.8 fork)

@ladipro ladipro force-pushed the project-file-cleanup branch from 452dd5c to cb81cfe Compare October 5, 2023 15:15
@JaynieBai JaynieBai merged commit a934111 into dotnet:main Oct 11, 2023
bulatgrzegorz pushed a commit to bulatgrzegorz/selective-condition-evaluator that referenced this pull request Oct 16, 2023
Context
The ExcludeFromStyleCop is not effective anymore. Even if it was, it's not clear why we would want to exclude so many files from style checks.

Changes Made
Deleted all occurrences of <ExcludeFromStyleCop>true</ExcludeFromStyleCop> from project files.

Testing
Build (CLI and VS).
MichalPavlik pushed a commit that referenced this pull request Oct 17, 2023
Context
The ExcludeFromStyleCop is not effective anymore. Even if it was, it's not clear why we would want to exclude so many files from style checks.

Changes Made
Deleted all occurrences of <ExcludeFromStyleCop>true</ExcludeFromStyleCop> from project files.

Testing
Build (CLI and VS).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants