Overwrite colorized lines instead of incremental updates#8907
Merged
rainersigwald merged 3 commits intodotnet:mainfrom Jun 20, 2023
Merged
Overwrite colorized lines instead of incremental updates#8907rainersigwald merged 3 commits intodotnet:mainfrom
rainersigwald merged 3 commits intodotnet:mainfrom
Conversation
Make `DisplayNodes()` internal so that we can call it from tests in order to verify the "live" logger output at known checkpoints.
The root cause of dotnet#8781 is that the optimize-output-by-skipping- identical-characters logic is not aware of escape sequences, so it goes horribly awry when the replacing line differs after the first escape sequence. Instead, apply the previous logic only if there are no escape sequences; if there are, replace the entire line. If this proves to cause too much flicker or perform slowly, we could implement escape-sequence-aware truncation, length, and comparison, but we can wait for feedback to that effect.
JanKrivanek
approved these changes
Jun 19, 2023
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks easy and effective (if UX speed will suffice)
ladipro
approved these changes
Jun 20, 2023
Member
ladipro
left a comment
There was a problem hiding this comment.
The change looks good and performs well on my slow machine.
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Jun 20, 2023
These ESC]9;4;3; (start indefinite-progress spin) sequences were added in dotnet#8883, but collided with dotnet#8907.
rainersigwald
added a commit
that referenced
this pull request
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause of #8781 is that the optimize-output-by-skipping-identical-characters logic is not aware of escape sequences, so it goes horribly awry when the replacing line differs after the first escape sequence.
Instead, apply the previous logic only if there are no escape sequences; if there are, replace the entire line.
If this proves to cause too much flicker or perform slowly, we could implement escape-sequence-aware truncation, length, and comparison, but we can wait for feedback to that effect.