Pass dotnet host options to worker nodes#859
Merged
rainersigwald merged 1 commit intodotnet:xplatfrom Aug 5, 2016
Merged
Conversation
Multiprocess builds were hanging when called through `dotnet build3`, because the child process spawned from `LaunchNode` failed immediately on start with ``` A fatal error was encountered. The library 'hostpolicy.dll' required to execute the application was not found ``` That was because MSBuild preserved the path to `dotnet`, but not the additional arguments required for it to assemble a runtime environment. This commit uses the property bag that the host provides to find the right deps file. At the moment, there is no programmatic way to access the runtimeconfig, so I'm relying on a heuristic--that it'll match the deps file. The property-bag access code is based on https://github.com/dotnet/cli/blob/b7075b857b48b08908bd340ffd3f41f756318339/src/Microsoft.DotNet.Cli.Utils/Muxer.cs#L36-L40
Member
Author
|
@piotrpMSFT, @eerhardt--I have some questions! Is this temporary? Is there a bug or PR I can crosslink for the "programmatically get runtimeconfig" part? |
|
@rainersigwald I'm working on a PR now. Once it's ready you won't need to get runtimeconfig anymore. Feel free to create an issue on /cli if you want a reference. |
Contributor
|
|
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Aug 9, 2016
This reverts commit cd53996.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiprocess builds were hanging when called through
dotnet build3,because the child process spawned from
LaunchNodefailed immediately onstart with
That was because MSBuild preserved the path to
dotnet, but not theadditional arguments required for it to assemble a runtime environment.
This commit uses the property bag that the host provides to find the right
deps file. At the moment, there is no programmatic way to access the
runtimeconfig, so I'm relying on a heuristic--that it'll match the deps
file.
The property-bag access code is based on
https://github.com/dotnet/cli/blob/b7075b857b48b08908bd340ffd3f41f756318339/src/Microsoft.DotNet.Cli.Utils/Muxer.cs#L36-L40