enable producing reference assemblies by default#8111
Merged
rainersigwald merged 1 commit intodotnet:mainfrom Nov 2, 2022
Merged
enable producing reference assemblies by default#8111rainersigwald merged 1 commit intodotnet:mainfrom
rainersigwald merged 1 commit intodotnet:mainfrom
Conversation
This change allows producing reference assemblies by default for both legacy and SDK project systems
Member
|
This is very exciting! We need to ensure this change will only apply in VS when your corresponding CSPROJ change is active. |
Member
Since this file should only be shipped to VS in changes post-csproj-merge, I think it's ok? There is a slight possibility of someone explicitly using a new common.targets with an older VS (mostly internally in CoreXT environments) but that generally doesn't work anyway, so I think this is ok. |
rainersigwald
approved these changes
Nov 2, 2022
rokonec
approved these changes
Nov 2, 2022
rokonec
added a commit
that referenced
this pull request
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows producing reference assemblies by default for both legacy and SDK project systems
The corresponding changes were merged for legacy project system
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1341885