Merged
Conversation
|
|
||
| // PERF: Not using VerifyThrow to avoid boxing an int in the non-error case. | ||
| if (projectFile == null) | ||
| if (!_projectFileMap.TryGetValue(context.ProjectContextId, out string projectFile)) |
Member
There was a problem hiding this comment.
Is this change required for the insertion-blocking fix?
Contributor
Author
There was a problem hiding this comment.
No; just code cleanliness while I was here. I can revert it.
rainersigwald
approved these changes
Jun 22, 2022
rainersigwald
added a commit
that referenced
this pull request
Jun 30, 2022
This reverts commit e504ba9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SDK issue
Context
Warnings promoted to errors were not being counted properly
Changes Made
Reverted change that introduced the issue
Testing
Added unit test. Verified that it failed without the change.
Notes