Make environment-derived properties change opt-in and read at use time#7715
Merged
rainersigwald merged 4 commits intodotnet:mainfrom Jun 20, 2022
Merged
Make environment-derived properties change opt-in and read at use time#7715rainersigwald merged 4 commits intodotnet:mainfrom
rainersigwald merged 4 commits intodotnet:mainfrom
Conversation
| /// <summary> | ||
| /// Log all environment variables whether or not they are used in a build in the binary log. | ||
| /// </summary> | ||
| public readonly bool LogAllEnvironmentVariables = !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("MSBUILDLOGALLENVIRONMENTVARIABLES")) |
Member
There was a problem hiding this comment.
Could we keep this centralized and change it to =>?
| { | ||
| Write(BinaryLogRecordKind.BuildStarted); | ||
| WriteBuildEventArgsFields(e); | ||
| if (Traits.Instance.LogAllEnvironmentVariables) |
This reverts commit 3e53e25.
rainersigwald
approved these changes
Jun 20, 2022
Forgind
added a commit
to Forgind/msbuild
that referenced
this pull request
Jun 21, 2022
… use time (dotnet#7715)" This reverts commit 7a0fefe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
Changes Made
Testing
Notes