Restore CombineTargetFrameworkInfoProperties opt-in#7642
Merged
rokonec merged 1 commit intoMay 25, 2022
Merged
Conversation
Forgind
approved these changes
May 20, 2022
Forgind
left a comment
Contributor
There was a problem hiding this comment.
Also revert the change in the ChangeWaves doc?
…operties (dotnet#6928)" This caused a regression in scenarios using Visual Studio 17.3 previews with `global.json` files pointing to old .NET SDKs. This reverts commit fe4fde9. Conflicts: src/Framework/ChangeWaves.cs src/Tasks/CombineTargetFrameworkInfoProperties.cs
8eda4ff to
21755de
Compare
benvillalobos
approved these changes
May 23, 2022
JoeRobich
added a commit
to JoeRobich/omnisharp-roslyn
that referenced
this pull request
Aug 31, 2022
Link to suspected failing change dotnet/msbuild#7642
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused a regression in scenarios using Visual Studio 17.3 previews
with
global.jsonfiles pointing to old .NET SDKs.This reverts commit fe4fde9.
Conflicts:
src/Framework/ChangeWaves.cs
src/Tasks/CombineTargetFrameworkInfoProperties.cs
Fixes AB#1534809.