Introduce BannedApiAnalyzers #6675
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For OrdinalIgnoreCase, this uses string.IndexOf and allocates a string. See dotnet#6671.
Forgind
approved these changes
Jul 15, 2021
src/BannedSymbols.txt
Outdated
| @@ -0,0 +1 @@ | |||
| M:System.Globalization.CompareInfo.IndexOf(System.String,System.Char) | |||
Contributor
There was a problem hiding this comment.
I'm assuming this can't have a copyright banner.
Member
Author
There was a problem hiding this comment.
Roslyn's don't https://github.com/dotnet/roslyn/blob/7fd079ef9d14d04978caaee4baa67d97273cb01d/src/CodeStyle/BannedSymbols.txt
And it doesn't look like the parser supports it
So going with "no".
ladipro
approved these changes
Jul 19, 2021
ladipro
pushed a commit
to ladipro/msbuild
that referenced
this pull request
Jul 20, 2021
- Introduce BannedApiAnalyzers - Ban CompareInfo.IndexOf
Member
|
Manually merged as 78f6ef3 since I don't have permissions to resolve conflicts in @rainersigwald's branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter will make this fail until #6671 is merged.