Correctly interpret slashes Fixes #5715#5734
Merged
Forgind merged 4 commits intodotnet:masterfrom Sep 18, 2020
Merged
Conversation
This causes it to break on Linux, as there is a path long enough to include a slash, even from the .sln.
rainersigwald
approved these changes
Sep 14, 2020
| VisualStudioVersion = 16.0.29326.124 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| Project(""{9A19103F-16F7-4668-BE54-9A1E7A4F7556}"") = ""SimpleProject"", """ + Path.Combine("SimpleProject", "SimpleProject.csproj") + @""", ""{79B5EBA6-5D27-4976-BC31-14422245A59A}"" | ||
| Project(""{9A19103F-16F7-4668-BE54-9A1E7A4F7556}"") = ""SimpleProject"", ""SimpleProject\SimpleProject.csproj"", ""{79B5EBA6-5D27-4976-BC31-14422245A59A}"" |
Member
There was a problem hiding this comment.
Probably worth a comment around here somewhere that hardcoding backslashes is intentional/required to support the common case.
Forgind
added a commit
to Forgind/msbuild
that referenced
this pull request
Sep 25, 2020
MSBuild normalizes slashes such that a solution file can use backslashes in paths on Linux or iOS. This adds that functionality for solution filter files as well. Fixes dotnet#5715.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This first commit should cause it to break on Linux, as it uses the default slashes. If that is correct, I will push the fix I think should work.