Introduce timeout to prevent a hang in CancelledBuild#5290
Merged
Forgind merged 2 commits intodotnet:masterfrom Apr 17, 2020
Merged
Introduce timeout to prevent a hang in CancelledBuild#5290Forgind merged 2 commits intodotnet:masterfrom
Forgind merged 2 commits intodotnet:masterfrom
Conversation
rainersigwald
approved these changes
Apr 16, 2020
Member
rainersigwald
left a comment
There was a problem hiding this comment.
I was so scared seeing this title, but in a test: 👍
| asyncResult.ExecuteAsync(null, null); | ||
| _buildManager.CancelAllSubmissions(); | ||
| asyncResult.WaitHandle.WaitOne(); | ||
| asyncResult.WaitHandle.WaitOne(10000); |
Member
There was a problem hiding this comment.
Suggested change
| asyncResult.WaitHandle.WaitOne(10000); | |
| asyncResult.WaitHandle.WaitOne(TimeSpan.FromSeconds(10)); |
I always prefer the explicit overload, so you don't have to remember units.
| asyncResult.ExecuteAsync(null, null); | ||
| _buildManager.CancelAllSubmissions(); | ||
| asyncResult.WaitHandle.WaitOne(); | ||
| asyncResult.WaitHandle.WaitOne(10000); |
Member
There was a problem hiding this comment.
Comment the arbitrary timeout please.
rainersigwald
added a commit
that referenced
this pull request
Oct 26, 2020
This was attempted in #5290 but we hit a hang in this test again this week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works towards #5229.