Skip to content

Revert slnf feature (and associated System.Text.Json dependency)#5142

Merged
Forgind merged 2 commits intodotnet:masterfrom
Forgind:exp/no-slnf
Feb 24, 2020
Merged

Revert slnf feature (and associated System.Text.Json dependency)#5142
Forgind merged 2 commits intodotnet:masterfrom
Forgind:exp/no-slnf

Conversation

@Forgind
Copy link
Contributor

@Forgind Forgind commented Feb 24, 2020

No description provided.

@rainersigwald rainersigwald changed the title Exp/no slnf Revert slnf feature (and associated System.Text.Json dependency) Feb 24, 2020
@rainersigwald rainersigwald added this to the MSBuild 16.6 Preview1 milestone Feb 24, 2020
@Forgind Forgind merged commit 2e4c186 into dotnet:master Feb 24, 2020
@davkean
Copy link
Member

davkean commented Feb 25, 2020

Why was this reverted?

@Forgind
Copy link
Contributor Author

Forgind commented Feb 25, 2020

VS hadn't had a dependency on System.Text.Json previously, and I was having some trouble with bringing it in properly, since it also required updating some other assemblies to more recent versions. The latest build looks hopeful, but we have things we really want in preview 1 , and this was making it hard.

It will hopefully come back in soon.

Forgind added a commit to Forgind/msbuild that referenced this pull request Mar 18, 2020
Forgind added a commit that referenced this pull request Mar 18, 2020
Forgind added a commit that referenced this pull request Jun 3, 2020
* Revert "Revert "Apply a solution filter (#4899)" (#5142)"

This reverts commit 2e4c186.

* Update System.Text.Json to 4.7.0

* Do not ngen System.Text.Json
Forgind added a commit that referenced this pull request Jun 3, 2020
* Revert "Revert "Apply a solution filter (#4899)" (#5142)"

This reverts commit 2e4c186.

* Update System.Text.Json to 4.7.0

* Do not ngen System.Text.Json

* Innocuous change
Forgind added a commit that referenced this pull request Jun 4, 2020
* Revert "Revert "Apply a solution filter (#4899)" (#5142)"

This reverts commit 2e4c186.

* Update System.Text.Json to 4.7.0

* Add pkgdefs
Forgind added a commit that referenced this pull request Jun 5, 2020
* Revert "Revert "Apply a solution filter (#4899)" (#5142)"

This reverts commit 2e4c186.

* Update System.Text.Json to 4.7.0

* Add pkgdefs

* Move to Build
Forgind added a commit to Forgind/msbuild that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants