Revert "Adding tracking of properties with relevant events. (#4461)"#4663
Merged
rainersigwald merged 1 commit intodotnet:vs16.3from Aug 26, 2019
Merged
Conversation
)" This reverts commit 7150dc9.
rainersigwald
approved these changes
Aug 26, 2019
| // - new record kinds: EnvironmentVariableRead, PropertyReassignment, UninitializedPropertyRead | ||
| internal const int FileFormatVersion = 8; | ||
| // - Include ProjectStartedEventArgs.GlobalProperties | ||
| internal const int FileFormatVersion = 7; |
Member
There was a problem hiding this comment.
This means the viewer doesn't need to be updated. I think we should, however, update to 9 next time we change it, just in case anyone has picked up the change.
Member
|
@livarcocc this shouldn't affect the log viewer |
Contributor
|
/cc @AndyGerlicher |
maneely
added a commit
to maneely/msbuild
that referenced
this pull request
Jan 8, 2020
…otnet#4461)" (dotnet#4663)" This reverts commit faf5e5d.
rainersigwald
pushed a commit
to maneely/msbuild
that referenced
this pull request
Feb 25, 2020
…otnet#4461)" (dotnet#4663)" This reverts commit faf5e5d. Fixing merge error in a comment. Fix another merge issue. Merge fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 7150dc9.
The change being reverted is this:
Customer Impact
Customer won't be able to use the functionality being reverted above. Impact should be minimal, no MSBuild has been released that contains these changes yet.
Regression
This caused MSBuild to allocate a lot more during evaluation and is failing RPS tests in the MSBuild insertion into VS. Without reverting this change, we won't be able to insert into VS.
Risk
Low. This was a clean revert.
@rainersigwald @benvillalobos would this cause another change to the log viewer or are we good there?