Release checklist: read shipped version from VS rel/stable; stop pinging in template#14017
Open
JanProvaznik wants to merge 2 commits into
Open
Release checklist: read shipped version from VS rel/stable; stop pinging in template#14017JanProvaznik wants to merge 2 commits into
JanProvaznik wants to merge 2 commits into
Conversation
…ing in template Phase 5.1a now reads the GA'd MSBuild version from VS rel/stable's .corext/Configs/msbuild-components.json (the authoritative shipped value) instead of relying solely on the VS insertion PR, which targets VS main and can be superseded by a later servicing insertion before GA. THIS_RELEASE_EXACT_VERSION guidance corrected: the shipped version is not always x.0 — an OptProf-driven insertion bump can ship x.1+ (18.7 shipped as 18.7.1). Phase 1.1 no longer @-mentions a specific maintainer (avoids pinging when the template is copied into an issue). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the MSBuild release checklist documentation to make post-GA version determination more reliable and to avoid unnecessary notifications when copying the template into a tracking issue.
Changes:
- Updates guidance to determine the shipped MSBuild version from VS
rel/stableinstead of relying on the VS insertion PR. - Clarifies that the shipped
VersionPrefixis not alwaysx.0(e.g., OptProf-driven insertion bumps can result inx.1+). - Removes a specific
@-mention from the template to avoid pinging maintainers when instantiating a release issue.
…meric VersionPrefix Per Copilot review feedback on dotnet#14017: note that THIS_RELEASE_EXACT_VERSION is not known at instantiation (leave blank until Phase 5.1a), and instruct readers to extract just the numeric VersionPrefix from the rel/stable component version string (dropping the -servicing-NNNNN-NN+<sha> suffix). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
61 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two corrections to the release checklist, learned while running 18.7 post-GA:
Determine the shipped version from VS
rel/stable, not the insertion PR. Phase 5.1a now reads the GA'dMicrosoft.Buildcomponent version from VSrel/stable's.corext/Configs/msbuild-components.json. The VS insertion PR targets VSmainand can be superseded by a later servicing insertion before GA, so it is not authoritative for "what actually shipped."The shipped exact version is not always
x.0. An OptProf-driven insertion bump can shipx.1or higher. 18.7 shipped as18.7.1(18.7.1-servicing-26230-11), even though final branding produced18.7.0. TheTHIS_RELEASE_EXACT_VERSIONinput guidance is corrected accordingly.Also removes the
@-mention of a specific maintainer in Phase 1.1 so that copying the template into a tracking issue doesn't ping anyone.Why
For 18.7, reading the version from the insertion PR (
18.7.1-servicing-26230-11into VSmain) happened to match, but the robust source of truth isrel/stable. Thex.0assumption was actively misleading — it would have produced a wrong tag (v18.7.0) and wrong nupkg names.Doc-only change.