Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the release-branch “version bump check” by correcting how the pipeline reads DotNetFinalVersionKind from eng/Versions.props, ensuring the servicing-branch bump validation runs when the repo is in a release state (including VS Insiders scenarios described in #13451).
Changes:
- Update the version-kind read logic in the CI pipeline to reliably extract the
DotNetFinalVersionKindelement value.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ViktorHofer
approved these changes
Mar 30, 2026
dfederm
pushed a commit
to dfederm/msbuild
that referenced
this pull request
Apr 9, 2026
Fixes dotnet#13451 ### Context Version bump check didn't work. This change should fix that. ### Changes Made Node selection logic was changed. ### Testing Change tested in release branch: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1355155&view=logs&j=6fe8bf02-8a7a-56a7-e3fd-913e2045a877&t=e87b56af-cb98-594d-acd9-14509c9c5689 ### Notes --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13451
Context
Version bump check didn't work. This change should fix that.
Changes Made
Node selection logic was changed.
Testing
Change tested in release branch: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1355155&view=logs&j=6fe8bf02-8a7a-56a7-e3fd-913e2045a877&t=e87b56af-cb98-594d-acd9-14509c9c5689
Notes