Remove duplicate function in FileUtilities.cs#13248
Merged
AR-May merged 1 commit intodotnet:mainfrom Feb 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes duplicated path-canonicalization logic by dropping FrameworkFileUtilities.RemoveRelativeSegments and switching call sites to the existing AbsolutePath.GetCanonicalForm() implementation in the Framework.
Changes:
- Updated
Copy.PathsAreIdenticalto canonicalize viaAbsolutePath.GetCanonicalForm()instead ofFrameworkFileUtilities.RemoveRelativeSegments. - Removed the now-redundant
FrameworkFileUtilities.RemoveRelativeSegmentsmethod fromFileUtilities.cs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Tasks/Copy.cs | Uses AbsolutePath.GetCanonicalForm() for path canonicalization prior to comparison. |
| src/Framework/FileUtilities.cs | Removes duplicated canonicalization helper (RemoveRelativeSegments). |
SimaTian
approved these changes
Feb 13, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Feb 17, 2026
### Context `RemoveRelativeSegments` does the same as `AbsolutePath.GetCanonicalForm()`. There is no need for code duplication. ### Testing Unit tests
JanProvaznik
pushed a commit
to JanProvaznik/msbuild
that referenced
this pull request
Feb 25, 2026
### Context `RemoveRelativeSegments` does the same as `AbsolutePath.GetCanonicalForm()`. There is no need for code duplication. ### Testing Unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
RemoveRelativeSegmentsdoes the same asAbsolutePath.GetCanonicalForm(). There is no need for code duplication.Testing
Unit tests