Expand test instructions into their own file#13212
Merged
rainersigwald merged 1 commit intodotnet:mainfrom Feb 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a dedicated testing instructions file (.github/instructions/tests.instructions.md) for GitHub Copilot to improve the quality of generated test code for the MSBuild repository. The file uses a frontmatter applyTo pattern to scope these instructions to test files in the codebase (src/*.UnitTests/**/*.cs).
Changes:
- Creates comprehensive testing guidelines covering xUnit/Shouldly usage, test infrastructure (TestEnvironment, MockLogger, MockEngine), MSBuild XML formatting in tests, platform-conditional tests, async patterns, and assertion helpers.
baronfel
approved these changes
Feb 6, 2026
Member
Author
|
Merging on red because this doesn't affect existing tests. |
This was referenced Feb 10, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Feb 17, 2026
I got annoyed when reviewing some of the tests Copilot generated in a few recent PRs, so let's try to formalize some of the guidance it wasn't picking up on.
JanProvaznik
pushed a commit
to JanProvaznik/msbuild
that referenced
this pull request
Feb 25, 2026
I got annoyed when reviewing some of the tests Copilot generated in a few recent PRs, so let's try to formalize some of the guidance it wasn't picking up on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got annoyed when reviewing some of the tests Copilot generated in a few recent PRs, so let's try to formalize some of the guidance it wasn't picking up on.