Skip to content

Add EvaluatedItemCheckData#10932

Merged
JanKrivanek merged 2 commits intomainfrom
proto/buildcheck-itemdata
Nov 18, 2024
Merged

Add EvaluatedItemCheckData#10932
JanKrivanek merged 2 commits intomainfrom
proto/buildcheck-itemdata

Conversation

@JanKrivanek
Copy link
Copy Markdown
Member

@JanKrivanek JanKrivanek commented Nov 4, 2024 •
edited
Loading

Context

Adding EvaluatedItemCheckData to BuildCheck OM - to prepare for some sample Item data/metadata Checks implementation

Testing

The leveraging checks:

@JanKrivanek JanKrivanek marked this pull request as ready for review November 8, 2024 10:14
@JanKrivanek JanKrivanek mentioned this pull request Nov 8, 2024
Merged
@maridematte
Copy link
Copy Markdown
Member

maridematte commented Nov 11, 2024

Do we have plans to remove ParsedItemsCheckData in the future? Or are we just going to keep it as an obsolete class?

@JanKrivanek
Copy link
Copy Markdown
Member Author

JanKrivanek commented Nov 12, 2024

Do we have plans to remove ParsedItemsCheckData in the future? Or are we just going to keep it as an obsolete class?

I'd give possible users at least 2 previews to use the new OM. So probably Feb/Mar next year - for 10.0, possibly for 9.0.3xx as well

@maridematte
Copy link
Copy Markdown
Member

maridematte commented Nov 13, 2024

I think adding some documentation or comment somewhere would interesting, so in the future we remember to remove the obsolete methods. Otherwise it might end-up like our Deprecated folder.

This was referenced Nov 17, 2024
Closed
Open
@JanKrivanek
Copy link
Copy Markdown
Member Author

JanKrivanek commented Nov 18, 2024

I think adding some documentation or comment somewhere would interesting, so in the future we remember to remove the obsolete methods. Otherwise it might end-up like our Deprecated folder.

Definitely maes sense. Tracking here: #10985

maridematte
maridematte approved these changes Nov 18, 2024
View reviewed changes
@SimaTian SimaTian self-requested a review November 18, 2024 10:10
@JanKrivanek JanKrivanek merged commit eec6ac7 into main Nov 18, 2024
@JanKrivanek JanKrivanek deleted the proto/buildcheck-itemdata branch November 18, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimaTian SimaTian SimaTian approved these changes

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes

+1 more reviewer

@maridematte maridematte maridematte approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JanKrivanek @maridematte @SimaTian @YuliiaKovalova