Add Build Submission Started event#10424
Merged
maridematte merged 23 commits intodotnet:mainfrom Aug 7, 2024
Merged
Conversation
JanKrivanek
requested changes
Jul 23, 2024
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
This looks good as an initial draft. It needs couple finalization steps:
- de/serialization of the event for node to node communication.
- de/serialization of the event for BinaryLogger (plus version increase)
- unit tests - for the de/serialization
- fixing the build failures
JanKrivanek
reviewed
Jul 24, 2024
JanKrivanek
requested changes
Aug 5, 2024
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks good.
There are couple adjustments needed (versioning, nullable strings ...) - captured in comments
JanKrivanek
approved these changes
Aug 7, 2024
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks good!
Please add the created issue into the sprint - so that it gets handled soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10145
Context
It is currently not possible to check for global variables during build execution. To have access to that data it needs to be passed on events to the processing nodes. None of the events we had previously were good matches to pass along this information, so it was decided to create one for build submission started, as this point in the build we have all properties loaded with the correct value, but its not too late to make use of them.
Changes Made
BuildSubmissionStartedEventArgsbased onBuildStatusEventArgsand added it to the event handlers.BuildRequestDataFlagswas added toMicrosoft.Build.Framework.Testing
To be added.
Notes
Blocker for #9747