-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add BuildSubmissionStartedEventArgs event #10145
Copy link
Copy link
Closed
Labels
Description
Context
We need to distinguish restore is happening for the BuildCheck feature (namely for #9747)
This is not currently possible until receiving BuildEvaluationFinished.
Team decided that it's more future wise to add the full event with all the relevant info, rather than reusing BuildEvaluationStarted event.
Blocked by: #10172
What should be done
- Create new BuildEventArg - named BuildSubmissionStarted
- Add the followind data (they will be sourced from common base of
BuildRequestDataandGraphBuildRequestDataintroduced in Refactor/Unify Build and Graph OM and API #10172):- EntryProjectFullPath(s)
- TargetNames
- Flags (note - the ClearCachesAfterBuild flag might be helpful in the future for BuildCheck dedup)
- GlobalProps
- SubmissionId (from the
PendBuildRequestfunctions)
- Send the event through logging from a location all requests go through (probably https://github.com/dotnet/msbuild/pull/10172/files#diff-2b0716a511d8f4ee690ebd5c3a59dec1e3f9a5eab4ab2a80a1018820a658accbR1370)
- Ensure proper de/serialization in BuildEventsArgReader/Writer
- Increment binlog version, Create Binlog viewer PR (todo: give further instructions here)
Additional notes
This work would ideally unify with:
-
BuildCheckTracingEventArgsde/serialization - Serialize build cancellation event to the binlog #10244 (once Rendering message about build cancellation (Terminal Logger) #10055 is merged)
- Document the binlog update necessary steps #10146
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Fields
Give feedbackNo fields configured for issues without a type.