### Context EmbeddedResource documentation is lacking crucial information that we'd like to guide with dedicated Check. ### To be done * [x] Documentation - [x] Document `RespectAlreadyAssignedItemCulture` in [`AssignCulture` doc](https://learn.microsoft.com/en-us/visualstudio/msbuild/assignculture-task ): https://github.com/MicrosoftDocs/visualstudio-docs-pr/pull/13363 - [x] Add better description of the Culture infering and configuring process in [`EmbeddedResource` doc](https://learn.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-items#embeddedresource): https://github.com/MicrosoftDocs/visualstudio-docs-pr/pull/13364 * doc `Culture` and `WithCulture` metadata there as well. No other metadata * `Culture` / `WithCulture` should be here as well https://learn.microsoft.com/en-us/visualstudio/msbuild/generateresource-task#example - [ ] Investigation - [ ] https://github.com/dotnet/msbuild/issues/10536 - I believe any Culture descriptor should be honored when set explicitly. PR: https://github.com/dotnet/msbuild/pull/11000 - [ ] Get more details from Sam Harwell on intended behavior for 'NetrualLanguage' https://github.com/dotnet/msbuild/issues/9882#issuecomment-2010752581 - [ ] Implementation ~~- [ ] Whatever is decided for the 'NetrualLanguage' handling~~ - [ ] Add BuildCheck (suggestion only for now) that is strict on setting Culture or WithCulture: https://github.com/dotnet/msbuild/issues/9882 (https://github.com/dotnet/msbuild/issues/9154) - [ ] Flip the culture respecting opt-in via `RespectAlreadyAssignedItemCulture` introduced in https://github.com/dotnet/msbuild/pull/10026 to opt-out - as we now want to suggest explicit using of `Culture`. Hide behind changewave. Detect the clash of explicit and implicitly detected culture (as that's the case where there would be a change in behavior) - and emit warning for that. - Seems to be already handled by https://github.com/dotnet/sdk/pull/41042 ### Notes More info: [[Internal discussion link](https://teams.microsoft.com/l/message/19:a15e1e2b222b47388462f825932efb82@thread.tacv2/1730965817659?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=f136bf3b-1656-40aa-b7b3-50ea73de9268&parentMessageId=1730965817659&teamName=Prague%20.NET%20DEV%20UX%20%26%20Tools%20Team&channelName=MSBUILD%20Team&createdTime=1730965817659)]
Context
EmbeddedResource documentation is lacking crucial information that we'd like to guide with dedicated Check.
To be done
RespectAlreadyAssignedItemCultureinAssignCulturedoc: https://github.com/MicrosoftDocs/visualstudio-docs-pr/pull/13363EmbeddedResourcedoc: https://github.com/MicrosoftDocs/visualstudio-docs-pr/pull/13364CultureandWithCulturemetadata there as well. No other metadataCulture/WithCultureshould be here as well https://learn.microsoft.com/en-us/visualstudio/msbuild/generateresource-task#example- [ ] Whatever is decided for the 'NetrualLanguage' handlingEmbeddedResource#9154)RespectAlreadyAssignedItemCultureintroduced in Update AssignCulture Task to support existing Culture metadata #10026 to opt-out - as we now want to suggest explicit using ofCulture. Hide behind changewave. Detect the clash of explicit and implicitly detected culture (as that's the case where there would be a change in behavior) - and emit warning for that. - Seems to be already handled by Enable the Respecting Item's Culture by default sdk#41042Notes
More info: [Internal discussion link]