Enable the Respecting Item's Culture by default#41042
Merged
marcpopMSFT merged 5 commits intodotnet:mainfrom Jun 11, 2024
Merged
Enable the Respecting Item's Culture by default#41042marcpopMSFT merged 5 commits intodotnet:mainfrom
marcpopMSFT merged 5 commits intodotnet:mainfrom
Conversation
baronfel
reviewed
May 29, 2024
| <GenerateResourceWarnOnBinaryFormatterUse>true</GenerateResourceWarnOnBinaryFormatterUse> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(RespectAlreadyAssignedItemCulture)' == '' and '$(TargetFrameworkIdentifier)' == '.NETCoreApp' and $([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), '9.0'))"> |
Member
There was a problem hiding this comment.
@rainersigwald we should be using MSBuild changewave checks here, right?
Member
There was a problem hiding this comment.
I'm not sure I prefer that to a TF check like this, would we really want to change behavior on this based on SDK?
Member
There was a problem hiding this comment.
Oh duh, now the conversation comes flooding back to me. Yes I agree now, and we can disregard my earlier question.
rainersigwald
approved these changes
Jun 4, 2024
dsplaisted
approved these changes
Jun 7, 2024
Member
dsplaisted
left a comment
There was a problem hiding this comment.
Looks good. I'm not sure we need an automated test for this since it looks like it's covered in MSBuild, but it would be good to do manual sanity testing.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSBuild task: AssignCulture was recently updated and new parameter of the task was added:
RespectAlreadyAssignedItemCulture property. dotnet/msbuild#10026
Related issues:
dotnet/msbuild#1454
dotnet/msbuild#9954