Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/msbuild
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 472dea3
Choose a base ref
...
head repository: dotnet/msbuild
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d89d4bc
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Jan 6, 2023

  1. Stop dumping stack for BadImageFormatException (#8271) 

    Fixes #6224

Context
See issue -- a change was made to add more detail when RAR fails to resolve a reference due to encountering a BIFE. This added too much detail -- not only the message from the inner exception, but also the callstack. We should not dump callstack when there is no bug in MSBuild (or a task/logger).

Oddly enough I hit this again #8140 and didn't remember the original discussion, and therefore again assumed there was a bug.

Changes Made
Fix BIFE to include the message from any inner exception. (There was a suggestion in the issue that it also include the exception type, but I don't know of any case where the type is necessary in order to disambiguate what happened, and we don't have precedent for doing it. It would also be ugly.)
Revert the original change, now unnecesssary.

Testing
Added test that fails without the fix.
    @danmoseley
    danmoseley authored Jan 6, 2023
    Configuration menu
    Copy the full SHA
    d89d4bc View commit details
    Browse the repository at this point in the history
Loading