Stop dumping stack for BadImageFormatException#8271
Merged
JaynieBai merged 2 commits intodotnet:mainfrom Jan 6, 2023
Merged
Conversation
Member
Author
Member
|
Thanks for putting up a PR Dan! Agreed the stack trace looks like it's a bug in MSBuild. |
Member
|
Somehow I forgot that we'd discussed this last year and you've even provided a way to aggregate messages: |
Member
Author
|
@Forgind does this look good to merge? |
rainersigwald
approved these changes
Jan 5, 2023
KirillOsenkov
approved these changes
Jan 5, 2023
Contributor
Looks good to me! |
Member
Author
|
could someone merge it then :) |
Member
|
My understanding is that since it's marked with the |
Member
Author
|
Oh! I see -- I should have figured that out. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6224
Context
See issue -- a change was made to add more detail when RAR fails to resolve a reference due to encountering a BIFE. This added too much detail -- not only the message from the inner exception, but also the callstack. We should not dump callstack when there is no bug in MSBuild (or a task/logger).
Oddly enough I hit this again #8140 and didn't remember the original discussion, and therefore again assumed there was a bug.
Changes Made
Testing
Added test that fails without the fix.
Notes