PR Test Evaluation Report

PR: #34812 — [iOS] Fix Label with TailTruncation not rendering after empty-to-non-empty text transition
Test files evaluated: 2 (Issue34591.cs in HostApp + Shared.Tests)
Fix files: 1 (src/Controls/src/Core/Label/Label.cs)

Overall Verdict

✅ Tests are adequate

The test correctly targets the reported failure scenario and directly verifies the observable outcome of the fix.

1. Fix Coverage — ✅

The fix adds a new condition in TextPropertyChanged:

if (TextChangedShouldInvalidateMeasure(label) || (wasEmpty != isEmpty && IsLabelSizeable(label)))
    label.InvalidateMeasureInternal(InvalidationTrigger.MeasureChanged);

The test creates a Label with LineBreakMode.TailTruncation and no initial text (null), then taps a button that sets resultLabel.Text = "Test", and asserts rect.Height > 0. This precisely exercises the newly added wasEmpty != isEmpty branch — without the fix, TextChangedShouldInvalidateMeasure would return false for a single-line horizontally-fixed label, causing the label to keep zero height. ✅ The test would fail if the fix were reverted.

2. Edge Cases & Gaps — ⚠️

Covered:

• null → non-empty text transition (the reported bug case)

Missing (minor):

• "" (empty string) → non-empty transition — the fix handles string.IsNullOrEmpty, so both null and "" trigger the new path, but only null is tested
• non-empty → null/empty transition (reverse direction) — would the label return to zero height? The fix also applies to this direction (wasEmpty != isEmpty), but it's untested

These gaps are minor: the primary bug scenario is well-covered, and the reverse transitions are lower-priority follow-ons.

3. Test Type Appropriateness — ✅

Current: UI Test (Appium, TestCases.Shared.Tests)
Recommendation: Same — UI test is justified here.

The bug is a visual rendering failure: after setting text, the label height remains 0 on screen. This requires a native layout pass to verify, which is not easily testable at the unit test level without mocking the entire layout engine. A device test could verify the handler calls InvalidateMeasureInternal, but that would be testing implementation details. Measuring rect.Height via Appium is the most direct verification of the fix's observable effect.

4. Convention Compliance — ✅

All new test files follow conventions correctly:

• ✅ Naming: Issue34591.cs matches the IssueXXXXX pattern
• ✅ [Issue()] attribute: Present on HostApp page with correct tracker, number, description, and PlatformAffected.iOS
• ✅ [Category(UITestCategories.Label)]: Exactly one category attribute on the test method
• ✅ Base class: _IssuesUITest in the shared test; TestContentPage in HostApp (appropriate pattern for Init())
• ✅ WaitForElement before interaction: App.WaitForElement("UpdateTextButton") precedes App.Tap("UpdateTextButton")
• ✅ No Task.Delay/Thread.Sleep
• ✅ No inline #if directives
• ✅ No obsolete APIs (Application.MainPage, Frame, etc.)
• ✅ C# only for the HostApp page (XAML not needed here)

Note: The script reported 168 total convention issues, but these are all in pre-existing test files unrelated to this PR's changes.

5. Flakiness Risk — ✅ Low

• App.WaitForElement("UpdateTextButton") provides proper synchronization before the tap
• App.WaitForElement("ResultLabel") ensures the element is present before calling GetRect()
• No screenshot assertions (no cursor-blink risk)
• No animation involved — the transition is a simple property change
• No Task.Delay or Thread.Sleep
• No external dependencies

6. Duplicate Coverage — ✅ No duplicates

Existing MauiLabel tests cover unrelated scenarios (e.g., Issue18775, Issue27992, Issue29233, Issue29882). None test the TailTruncation + empty→non-empty text transition. No consolidation needed.

7. Platform Scope — ✅

The [Issue] attribute declares PlatformAffected.iOS, correctly reflecting where the bug was reported. The fix is in cross-platform Label.cs, so it benefits all platforms, but the visible failure was iOS-specific. The test itself will run on all platforms (no skip annotation), which is fine — other platforms should pass cleanly with or without the fix.

8. Assertion Quality — ✅

Assert.That(rect.Height, Is.GreaterThan(0),
    "Label should have non-zero height after setting text from null");

• ✅ Specific: Directly measures the symptom of the bug (height = 0 without fix, > 0 with fix)
• ✅ Not brittle: > 0 rather than a magic pixel value, so it's stable across devices and font sizes
• ✅ Descriptive message: Explains what the assertion is testing

9. Fix-Test Alignment — ✅

Perfect alignment between fix and test.

Recommendations

1. (Optional, low-priority) Add a test step for the "" → "Test" transition to cover the string.IsNullOrEmpty("") path explicitly, though this is not blocking.
2. (Optional) Consider verifying that the label also reverts to zero height (or near-zero) when text is cleared back to null/empty, to guard against future regressions in that direction.