Skip to content

[net11] Fix internal pipeline: remove deleted SDLValidationParameters#34651

Merged
rmarinho merged 1 commit intonet11.0from
fix/net11-remove-sdl-params
Mar 25, 2026
Merged

[net11] Fix internal pipeline: remove deleted SDLValidationParameters#34651
rmarinho merged 1 commit intonet11.0from
fix/net11-remove-sdl-params

Conversation

@rmarinho
Copy link
Copy Markdown
Member

Problem

The Arcade SDK update to 11.0.0-beta.26166.111 (PR #34314) removed the SDLValidationParameters parameter from eng/common/core-templates/post-build/post-build.yml, but ci-official.yml still passed it.

Azure DevOps rejects undeclared template parameters during YAML expansion, causing every net11.0 internal build to fail instantly (0s duration, no stages/timeline) since March 18.

15+ consecutive builds affected, including scheduled daily builds and CI-triggered builds.

Fix

Remove the SDLValidationParameters block from eng/pipelines/ci-official.yml — it references a parameter that no longer exists in the post-build template.

Verification

  • Confirmed main branch still has the parameter in its Arcade SDK (10.0.0-beta.25555.106) — only net11.0 is affected
  • Confirmed the parameter was removed in the Arcade SDK diff (11.0.0-beta.26166.111)
  • Validated on dnceng internal pipeline that the fix allows YAML expansion to succeed

The Arcade SDK update to 11.0.0-beta.26166.111 (PR #34314) removed the
SDLValidationParameters parameter from the post-build template, but
ci-official.yml still passed it. Azure DevOps rejects undeclared template
parameters during YAML expansion, causing every net11.0 internal build
to fail instantly (0s, no stages) since March 18.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 25, 2026 17:24
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34651

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34651"

@rmarinho
Copy link
Copy Markdown
Member Author

/backport to release/11.0.1xx-preview3

@github-actions
Copy link
Copy Markdown
Contributor

Started backporting to release/11.0.1xx-preview3 (link to workflow run)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an obsolete SDLValidationParameters template parameter from the official CI pipeline definition so Azure DevOps YAML expansion succeeds again on net11.0 after the Arcade SDK template update.

Changes:

  • Deletes the SDLValidationParameters block from the post-build.yml template invocation in ci-official.yml.
  • Keeps the publishDependsOn: - Validate dependency intact while removing the undeclared parameter.

@rmarinho rmarinho merged commit 837be64 into net11.0 Mar 25, 2026
29 of 40 checks passed
@rmarinho rmarinho deleted the fix/net11-remove-sdl-params branch March 25, 2026 18:59
rmarinho added a commit that referenced this pull request Mar 25, 2026
…eted SDLValidationParameters (#34652)

Backport of #34651 to release/11.0.1xx-preview3

/cc @rmarinho

Co-authored-by: Rui Marinho <me@ruimarinho.net>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants