[Android] Shell Flyout: Apply safe-area insets to the flyout container by devanathan-vaithiyanathan · Pull Request #34510 · dotnet/maui

devanathan-vaithiyanathan · 2026-03-17T07:58:10Z

Issue Details

On Android, Shell flyout content was not consistently offset for SystemBars/DisplayCutout insets in landscape mode. That left flyout items exposed to the notch and status bar area.

Description of Change

This change simplifies ShellFlyoutTemplatedContentRenderer.WindowsListener so the flyout CoordinatorLayout consumes the window insets and applies the max of SystemBars and DisplayCutout insets as padding on the container itself.

That replaces the older per-subview logic that separately adjusted the app bar, flyout content, footer, and background image.

Issues Fixed

Fixes #32275

Before	After
Android Android-Before.mov	Android Android-After.mov

github-actions · 2026-03-17T07:58:20Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34510

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34510"

Copilot

Pull request overview

Adjusts Android Shell flyout insets handling so flyout content respects safe-area/system insets (notch/status bar), addressing the reported landscape collision regression.

Changes:

Simplifies WindowsListener inset application to pad the flyout CoordinatorLayout using the max of SystemBars and DisplayCutout insets (left/top/right/bottom).
Removes per-subview inset handling (flyout view/footer/bg image/appbar special-casing) and associated weak-reference plumbing.
Updates listener instantiation and removes now-unused listener property assignments.

You can also share your feedback on Copilot code review. Take the survey.

...ontrols/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs

devanathan-vaithiyanathan · 2026-03-18T09:48:00Z

🤖 AI Summary

📊 Expand Full Review — 78a9b4f · android shell flyout fix added
🔍 Pre-Flight — Context & Validation
Issue: #32275 - [NET10] SafeAreaEdges cannot be set for Shell and the flyout menu collides with display notch and status bar in landscape mode PR: #34510 - [Android] Fix Shell Flyout SafeArea Rendering Platforms Affected: Android (Android 15 emulator; landscape flyout safe-area regression) Files Changed: 1 implementation, 0 test

Key Findings

The linked issue is an Android Shell flyout regression introduced in .NET 10 RC2: when rotated to landscape, the open flyout ignores left/top safe-area insets and collides with the notch/status bar.

Issue discussion adds an edge case around Shell pages with a root ScrollView, where navigating away and back in landscape can also leave content covered by the cutout.

PR [Android] Fix Shell Flyout SafeArea Rendering #34510 changes only src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs and adds no UI, device, or unit tests.

The PR simplifies flyout inset handling by padding the flyout CoordinatorLayout with the max of SystemBars and DisplayCutout insets, removing the previous per-subview special casing.

Inline review feedback flags two concerns: a stale comment claiming the flyout should not be inset, and possible footer-width/layout issues when left/right padding is applied to the parent container.

No prior agent review summary was found in the PR discussion.

Fix Candidates

Source Approach Test Result Files Changed Notes

PR PR #34510 Apply system/display-cutout padding directly to the flyout CoordinatorLayout and remove child-specific inset plumbing. ⏳ PENDING (Gate) src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs Original PR; no tests included in the PR.
🚦 Gate — Test Verification

Gate Result: ⚠️ SKIPPED

Result: ❌ SKIPPED

Platform: android Mode: Full Verification

Tests FAIL without fix: ❌

Tests PASS with fix: ❌

No PR-added test files were found under TestCases.HostApp or TestCases.Shared.Tests, so full fail-without-fix/pass-with-fix verification could not be executed for this review. The PR should add or reference a reproducible UI test for the Shell flyout landscape safe-area regression.

🔧 Fix — Analysis & Comparison

Fix Candidates

Source Approach Test Result Files Changed Notes

1 try-fix (claude-opus-4.6) Preserve the old per-element inset logic and add missing left/right inset propagation instead of padding the entire coordinator uniformly. ❌ FAIL 1 file 189/190 Shell tests passed; ShouldFlyoutTextWrapsInLandscape screenshot diff (7.96%) shows broad horizontal inset use changes baseline-sensitive layout.
2 try-fix (claude-sonnet-4.6) Apply displayCutout.Left only to flyout children (app bar, flyout content, background) while preserving the existing footer-aware structure. ✅ PASS 1 file 190/190 Shell tests passed; simplest passing fix and avoids the coordinator/footer width coupling concern.
3 try-fix (gpt-5.3-codex) Make child margins and footer width inset-aware instead of changing coordinator padding. ❌ FAIL 1 file Build/deploy succeeded, but the Android Shell test run stalled before completion.
4 try-fix (gemini-3-pro-preview) Apply display-cutout horizontal padding at child level and keep top/bottom handling separate. ✅ PASS 1 file 190/190 Shell tests passed; valid, but more invasive than candidate #2.
5 try-fix (claude-opus-4.6) Shrink flyout width using safe bounds/WindowMetrics and offset it horizontally instead of padding. ❌ FAIL 1 file Broke dynamic flyout sizing (Shell.FlyoutWidth) and failed 4 Shell tests.
PR PR #34510 Apply system/display-cutout padding directly to the flyout CoordinatorLayout and remove child-specific inset plumbing. ⚠️ NOT VERIFIED 1 file Gate skipped because the PR includes no verification test; inline review also raised footer-width/layout concerns.

Cross-Pollination

Model Round New Ideas? Details
claude-opus-4.6 2 Yes NEW IDEA: compute flyout width from WindowMetrics safe bounds and offset X instead of padding/margins. Tested as Candidate #5 and failed.
claude-sonnet-4.6 2 No NO NEW IDEAS
gpt-5.3-codex 2 No NO NEW IDEAS
gemini-3-pro-preview 2 No NO NEW IDEAS
Exhausted: Yes Selected Fix: Candidate #2 — it is the simplest passing alternative, preserves the established footer/layout behavior, and avoids the PR's coordinator-level horizontal padding risk.

📋 Report — Final Recommendation

⚠️ Final Recommendation: REQUEST CHANGES

Final Recommendation: REQUEST CHANGES

Phase Status

Phase Status Notes
Pre-Flight ✅ COMPLETE Android Shell flyout safe-area regression documented from issue #32275; PR changes one implementation file and adds no tests.
Gate ⚠️ SKIPPED Android; full FAIL-without-fix / PASS-with-fix verification could not run because the PR includes no UI test for the regression.
Try-Fix ✅ COMPLETE 5 attempts total, 2 passing alternatives; Candidate #2 selected as the best validated fix.
Report ✅ COMPLETE

Summary

PR #34510 targets the correct Android Shell flyout regression, but it arrives without a dedicated verification test and chooses a broader coordinator-level padding approach than necessary. The mandatory try-fix exploration found a simpler passing alternative that keeps the existing per-child/footer-aware layout model and only injects DisplayCutout.Left into the flyout children, passing 190/190 Android Shell tests.

Root Cause

The regression appears to be that the Shell flyout no longer respects the landscape display cutout on Android, so content can start underneath the notch/status region. However, broad use of SystemBars horizontal insets also captures landscape navigation-bar space on the emulator, shrinking the flyout enough to change text wrapping and screenshot baselines. Applying horizontal insets at the wrong layout level also risks breaking footer sizing because UpdateFooterLayout() uses _flyoutWidth as an exact width.

Fix Quality

The PR's current fix is not sufficiently verified and may be over-broad: it pads the entire CoordinatorLayout on all sides, removes the prior footer/appbar/background-specific handling, and leaves an open review concern about footer layout under left/right padding. Candidate #2 demonstrates that a narrower child-level cutout fix can satisfy current Shell coverage without disturbing footer width semantics. This PR should be revised toward that smaller strategy and should add a reproducible UI test for #32275 so Gate can perform full fail-without-fix/pass-with-fix validation.

📋 Expand PR Finalization Review

PR #34510 Finalization Review

Title Review

Current: [Android] Fix Shell Flyout SafeArea Rendering

Assessment: Good direction, but a bit generic for a squash/merge commit title.

Recommended title: [Android] Shell Flyout: Apply safe-area insets to the flyout container

Why:

Keeps the Android scope.

Names the affected component (Shell Flyout).

Describes the actual implementation change rather than just saying "fix".

Description Review

Assessment: The current description is too light for merge.

What is good:

It identifies the affected area (Shell Flyout).

It links the right issue (Fixes #32275).

It states the user-visible goal (render within safe area in portrait/landscape).

What is missing:

The required NOTE block at the top.

The root cause.

The actual implementation detail: the PR removes the prior per-subview inset handling and instead applies all system-bar/display-cutout insets as padding on the flyout CoordinatorLayout.

Any mention of potential side effects or behavior changes for footer/background/header layout.

Recommended Description

[!NOTE]
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root Cause

On Android, Shell flyout content was not consistently offset for SystemBars/DisplayCutout insets in landscape mode. That left flyout items exposed to the notch and status bar area.

Description of Change

This change simplifies ShellFlyoutTemplatedContentRenderer.WindowsListener so the flyout CoordinatorLayout consumes the window insets and applies the max of SystemBars and DisplayCutout insets as padding on the container itself.

That replaces the older per-subview logic that separately adjusted the app bar, flyout content, footer, and background image.

Key Technical Details

ShellFlyoutTemplatedContentRenderer.WindowsListener now computes left, top, right, and bottom insets from SystemBars and DisplayCutout.

The listener applies those values with v.SetPadding(leftInset, topInset, rightInset, bottomInset) on the flyout CoordinatorLayout.

The PR removes the older weak-reference plumbing for FlyoutView, FooterView, and the background image.

Issues Fixed

Fixes #32275

Code Review Findings

🔴 Important issue

Footer sizing does not match the new padded container model

File: src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs

Relevant code: WindowsListener.OnApplyWindowInsets() and UpdateFooterLayout()

Problem: The new implementation applies left/right padding to the parent CoordinatorLayout, but UpdateFooterLayout() still sizes the footer using _flyoutWidth, which is the full measured width of the flyout view. That means the footer can still be laid out against the unpadded width instead of the padded content width.

Why this matters: The main issue is about flyout content respecting the safe area. With a flyout footer present, the footer can still extend into or align against the unsafe inset region, which breaks the same layout model the PR is trying to enforce.

Recommendation: Base the footer width on the available content width (_flyoutWidth - _rootView.PaddingLeft - _rootView.PaddingRight) or switch the footer layout params to MatchParent so it naturally follows the parent padding.

🟡 Suggestions

Update the inline comment above the inset logic. It currently says the flyout overlaps the status bar so insetting it is not important, but the new code now explicitly applies top/left/right/bottom insets.

Add a targeted UI test for Android Shell flyout landscape safe-area behavior, ideally covering a flyout with a footer, since this change alters container-level layout rather than just content placement.

Overall Assessment

Metadata: Needs improvement before merge. The title is acceptable but can be more specific; the description should be expanded and should include the required NOTE block.

Code: The simplification is understandable and CI is green, but I do not consider this fully ready for merge until the footer-width interaction with parent padding is addressed or proven safe.

@kubaflo , I have addressed the AI review summary.

devanathan-vaithiyanathan · 2026-03-19T07:11:09Z

🤖 AI Summary

📊 Expand Full Review — bf74de2 · co pilot changes added
🔍 Pre-Flight — Context & Validation
Issue: #32275 - [NET10] SafeAreaEdges cannot be set for Shell and the flyout menu collides with display notch and status bar in landscape mode PR: #34510 - [Android] Fix Shell Flyout SafeArea Rendering Platforms Affected: Android (Android 15 emulator; landscape flyout safe-area regression) Files Changed: 1 implementation, 0 test

Key Findings

The linked issue is an Android Shell flyout regression introduced in .NET 10 RC2: when rotated to landscape, the open flyout ignores left/top safe-area insets and collides with the notch/status bar.

Issue discussion adds an edge case around Shell pages with a root ScrollView, where navigating away and back in landscape can also leave content covered by the cutout.

PR [Android] Shell Flyout: Apply safe-area insets to the flyout container #34510 changes only src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs and adds no UI, device, or unit tests.

The PR simplifies flyout inset handling by padding the flyout CoordinatorLayout with the max of SystemBars and DisplayCutout insets, removing the previous per-subview special casing.

Inline review feedback flags two concerns: a stale comment claiming the flyout should not be inset, and possible footer-width/layout issues when left/right padding is applied to the parent container.

No prior agent review summary was found in the PR discussion.

Fix Candidates

Source Approach Test Result Files Changed Notes

PR PR #34510 Apply system/display-cutout padding directly to the flyout CoordinatorLayout and remove child-specific inset plumbing. ⏳ PENDING (Gate) src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs Original PR; no tests included in the PR.
Issue: #32275 - [NET10] SafeAreaEdges cannot be set for Shell and the flyout menu collides with display notch and status bar in landscape mode PR: #34510 - [Android] Shell Flyout: Apply safe-area insets to the flyout container Platforms Affected: Android (Android 15 emulator; Shell flyout in landscape) Files Changed: 1 implementation, 0 test

Key Findings

The linked issue is an Android Shell flyout regression in landscape mode: flyout items can render under the display cutout/status bar.

The PR changes only src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs; it does not add UI, device, or unit tests.

A prior agent review summary exists in the PR discussion and was imported for this review. It already ran the mandatory try-fix exploration on the earlier core approach.

The PR was updated after that earlier review via commits 6e419cba and bf74de23, which addressed the stale comment, changed footer width handling to LP.MatchParent, and removed an unnecessary stored listener field.

Those follow-up commits do not change the central strategy: the PR still applies max SystemBars/DisplayCutout padding directly to the root CoordinatorLayout.

Current-diff review shows a remaining correctness risk: _bgImage is a MATCH_PARENT child of the padded CoordinatorLayout, so FlyoutBackgroundImage can stop covering the top safe-area/status-bar region.

Fix Candidates

Source Approach Test Result Files Changed Notes

PR PR #34510 Apply max SystemBars/DisplayCutout insets as root CoordinatorLayout padding; keep footer width aligned with parent padding via LP.MatchParent. ⏳ PENDING / Gate skipped src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs Current PR head includes follow-up commits addressing earlier comment/footer-review feedback.
🚦 Gate — Test Verification

Gate Result: ⚠️ SKIPPED

Result: ❌ SKIPPED

Platform: android Mode: Full Verification

Tests FAIL without fix: ❌

Tests PASS with fix: ❌

No PR-added test files were found under TestCases.HostApp or TestCases.Shared.Tests, so full fail-without-fix/pass-with-fix verification could not be executed for this review. The PR should add or reference a reproducible UI test for the Shell flyout landscape safe-area regression.

Gate Result: ⚠️ SKIPPED

Platform: android Mode: Full Verification

Tests FAIL without fix: ❌

Tests PASS with fix: ❌

Gate was skipped because PR #34510 adds no files under TestCases.HostApp or TestCases.Shared.Tests, so there is no PR-added regression test for #32275 to run through verify-tests-fail-without-fix.

A task agent confirmed the skip condition: the PR changes only src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs and contains no qualifying UI test additions.

🔧 Fix — Analysis & Comparison

Gate Result: ⚠️ SKIPPED

Result: ❌ SKIPPED

Platform: android Mode: Full Verification

Tests FAIL without fix: ❌

Tests PASS with fix: ❌

No PR-added test files were found under TestCases.HostApp or TestCases.Shared.Tests, so full fail-without-fix/pass-with-fix verification could not be executed for this review. The PR should add or reference a reproducible UI test for the Shell flyout landscape safe-area regression.

Fix Candidates

Imported from the prior agent review summary in the PR discussion after verifying that later commits only adjusted comment/footer/listener details and did not change the core root-padding strategy under review.

Source Approach Test Result Files Changed Notes

1 try-fix (claude-opus-4.6) Preserve the old per-element inset logic and add missing left/right inset propagation instead of padding the entire coordinator uniformly. ❌ FAIL 1 file 189/190 Shell tests passed; ShouldFlyoutTextWrapsInLandscape screenshot diff (7.96%) showed the broader horizontal inset change affecting layout baselines.
2 try-fix (claude-sonnet-4.6) Apply displayCutout.Left only to flyout children (app bar, flyout content, background) while preserving the existing footer-aware structure. ✅ PASS 1 file 190/190 Shell tests passed; simplest passing alternative and avoids root-padding side effects.
3 try-fix (gpt-5.3-codex) Make child margins and footer width inset-aware instead of changing coordinator padding. ❌ FAIL 1 file Build/deploy succeeded, but the Android Shell test run stalled before completion.
4 try-fix (gemini-3-pro-preview) Apply display-cutout horizontal padding at child level and keep top/bottom handling separate. ✅ PASS 1 file 190/190 Shell tests passed; valid but more invasive than candidate #2.
5 try-fix (claude-opus-4.6, round 2) Shrink flyout width using safe bounds/WindowMetrics and offset it horizontally instead of padding/margins. ❌ FAIL 1 file Broke dynamic flyout sizing (Shell.FlyoutWidth) and failed 4 Shell tests.
PR PR #34510 Apply max SystemBars/DisplayCutout padding directly to the root CoordinatorLayout, with footer width changed to LP.MatchParent in follow-up review fixes. ⚠️ NOT VERIFIED 1 file Gate was skipped because the PR still adds no issue-specific regression test. Current-diff review also found a FlyoutBackgroundImage coverage regression risk caused by root padding.

Cross-Pollination

Model Round New Ideas? Details
claude-opus-4.6 2 Yes NEW IDEA: compute flyout width from WindowMetrics safe bounds and offset X instead of padding/margins. Tested as candidate #5 and failed.
claude-sonnet-4.6 2 No NO NEW IDEAS
gpt-5.3-codex 2 No NO NEW IDEAS
gemini-3-pro-preview 2 No NO NEW IDEAS
Exhausted: Yes Selected Fix: Candidate #2 — it is the simplest passing alternative, preserves the established footer/background-aware layout model, and avoids the measurement side effects introduced by root-level horizontal padding.

📋 Report — Final Recommendation

⚠️ Final Recommendation: REQUEST CHANGES

Final Recommendation: REQUEST CHANGES

Phase Status

Phase Status Notes
Pre-Flight ✅ COMPLETE Android Shell flyout safe-area regression documented from issue #32275; PR changes one implementation file and adds no tests.
Gate ⚠️ SKIPPED Android; full FAIL-without-fix / PASS-with-fix verification could not run because the PR includes no UI test for the regression.
Try-Fix ✅ COMPLETE 5 attempts total, 2 passing alternatives; Candidate #2 selected as the best validated fix.
Report ✅ COMPLETE

Summary

PR #34510 targets the correct Android Shell flyout regression, but it arrives without a dedicated verification test and chooses a broader coordinator-level padding approach than necessary. The mandatory try-fix exploration found a simpler passing alternative that keeps the existing per-child/footer-aware layout model and only injects DisplayCutout.Left into the flyout children, passing 190/190 Android Shell tests.

Root Cause

The regression appears to be that the Shell flyout no longer respects the landscape display cutout on Android, so content can start underneath the notch/status region. However, broad use of SystemBars horizontal insets also captures landscape navigation-bar space on the emulator, shrinking the flyout enough to change text wrapping and screenshot baselines. Applying horizontal insets at the wrong layout level also risks breaking footer sizing because UpdateFooterLayout() uses _flyoutWidth as an exact width.

Fix Quality

The PR's current fix is not sufficiently verified and may be over-broad: it pads the entire CoordinatorLayout on all sides, removes the prior footer/appbar/background-specific handling, and leaves an open review concern about footer layout under left/right padding. Candidate #2 demonstrates that a narrower child-level cutout fix can satisfy current Shell coverage without disturbing footer width semantics. This PR should be revised toward that smaller strategy and should add a reproducible UI test for #32275 so Gate can perform full fail-without-fix/pass-with-fix validation.

⚠️ Final Recommendation: REQUEST CHANGES

Phase Status

Phase Status Notes
Pre-Flight ✅ COMPLETE Imported issue/PR context, confirmed post-review follow-up commits, and reviewed the current diff.
Gate ⚠️ SKIPPED Android; no PR-added TestCases.HostApp / TestCases.Shared.Tests regression test exists for #32275.
Try-Fix ✅ COMPLETE Imported prior mandatory multi-model exploration; 5 candidates total, 2 passing alternatives, candidate #2 selected.
Report ✅ COMPLETE

Summary

PR #34510 targets the right Android Shell flyout regression and already addressed two earlier review items in follow-up commits: the stale inset comment and footer sizing now using LP.MatchParent. However, the current diff still has a substantive correctness issue and no dedicated regression test, so it is not ready to approve.

Root Cause

The issue is about landscape Shell flyout content rendering under the display cutout / status bar on Android. The PR solves this by moving inset handling to the root CoordinatorLayout, but that changes measurement semantics for every MATCH_PARENT child under the flyout. In particular, _bgImage is added as a direct child of the padded root view, so FlyoutBackgroundImage can stop extending into the top safe-area/status-bar strip and leave that region painted only by the container background instead of the configured image.

Fix Quality

The current PR is cleaner than the original revision, but the root-padding strategy still looks too broad and remains unverified by an issue-specific test. The imported try-fix exploration found a simpler passing alternative (candidate #2) that keeps the existing child-level/footer-aware model and limits the horizontal adjustment to the cutout-sensitive content instead of the whole container. This PR should be revised toward that narrower approach and should add a reproducible Android UI regression test for #32275 so Gate can perform fail-without-fix / pass-with-fix verification.

Current-Diff Blocking Issue

src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs: applying padding directly to the root CoordinatorLayout causes the MATCH_PARENT _bgImage child to be measured inside the padded content bounds rather than the full flyout bounds, so FlyoutBackgroundImage no longer reliably covers the top inset/status-bar region.

📋 Expand PR Finalization Review

PR #34510 Finalization Review

Title Review

Current: [Android] Fix Shell Flyout SafeArea Rendering

Assessment: Good direction, but a bit generic for a squash/merge commit title.

Recommended title: [Android] Shell Flyout: Apply safe-area insets to the flyout container

Why:

Keeps the Android scope.

Names the affected component (Shell Flyout).

Describes the actual implementation change rather than just saying "fix".

Description Review

Assessment: The current description is too light for merge.

What is good:

It identifies the affected area (Shell Flyout).

It links the right issue (Fixes #32275).

It states the user-visible goal (render within safe area in portrait/landscape).

What is missing:

The required NOTE block at the top.

The root cause.

The actual implementation detail: the PR removes the prior per-subview inset handling and instead applies all system-bar/display-cutout insets as padding on the flyout CoordinatorLayout.

Any mention of potential side effects or behavior changes for footer/background/header layout.

Recommended Description

[!NOTE]
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root Cause

On Android, Shell flyout content was not consistently offset for SystemBars/DisplayCutout insets in landscape mode. That left flyout items exposed to the notch and status bar area.

Description of Change

This change simplifies ShellFlyoutTemplatedContentRenderer.WindowsListener so the flyout CoordinatorLayout consumes the window insets and applies the max of SystemBars and DisplayCutout insets as padding on the container itself.

That replaces the older per-subview logic that separately adjusted the app bar, flyout content, footer, and background image.

Key Technical Details

ShellFlyoutTemplatedContentRenderer.WindowsListener now computes left, top, right, and bottom insets from SystemBars and DisplayCutout.

The listener applies those values with v.SetPadding(leftInset, topInset, rightInset, bottomInset) on the flyout CoordinatorLayout.

The PR removes the older weak-reference plumbing for FlyoutView, FooterView, and the background image.

Issues Fixed

Fixes #32275

Code Review Findings

🔴 Important issue

Footer sizing does not match the new padded container model

File: src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs

Relevant code: WindowsListener.OnApplyWindowInsets() and UpdateFooterLayout()

Problem: The new implementation applies left/right padding to the parent CoordinatorLayout, but UpdateFooterLayout() still sizes the footer using _flyoutWidth, which is the full measured width of the flyout view. That means the footer can still be laid out against the unpadded width instead of the padded content width.

Why this matters: The main issue is about flyout content respecting the safe area. With a flyout footer present, the footer can still extend into or align against the unsafe inset region, which breaks the same layout model the PR is trying to enforce.

Recommendation: Base the footer width on the available content width (_flyoutWidth - _rootView.PaddingLeft - _rootView.PaddingRight) or switch the footer layout params to MatchParent so it naturally follows the parent padding.

🟡 Suggestions

Update the inline comment above the inset logic. It currently says the flyout overlaps the status bar so insetting it is not important, but the new code now explicitly applies top/left/right/bottom insets.

Add a targeted UI test for Android Shell flyout landscape safe-area behavior, ideally covering a flyout with a footer, since this change alters container-level layout rather than just content placement.

Overall Assessment

Metadata: Needs improvement before merge. The title is acceptable but can be more specific; the description should be expanded and should include the required NOTE block.

Code: The simplification is understandable and CI is green, but I do not consider this fully ready for merge until the footer-width interaction with parent padding is addressed or proven safe.

Based on Suggestion modified the description and footer layout params to MatchParent

sheiksyedm · 2026-03-19T07:48:19Z

/azp run maui-pr-uitests , maui-pr-devicetests

azure-pipelines · 2026-03-19T07:48:39Z

Azure Pipelines successfully started running 2 pipeline(s).

MauiBot · 2026-04-05T22:34:49Z

🚦 Gate - Test Before and After Fix

📊 Expand Full Gate — ef8a17b · test included

Gate Result: ❌ FAILED

Platform: ANDROID · Base: main · Merge base: 794a9fa6

Test	Without Fix (expect FAIL)	With Fix (expect PASS)
🖥️ Issue32275 `Issue32275`	✅ FAIL — 926s	❌ FAIL — 919s

🔴 Without fix — 🖥️ Issue32275: FAIL ✅ · 926s

(truncated to last 15,000 chars)

ssuesUITest.TryToResetTestState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 25
    at Microsoft.Maui.TestCases.Tests.UITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 576
 >>>>> 04/05/2026 22:18:14 The FixtureSetup threw an exception. Attempt 1/1.
 Exception details: System.TimeoutException: Shell Flyout SafeArea Rendering
    at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
    at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
    at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
    at Microsoft.Maui.TestCases.Tests._IssuesUITest.NavigateToIssue(String issue) in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 54
    at Microsoft.Maui.TestCases.Tests._IssuesUITest.TryToResetTestState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 25
    at Microsoft.Maui.TestCases.Tests.UITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 576

>>>>> 04/05/2026 22:18:15 VerifyCustomFlyoutContentRendering Start
>>>>> 04/05/2026 22:18:15 FixtureSetup for VerifyCustomFlyoutContentRendering
>>>>> 04/05/2026 22:18:30 The FixtureSetup threw an exception. Attempt 0/1.
Exception details: System.TimeoutException: Shell Flyout SafeArea Rendering
   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
   at Microsoft.Maui.TestCases.Tests._IssuesUITest.NavigateToIssue(String issue) in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 54
   at Microsoft.Maui.TestCases.Tests._IssuesUITest.TryToResetTestState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 25
   at Microsoft.Maui.TestCases.Tests.UITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 576
>>>>> 04/05/2026 22:18:32 FixtureSetup for VerifyCustomFlyoutContentRendering
>>>>> 04/05/2026 22:18:48 The FixtureSetup threw an exception. Attempt 1/1.
Exception details: System.TimeoutException: Shell Flyout SafeArea Rendering
   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
   at Microsoft.Maui.TestCases.Tests._IssuesUITest.NavigateToIssue(String issue) in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 54
   at Microsoft.Maui.TestCases.Tests._IssuesUITest.TryToResetTestState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 25
   at Microsoft.Maui.TestCases.Tests.UITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 576
>>>>> 04/05/2026 22:18:48 VerifyCustomFlyoutContentRendering Stop
>>>>> 04/05/2026 22:18:49 Log types: logcat, bugreport, server
>>>>> 04/05/2026 22:18:49 Log types: logcat, bugreport, server
  Failed VerifyCustomFlyoutContentRendering [34 s]
  Error Message:
   The app was expected to be running still, investigate as possible crash
TearDown : The app was expected to be running still, investigate as possible crash
  Stack Trace:
     at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 159
   at UITest.Appium.NUnit.UITestBase.TestTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 45
   at InvokeStub_UITestBase.TestTearDown(Object, Object, IntPtr*)

--TearDown
   at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 159
   at UITest.Appium.NUnit.UITestBase.TestTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 45
   at InvokeStub_UITestBase.TestTearDown(Object, Object, IntPtr*)

1)    at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 159
   at UITest.Appium.NUnit.UITestBase.TestTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 45
   at InvokeStub_UITestBase.TestTearDown(Object, Object, IntPtr*)


  Standard Error Messages:
 >>>>> 04/05/2026 22:18:30 The FixtureSetup threw an exception. Attempt 0/1.
 Exception details: System.TimeoutException: Shell Flyout SafeArea Rendering
    at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
    at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
    at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
    at Microsoft.Maui.TestCases.Tests._IssuesUITest.NavigateToIssue(String issue) in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 54
    at Microsoft.Maui.TestCases.Tests._IssuesUITest.TryToResetTestState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 25
    at Microsoft.Maui.TestCases.Tests.UITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 576
 >>>>> 04/05/2026 22:18:48 The FixtureSetup threw an exception. Attempt 1/1.
 Exception details: System.TimeoutException: Shell Flyout SafeArea Rendering
    at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
    at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
    at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
    at Microsoft.Maui.TestCases.Tests._IssuesUITest.NavigateToIssue(String issue) in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 54
    at Microsoft.Maui.TestCases.Tests._IssuesUITest.TryToResetTestState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 25
    at Microsoft.Maui.TestCases.Tests.UITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 576

>>>>> 04/05/2026 22:18:49 VerifyCustomFlyoutContentWithHeaderFooter Start
>>>>> 04/05/2026 22:18:49 FixtureSetup for VerifyCustomFlyoutContentWithHeaderFooter
>>>>> 04/05/2026 22:19:04 The FixtureSetup threw an exception. Attempt 0/1.
Exception details: System.TimeoutException: Shell Flyout SafeArea Rendering
   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
   at Microsoft.Maui.TestCases.Tests._IssuesUITest.NavigateToIssue(String issue) in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 54
   at Microsoft.Maui.TestCases.Tests._IssuesUITest.TryToResetTestState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 25
   at Microsoft.Maui.TestCases.Tests.UITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 576
>>>>> 04/05/2026 22:19:07 FixtureSetup for VerifyCustomFlyoutContentWithHeaderFooter
>>>>> 04/05/2026 22:19:23 The FixtureSetup threw an exception. Attempt 1/1.
Exception details: System.TimeoutException: Shell Flyout SafeArea Rendering
   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
   at Microsoft.Maui.TestCases.Tests._IssuesUITest.NavigateToIssue(String issue) in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 54
   at Microsoft.Maui.TestCases.Tests._IssuesUITest.TryToResetTestState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 25
   at Microsoft.Maui.TestCases.Tests.UITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 576
>>>>> 04/05/2026 22:19:23 VerifyCustomFlyoutContentWithHeaderFooter Stop
>>>>> 04/05/2026 22:19:23 Log types: logcat, bugreport, server
>>>>> 04/05/2026 22:19:23 Log types: logcat, bugreport, server
  Failed VerifyCustomFlyoutContentWithHeaderFooter [34 s]
  Error Message:
   The app was expected to be running still, investigate as possible crash
TearDown : The app was expected to be running still, investigate as possible crash
  Stack Trace:
     at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 159
   at UITest.Appium.NUnit.UITestBase.TestTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 45
   at InvokeStub_UITestBase.TestTearDown(Object, Object, IntPtr*)

--TearDown
   at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 159
   at UITest.Appium.NUnit.UITestBase.TestTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 45
   at InvokeStub_UITestBase.TestTearDown(Object, Object, IntPtr*)

1)    at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 159
   at UITest.Appium.NUnit.UITestBase.TestTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 45
   at InvokeStub_UITestBase.TestTearDown(Object, Object, IntPtr*)


  Standard Error Messages:
 >>>>> 04/05/2026 22:19:04 The FixtureSetup threw an exception. Attempt 0/1.
 Exception details: System.TimeoutException: Shell Flyout SafeArea Rendering
    at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
    at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
    at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
    at Microsoft.Maui.TestCases.Tests._IssuesUITest.NavigateToIssue(String issue) in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 54
    at Microsoft.Maui.TestCases.Tests._IssuesUITest.TryToResetTestState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 25
    at Microsoft.Maui.TestCases.Tests.UITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 576
 >>>>> 04/05/2026 22:19:23 The FixtureSetup threw an exception. Attempt 1/1.
 Exception details: System.TimeoutException: Shell Flyout SafeArea Rendering
    at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
    at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
    at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
    at Microsoft.Maui.TestCases.Tests._IssuesUITest.NavigateToIssue(String issue) in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 54
    at Microsoft.Maui.TestCases.Tests._IssuesUITest.TryToResetTestState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 25
    at Microsoft.Maui.TestCases.Tests.UITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 576

NUnit Adapter 4.5.0.0: Test execution complete

Total tests: 6
     Failed: 6
Test Run Failed.
 Total time: 4.0604 Minutes

🟢 With fix — 🖥️ Issue32275: FAIL ❌ · 919s

(truncated to last 15,000 chars)

so[build.updatebuildnumber]10.0.60-ci+azdo.13750565
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750565
  Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Xaml.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750565
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750565
  Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Foldable.dll
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Maps.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:10:28.45
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750565
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750565
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750565
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.CustomAttributes -> /home/vsts/work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750565
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  UITest.Core -> /home/vsts/work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  UITest.NUnit -> /home/vsts/work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  UITest.Appium -> /home/vsts/work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  VisualTestUtils -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  VisualTestUtils.MagickNet -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.Analyzers -> /home/vsts/work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.Android.Tests -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.11]   Discovering: Controls.TestCases.Android.Tests
[xUnit.net 00:00:00.39]   Discovered:  Controls.TestCases.Android.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
   NUnit3TestExecutor discovered 6 of 6 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 04/05/2026 22:32:38 VerifyDefaultFlyoutItemsRendering Start
>>>>> 04/05/2026 22:32:38 FixtureSetup for VerifyDefaultFlyoutItemsRendering
>>>>> 04/05/2026 22:32:50 VerifyDefaultFlyoutItemsRendering Stop
>>>>> 04/05/2026 22:32:50 Log types: logcat, bugreport, server
  Failed VerifyDefaultFlyoutItemsRendering [13 s]
  Error Message:
   VisualTestUtils.VisualTestFailedException : 
Baseline snapshot not yet created: /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/snapshots/android/VerifyDefaultFlyoutItemsRendering.png
Ensure new snapshot is correct:    /home/vsts/work/1/a/Controls.TestCases.Shared.Tests/snapshots-diff/android/VerifyDefaultFlyoutItemsRendering.png
  and if it is, push a change to add it to the 'snapshots' directory.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow

  Stack Trace:
     at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 84
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 477
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 309
   at Microsoft.Maui.TestCases.Tests.Issues.Issue32275.VerifyDefaultFlyoutItemsRendering() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32275.cs:line 25
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

>>>>> 04/05/2026 22:32:52 VerifyFlyoutWithHeaderFooter Start
>>>>> 04/05/2026 22:32:52 FixtureSetup for VerifyFlyoutWithHeaderFooter
>>>>> 04/05/2026 22:33:17 VerifyFlyoutWithHeaderFooter Stop
>>>>> 04/05/2026 22:33:17 Log types: logcat, bugreport, server
  Failed VerifyFlyoutWithHeaderFooter [27 s]
  Error Message:
   System.TimeoutException : Timed out waiting for element...
  Stack Trace:
     at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
   at Microsoft.Maui.TestCases.Tests.Issues.Issue32275.VerifyFlyoutWithHeaderFooter() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32275.cs:line 37
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

>>>>> 04/05/2026 22:33:19 VerifyCustomFlyoutContentTemplateRendering Start
>>>>> 04/05/2026 22:33:19 FixtureSetup for VerifyCustomFlyoutContentTemplateRendering
>>>>> 04/05/2026 22:33:30 VerifyCustomFlyoutContentTemplateRendering Stop
>>>>> 04/05/2026 22:33:30 Log types: logcat, bugreport, server
  Failed VerifyCustomFlyoutContentTemplateRendering [13 s]
  Error Message:
   VisualTestUtils.VisualTestFailedException : 
Baseline snapshot not yet created: /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/snapshots/android/VerifyCustomFlyoutContentTemplateRendering.png
Ensure new snapshot is correct:    /home/vsts/work/1/a/Controls.TestCases.Shared.Tests/snapshots-diff/android/VerifyCustomFlyoutContentTemplateRendering.png
  and if it is, push a change to add it to the 'snapshots' directory.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow

  Stack Trace:
     at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 84
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 477
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 309
   at Microsoft.Maui.TestCases.Tests.Issues.Issue32275.VerifyCustomFlyoutContentTemplateRendering() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32275.cs:line 51
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

>>>>> 04/05/2026 22:33:32 VerifyCustomFlyoutContentTemplateWithHeaderFooter Start
>>>>> 04/05/2026 22:33:32 FixtureSetup for VerifyCustomFlyoutContentTemplateWithHeaderFooter
>>>>> 04/05/2026 22:33:57 VerifyCustomFlyoutContentTemplateWithHeaderFooter Stop
>>>>> 04/05/2026 22:33:57 Log types: logcat, bugreport, server
  Failed VerifyCustomFlyoutContentTemplateWithHeaderFooter [26 s]
  Error Message:
   System.TimeoutException : Timed out waiting for element...
  Stack Trace:
     at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
   at Microsoft.Maui.TestCases.Tests.Issues.Issue32275.VerifyCustomFlyoutContentTemplateWithHeaderFooter() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32275.cs:line 65
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

>>>>> 04/05/2026 22:33:59 VerifyCustomFlyoutContentRendering Start
>>>>> 04/05/2026 22:33:59 FixtureSetup for VerifyCustomFlyoutContentRendering
>>>>> 04/05/2026 22:34:11 VerifyCustomFlyoutContentRendering Stop
>>>>> 04/05/2026 22:34:11 Log types: logcat, bugreport, server
  Failed VerifyCustomFlyoutContentRendering [13 s]
  Error Message:
   VisualTestUtils.VisualTestFailedException : 
Baseline snapshot not yet created: /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/snapshots/android/VerifyCustomFlyoutContentRendering.png
Ensure new snapshot is correct:    /home/vsts/work/1/a/Controls.TestCases.Shared.Tests/snapshots-diff/android/VerifyCustomFlyoutContentRendering.png
  and if it is, push a change to add it to the 'snapshots' directory.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow

  Stack Trace:
     at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 84
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 477
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 309
   at Microsoft.Maui.TestCases.Tests.Issues.Issue32275.VerifyCustomFlyoutContentRendering() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32275.cs:line 80
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

>>>>> 04/05/2026 22:34:13 VerifyCustomFlyoutContentWithHeaderFooter Start
>>>>> 04/05/2026 22:34:13 FixtureSetup for VerifyCustomFlyoutContentWithHeaderFooter
>>>>> 04/05/2026 22:34:39 VerifyCustomFlyoutContentWithHeaderFooter Stop
>>>>> 04/05/2026 22:34:39 Log types: logcat, bugreport, server
  Failed VerifyCustomFlyoutContentWithHeaderFooter [28 s]
  Error Message:
   System.TimeoutException : Timed out waiting for element...
  Stack Trace:
     at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
   at Microsoft.Maui.TestCases.Tests.Issues.Issue32275.VerifyCustomFlyoutContentWithHeaderFooter() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32275.cs:line 95
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

NUnit Adapter 4.5.0.0: Test execution complete

Test Run Failed.
Total tests: 6
     Failed: 6
 Total time: 2.3160 Minutes

⚠️ Issues found

❌ Issue32275 FAILED with fix (should pass)
- VerifyDefaultFlyoutItemsRendering [13 s]; VerifyFlyoutWithHeaderFooter [27 s]; VerifyCustomFlyoutContentTemplateRendering [13 s]; VerifyCustomFlyoutContentTemplateWithHeaderFooter [26 s]; VerifyCustomFlyoutContentRendering [13 s]; VerifyCustomFlyoutContentWithHeaderFooter [28 s]
- VisualTestUtils.VisualTestFailedException : Baseline snapshot not yet created: /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/snapshots/android/VerifyDefaultFlyoutIt...

📁 Fix files reverted (2 files)

eng/pipelines/ci-copilot.yml
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs

MauiBot · 2026-04-06T00:19:58Z

🤖 AI Summary

📊 Expand Full Review — ef8a17b · test included

🔍 Pre-Flight — Context & Validation

Issue: #32275 - [NET10] SafeAreaEdges cannot be set for Shell and the flyout menu collides with display notch and status bar in landscape mode
PR: #34510 - [Android] Shell Flyout: Apply safe-area insets to the flyout container
Platforms Affected: Android (landscape flyout safe-area regression in .NET 10 RC2)
Files Changed: 1 implementation (ShellFlyoutTemplatedContentRenderer.cs), 3 test files (Issue32275.cs in HostApp + SharedTests, ShellFlyoutContent.cs refactored to base class)

Key Findings

Regression: .NET 10 RC2 broke Shell flyout safe-area handling on Android in landscape mode — flyout items collide with the display notch and status bar. .NET 9 worked correctly.
Root Cause in Fix: The old WindowsListener tried to apply insets per-subview (appbar, footer, flyout content, background image) with conditional logic that didn't account for left/right insets — only top/bottom. PR simplifies this to a single v.SetPadding(left, top, right, bottom) on the CoordinatorLayout itself.
Gate Failure Root Cause: Issue32275.cs in HostApp declares PlatformAffected.iOS but the test (Issue32275.cs in SharedTests) is #if ANDROID only. On Android, the navigation to "Shell Flyout SafeArea Rendering" times out because the page is registered for iOS only. This is a test bug — not an implementation bug.
Inline Copilot Review Concerns:
1. Stale comment at line 97 saying "The flyout overlaps the status bar so we don't really care about insetting it" — contradicts the new behavior (already addressed in PR diff, the comment was updated).
2. Footer width logic: UpdateFooterLayout previously used _flyoutWidth (measured width including padding), but the PR changes this to LP.MatchParent — which naturally respects the parent's padding.
ShellFlyoutContent.cs Refactoring: The PR introduces ShellFlyoutContentBase as a shared base class so both ShellFlyoutContent and the new Issue32275 can reuse the same Init() logic without triggering AmbiguousMatchException. This is clean.

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #34510	Apply max(SystemBars, DisplayCutout) padding to CoordinatorLayout for all 4 edges; simplify `WindowsListener` by removing per-subview inset logic; change footer width to `MatchParent`	❌ Gate FAILED (test bug)	`ShellFlyoutTemplatedContentRenderer.cs`, `Issue32275.cs` (HostApp/SharedTests), `ShellFlyoutContent.cs`	Gate failure is due to `PlatformAffected.iOS` in HostApp test — not the implementation

🔧 Fix — Analysis & Comparison

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix (claude-opus-4.6)	Extend per-subview logic: add missing left/right inset extraction while keeping AppBarLayout/footer/content per-view structure	❌ FAIL	2 files	3/6: missing baseline snapshots; 3/6: header/footer element timeout after ShowFlyout
2	try-fix (claude-sonnet-4.6)	Same per-subview extension approach	❌ FAIL	2 files	Same failure pattern as Attempt 1
3	try-fix (gpt-5.3-codex)	Test-only: `PlatformAffected.iOS`→`Android` + element assertions + `Thread.Sleep(750)`	✅ PASS	2 files	6/6 pass; Thread.Sleep is anti-pattern
4	try-fix (gemini-3-pro-preview)	N/A	🚫 BLOCKED	—	Model unavailable
5	try-fix (claude-sonnet-4.6 cross-poll)	PR's CoordinatorLayout unified padding + `SetClipToPadding(false)` + PlatformAffected.Android + element assertions (no Thread.Sleep)	✅ PASS	3 files	6/6 pass; correct background image clip behavior
6	try-fix (claude-opus-4.6 cross-poll)	Attempt 5 + landscape orientation Test 7 (validates the actual bug scenario)	✅ PASS	3 files	7/7 pass including landscape test
PR	PR #34510	CoordinatorLayout unified padding; remove per-subview logic; footer `MatchParent`	❌ Gate FAILED	4 files	Gate failed due to `PlatformAffected.iOS` test bug; `SetClipToPadding(false)` and landscape test missing

Cross-Pollination

Model	Round	New Ideas?	Details
claude-opus-4.6	2	No	NO NEW IDEAS
gpt-5.3-codex	2	Yes	Remove Thread.Sleep; add landscape orientation test
claude-sonnet-4.6	2	Yes	`SetClipToPadding(false)`; Thread.Sleep redundant; landscape test missing
claude-opus-4.6	3	Yes	Landscape test is critical (bug is landscape-only)
gpt-5.3-codex	3	No	NO NEW IDEAS — Attempt 6 is comprehensive

Exhausted: Yes
Selected Fix: Attempt 6 — PR's CoordinatorLayout inset fix + SetClipToPadding(false) + PlatformAffected.Android + element assertions without Thread.Sleep + landscape orientation test. 7/7 tests pass.

📋 Report — Final Recommendation

⚠️ Final Recommendation: REQUEST CHANGES

Phase Status

Phase	Status	Notes
Pre-Flight	✅ COMPLETE	Issue #32275, Android landscape flyout safe-area regression, 4 files changed
Gate	❌ FAILED	Android · All 6 tests timeout (PlatformAffected.iOS prevents Android page navigation)
Try-Fix	✅ COMPLETE	6 attempts (1 blocked); 3 passing; best fix is Attempt 6 (7/7 tests)
Report	✅ COMPLETE

Summary

PR #34510 fixes a real Android regression: in landscape mode, the Shell flyout ignores left/right safe-area insets (display notch + status bar), causing content to collide with system UI. The implementation fix is technically sound — applying unified SetPadding(left, top, right, bottom) to the CoordinatorLayout is correct and simpler than the old per-subview approach.

However, the PR has two test bugs that caused the gate to fail:

Issue32275.cs in HostApp declares PlatformAffected.iOS instead of PlatformAffected.Android — the test page is never registered for Android navigation, causing every test to timeout
The 6 tests use VerifyScreenshot() which requires committed baseline PNGs that don't exist, causing 3 tests to fail even with the PlatformAffected bug fixed
A Thread.Sleep(750) anti-pattern was used for flyout timing (minor)
No landscape orientation test — the reported bug is landscape-specific, but all tests ran in portrait

Try-Fix found a winning improvement (Attempt 6, 7/7 pass) that:

Fixes PlatformAffected.iOS → PlatformAffected.Android
Replaces VerifyScreenshot() with element-based assertions (no baseline PNGs required)
Removes Thread.Sleep anti-pattern in favor of WaitForElement
Adds coordinator.SetClipToPadding(false) to prevent background image clipping behind safe-area padding
Adds a landscape orientation test (Test 7) that directly validates the reported bug scenario

Root Cause

The original bug: Android 15 enforced edge-to-edge display, but the old WindowsListener only handled top/bottom insets for specific child views (AppBarLayout, FlyoutView, footer). Left/right display-cutout insets in landscape mode were never applied, leaving flyout content exposed to the notch/status bar.

The gate failure: PlatformAffected.iOS in HostApp means Android can't navigate to Issue32275 page. Combined with VerifyScreenshot() requiring non-existent baseline PNGs, all 6 tests fail regardless of the implementation fix.

Fix Quality

Implementation (ShellFlyoutTemplatedContentRenderer.cs): ✅ Good

Correctly takes max of SystemBars and DisplayCutout for all 4 edges
Simplifies WindowsListener by removing WeakReference state tracking (no longer needed)
Changes footer width to MatchParent (correct — parent padding now bounds the content area)
Missing: coordinator.SetClipToPadding(false) — without it, the background image is clipped to the padded content area, leaving visible gaps at safe-area edges

Tests (Issue32275.cs): ❌ Needs fixes

PlatformAffected.iOS must be PlatformAffected.Android (critical — test can't run on Android otherwise)
VerifyScreenshot() without committed baseline PNGs will always fail on first run
No landscape orientation test validates the actual reported scenario
Thread.Sleep(750) is an anti-pattern (use WaitForElement instead)

Required Changes

src/Controls/tests/TestCases.HostApp/Issues/Issue32275.cs
- Change PlatformAffected.iOS → PlatformAffected.Android
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32275.cs
- Replace VerifyScreenshot() with element-based assertions (e.g., App.WaitForElement(FlyoutItem))
- Remove Thread.Sleep(750) — WaitForElement already polls
- Add landscape orientation test: App.SetOrientationLandscape() → open flyout → assert items visible → reset
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs
- Add coordinator.SetClipToPadding(false) after setting up the CoordinatorLayout (before SetupViewWithLocalListener) to prevent background image from being clipped at safe-area padding boundaries

Selected Fix: Attempt 6 (Agent Alternative)

The agent's Attempt 6 is the recommended fix combining all improvements. The PR's implementation direction is correct; the required changes are refinements to fix the test bugs and add the missing SetClipToPadding(false).

kubaflo

Could you please review the ai's summary?

android shell flyout fix added

78a9b4f

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Mar 17, 2026

devanathan-vaithiyanathan marked this pull request as ready for review March 17, 2026 08:34

Copilot AI review requested due to automatic review settings March 17, 2026 08:34

Copilot started reviewing on behalf of devanathan-vaithiyanathan March 17, 2026 08:35 View session

Copilot AI reviewed Mar 17, 2026

View reviewed changes

...ontrols/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs Outdated Show resolved Hide resolved

...ontrols/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs Show resolved Hide resolved

sheiksyedm added community ✨ Community Contribution area-safearea Issues/PRs that have to do with the SafeArea functionality platform/android labels Mar 17, 2026

github-actions bot mentioned this pull request Mar 18, 2026

[repo-status] 📊 Daily Repo Status - March 18, 2026 #34523

Closed

AI review comments addressed

6e419cb

devanathan-vaithiyanathan changed the title ~~[Android] Fix Shell Flyout SafeArea Rendering~~ [Android] Shell Flyout: Apply safe-area insets to the flyout container Mar 18, 2026

co pilot changes added

bf74de2

sheiksyedm added the s/agent-suggestions-implemented Maintainer applies when PR author adopts agent's recommendation label Mar 19, 2026

This was referenced Mar 19, 2026

CI UItests failure System.TimeoutException : Timed out waiting for element... #33220

Open

System.TimeoutException #33245

Open

kubaflo added the s/agent-fix-implemented PR author implemented the agent suggested fix label Mar 19, 2026

dotnet deleted a comment from MauiBot Mar 19, 2026

test included

ef8a17b

dotnet deleted a comment from MauiBot Mar 28, 2026

MauiBot mentioned this pull request Mar 31, 2026

[iOS] Fix Shell Flyout SafeArea Rendering #33335

Open

kubaflo requested changes Apr 6, 2026

View reviewed changes

Conversation

devanathan-vaithiyanathan commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Details

Description of Change

Issues Fixed

Uh oh!

github-actions bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

devanathan-vaithiyanathan commented Mar 18, 2026

🤖 AI Summary

Key Findings

Fix Candidates

Source Approach Test Result Files Changed Notes

Gate Result: ⚠️ SKIPPED

Fix Candidates

Source Approach Test Result Files Changed Notes

Cross-Pollination

⚠️ Final Recommendation: REQUEST CHANGES

Phase Status

Summary

Root Cause

Fix Quality

PR #34510 Finalization Review

Title Review

Description Review

Recommended Description

Root Cause

Description of Change

Key Technical Details

Issues Fixed

Code Review Findings

🔴 Important issue

🟡 Suggestions

Overall Assessment

Uh oh!

devanathan-vaithiyanathan commented Mar 19, 2026

🤖 AI Summary

Key Findings

Fix Candidates

Source Approach Test Result Files Changed Notes

Key Findings

Fix Candidates

Source Approach Test Result Files Changed Notes

Gate Result: ⚠️ SKIPPED

Gate Result: ⚠️ SKIPPED

Gate Result: ⚠️ SKIPPED

Fix Candidates

Source Approach Test Result Files Changed Notes

Cross-Pollination

⚠️ Final Recommendation: REQUEST CHANGES

Phase Status

Summary

Root Cause

Fix Quality

⚠️ Final Recommendation: REQUEST CHANGES

Phase Status

Summary

Root Cause

Fix Quality

Current-Diff Blocking Issue

PR #34510 Finalization Review

Title Review

Description Review

Recommended Description

Root Cause

Description of Change

Key Technical Details

Issues Fixed

Code Review Findings

🔴 Important issue

🟡 Suggestions

Overall Assessment

devanathan-vaithiyanathan commented Mar 17, 2026 •

edited

Loading

github-actions bot commented Mar 17, 2026 •

edited

Loading