[Testing] Fixed Test case failure in PR 33779 - [02/02/2026] Candidate#33838
Merged
PureWeen merged 3 commits intodotnet:inflight/candidatefrom Feb 8, 2026
Merged
Conversation
Contributor
|
Hey there @@HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This was referenced Feb 2, 2026
Open
daa5150 to
de62386
Compare
Contributor
|
/azp run maui-pr-uitests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Feb 3, 2026
92c3ffa to
1030886
Compare
Contributor
|
/azp run maui-pr-uitests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1030886 to
393a3e6
Compare
Contributor
|
/azp run maui-pr-uitests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run maui-pr-devicetests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PureWeen
requested changes
Feb 5, 2026
Member
There was a problem hiding this comment.
are these changes specific to the candidate branch? or is this an effort to make these tests generally less flakey? If these changes aren't specific to changes in the candidate can we please just move them to a different?
Contributor
There was a problem hiding this comment.
@PureWeen This is a new test added to the candidate branch through PR #17825 and is specific to this branch. The test does not pass on Windows because it attempts to reorder Grid elements. To address this, we modified the test to reorder the Label elements that are children of the Grid, which aligns with the expected test scenario.
PureWeen
approved these changes
Feb 8, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Feb 8, 2026
#33838) This pull request updates several UI test cases to improve reliability and platform compatibility. The main changes include updating element identifiers to match the UI, adjusting platform-specific test logic, and conditionally excluding a test that fails on Windows. **Test identifier updates and logic fixes:** * Updated the test automation IDs in Issue17823.cs, replacing grid-based elements with label-based elements (ReorderItemLabel0 / ReorderItemLabel3) to ensure Windows compatibility. The drag-and-drop test was also simplified by removing assert validations, as the DragAndDrop method does not always drop items reliably, which could cause intermittent assertion failures. * Due to the fix introduced in PR #32891, the FlyoutHeaderContentAndFooterAllMeasureCorrectly and FlyoutContentSetsCorrectBottomPaddingWhenMinHeightIsSetForFlyoutHeader test began failing; the test has now been updated and is working as expected. * Modified back button tap logic in `Issue33688.cs` to use platform-specific methods for Android/Windows and iOS/MacCatalyst, improving test reliability across platforms. * Wrapped the test in `Issue20772.cs` with a conditional to exclude it from running on Windows, referencing a known issue. [[1]](diffhunk://#diff-30ca65fc7efd27af71e093ab79eb601572bf186e770462550615e731de66d316R1) [[2]](diffhunk://#diff-30ca65fc7efd27af71e093ab79eb601572bf186e770462550615e731de66d316R53) Candidate PR: #33779
PureWeen
pushed a commit
that referenced
this pull request
Feb 9, 2026
#33838) This pull request updates several UI test cases to improve reliability and platform compatibility. The main changes include updating element identifiers to match the UI, adjusting platform-specific test logic, and conditionally excluding a test that fails on Windows. **Test identifier updates and logic fixes:** * Updated the test automation IDs in Issue17823.cs, replacing grid-based elements with label-based elements (ReorderItemLabel0 / ReorderItemLabel3) to ensure Windows compatibility. The drag-and-drop test was also simplified by removing assert validations, as the DragAndDrop method does not always drop items reliably, which could cause intermittent assertion failures. * Due to the fix introduced in PR #32891, the FlyoutHeaderContentAndFooterAllMeasureCorrectly and FlyoutContentSetsCorrectBottomPaddingWhenMinHeightIsSetForFlyoutHeader test began failing; the test has now been updated and is working as expected. * Modified back button tap logic in `Issue33688.cs` to use platform-specific methods for Android/Windows and iOS/MacCatalyst, improving test reliability across platforms. * Wrapped the test in `Issue20772.cs` with a conditional to exclude it from running on Windows, referencing a known issue. [[1]](diffhunk://#diff-30ca65fc7efd27af71e093ab79eb601572bf186e770462550615e731de66d316R1) [[2]](diffhunk://#diff-30ca65fc7efd27af71e093ab79eb601572bf186e770462550615e731de66d316R53) Candidate PR: #33779
github-actions bot
pushed a commit
that referenced
this pull request
Feb 9, 2026
#33838) This pull request updates several UI test cases to improve reliability and platform compatibility. The main changes include updating element identifiers to match the UI, adjusting platform-specific test logic, and conditionally excluding a test that fails on Windows. **Test identifier updates and logic fixes:** * Updated the test automation IDs in Issue17823.cs, replacing grid-based elements with label-based elements (ReorderItemLabel0 / ReorderItemLabel3) to ensure Windows compatibility. The drag-and-drop test was also simplified by removing assert validations, as the DragAndDrop method does not always drop items reliably, which could cause intermittent assertion failures. * Due to the fix introduced in PR #32891, the FlyoutHeaderContentAndFooterAllMeasureCorrectly and FlyoutContentSetsCorrectBottomPaddingWhenMinHeightIsSetForFlyoutHeader test began failing; the test has now been updated and is working as expected. * Modified back button tap logic in `Issue33688.cs` to use platform-specific methods for Android/Windows and iOS/MacCatalyst, improving test reliability across platforms. * Wrapped the test in `Issue20772.cs` with a conditional to exclude it from running on Windows, referencing a known issue. [[1]](diffhunk://#diff-30ca65fc7efd27af71e093ab79eb601572bf186e770462550615e731de66d316R1) [[2]](diffhunk://#diff-30ca65fc7efd27af71e093ab79eb601572bf186e770462550615e731de66d316R53) Candidate PR: #33779
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several UI test cases to improve reliability and platform compatibility. The main changes include updating element identifiers to match the UI, adjusting platform-specific test logic, and conditionally excluding a test that fails on Windows.
Test identifier updates and logic fixes:
Updated the test automation IDs in Issue17823.cs, replacing grid-based elements with label-based elements (ReorderItemLabel0 / ReorderItemLabel3) to ensure Windows compatibility. The drag-and-drop test was also simplified by removing assert validations, as the DragAndDrop method does not always drop items reliably, which could cause intermittent assertion failures.
Due to the fix introduced in PR [iOS] Shell: Account for SafeArea when positioning flyout footer #32891, the FlyoutHeaderContentAndFooterAllMeasureCorrectly and FlyoutContentSetsCorrectBottomPaddingWhenMinHeightIsSetForFlyoutHeader test began failing; the test has now been updated and is working as expected.
Modified back button tap logic in
Issue33688.csto use platform-specific methods for Android/Windows and iOS/MacCatalyst, improving test reliability across platforms.Wrapped the test in
Issue20772.cswith a conditional to exclude it from running on Windows, referencing a known issue. [1] [2]Candidate PR: #33779