Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates localized LCX resource files for MauiGResources.resx, adding new resource entries (binding compilation + NameScope-related strings) and adjusting some existing XAML parsing-related translations across multiple languages.
Changes:
- Added localized entries for
BindingCompilation*, binding indexer errors, and NameScope errors across several cultures. - Updated a few existing translations (notably XAML parsing error/failed messages) for consistency/wording.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| loc/zh-Hant/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds new binding/NameScope strings; minor tweak to XAML parsing error translation. |
| loc/zh-Hans/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds new binding/NameScope strings; minor tweak to XAML parsing error translation. |
| loc/tr/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds new binding/NameScope strings; updates XAML parsing failed translation. |
| loc/ru/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds new binding/NameScope strings; refines XAML parsing translations. |
| loc/pt-BR/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds new binding/NameScope strings; updates XAML parsing error translation. |
| loc/pl/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds new binding/NameScope strings; refines XAML parsing translations. |
| loc/ko/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds new binding/NameScope strings; updates XAML parsing error translation. |
| loc/ja/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds new binding/NameScope strings; minor tweak to XAML parsing error translation. |
| loc/it/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds new binding/NameScope strings; refines XAML parsing failed wording. |
| loc/fr/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds new binding/NameScope strings; refines XAML parsing message wording. |
| loc/es/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds new binding/NameScope strings; refines XAML parsing message wording. |
| loc/de/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds new binding/NameScope strings; adjusts XAML parsing failed punctuation. |
| loc/cs/src/Controls/src/SourceGen/MauiGResources.resx.lcl | Adds new binding/NameScope strings; refines XAML parsing translations. |
| <Str Cat="Text"> | ||
| <Val><![CDATA[Binding: Property "{0}" not found on "{1}". The binding will use slower reflection-based binding at runtime. If this property is generated by another source generator, consider reporting this at https://github.com/dotnet/maui/issues to help us improve source generator interoperability.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Associação: propriedade "{0}" não encontrada em "{1}". A associação usará uma associação mais lenta baseada em reflexão em runtime. Se essa propriedade for gerada por outro gerador de origem, considere relatar isso em https://github.com/dotnet/maui/issues nos ajude a melhorar a interoperabilidade do gerador de origem.]]></Val> |
There was a problem hiding this comment.
The pt-BR translation sentence is ungrammatical: "considere relatar isso em ... nos ajude a melhorar..." is missing a connector (e.g., "para") between the URL clause and "nos ajude". Please adjust so the sentence reads correctly while preserving placeholders and the URL.
Suggested change
| <Val><![CDATA[Associação: propriedade "{0}" não encontrada em "{1}". A associação usará uma associação mais lenta baseada em reflexão em runtime. Se essa propriedade for gerada por outro gerador de origem, considere relatar isso em https://github.com/dotnet/maui/issues nos ajude a melhorar a interoperabilidade do gerador de origem.]]></Val> | |
| <Val><![CDATA[Associação: propriedade "{0}" não encontrada em "{1}". A associação usará uma associação mais lenta baseada em reflexão em runtime. Se essa propriedade for gerada por outro gerador de origem, considere relatar isso em https://github.com/dotnet/maui/issues para nos ajudar a melhorar a interoperabilidade do gerador de origem.]]></Val> |
| <Str Cat="Text"> | ||
| <Val><![CDATA[Binding: Unsupported indexer index type: "{0}".]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[바인딩: 지원되지 않는 인덱서 인덱스 형식: "{0}"]]></Val> |
There was a problem hiding this comment.
The localized string is missing the closing quote (and trailing punctuation) around the {0} placeholder, which will render as an unmatched quote at runtime. Please mirror the source format so the placeholder is enclosed properly (e.g., close the quote after {0} and keep the ending punctuation).
Suggested change
| <Val><![CDATA[바인딩: 지원되지 않는 인덱서 인덱스 형식: "{0}"]]></Val> | |
| <Val><![CDATA[바인딩: 지원되지 않는 인덱서 인덱스 형식: "{0}".]]></Val> |
| <Str Cat="Text"> | ||
| <Val><![CDATA[Binding might be compiled incorrectly since the x:DataType annotation comes from an outer scope. Make sure you annotate all DataTemplate XAML elements with the correct x:DataType. See https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[x:DataType ek açıklaması bir dış kapsamdan geldiğinden bağlama yanlış derlenmiş olabilir. Tüm DataTemplate XAML öğelerine doğru x:DataType ile not eklediğinizden emin olun. Bkz. https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information.]]></Val> |
There was a problem hiding this comment.
This Turkish translation ends with the English phrase "for more information." after the URL, which looks like an unlocalized leftover. Please translate that part as well (or drop it) so the message is consistently Turkish.
Suggested change
| <Val><![CDATA[x:DataType ek açıklaması bir dış kapsamdan geldiğinden bağlama yanlış derlenmiş olabilir. Tüm DataTemplate XAML öğelerine doğru x:DataType ile not eklediğinizden emin olun. Bkz. https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings for more information.]]></Val> | |
| <Val><![CDATA[x:DataType ek açıklaması bir dış kapsamdan geldiğinden bağlama yanlış derlenmiş olabilir. Tüm DataTemplate XAML öğelerine doğru x:DataType ile not eklediğinizden emin olun. Daha fazla bilgi için bkz. https://learn.microsoft.com/dotnet/maui/fundamentals/data-binding/compiled-bindings.]]></Val> |
rmarinho
approved these changes
Jan 31, 2026
kubaflo
pushed a commit
to kubaflo/maui
that referenced
this pull request
Feb 2, 2026
…20260130203640718 to main (dotnet#33803) LEGO: Pull request from lego/hb_7241b85a-f216-4d55-a9fa-d8030c736df5_20260130203640718 to main with localized lcls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from lego/hb_7241b85a-f216-4d55-a9fa-d8030c736df5_20260130203640718 to main with localized lcls