Skip to content

[testing] Add xaml and resizetizer tests to run on helix#33567

Merged
rmarinho merged 2 commits intomainfrom
more-helix-tests
Jan 30, 2026
Merged

[testing] Add xaml and resizetizer tests to run on helix#33567
rmarinho merged 2 commits intomainfrom
more-helix-tests

Conversation

@rmarinho
Copy link
Member

@rmarinho rmarinho commented Jan 16, 2026

Description of Change

Work to run more of our unit tests on Helix.

This pull request updates the unit test project configuration and related pipeline steps. The main changes are to ensure that the Controls.Xaml.UnitTests and Resizetizer.UnitTests projects are included in the build/test process, but their execution in the CI pipeline is currently commented out.

Test project configuration:

  • Added Controls.Xaml.UnitTests.csproj and re-enabled Resizetizer.UnitTests.csproj in the list of XUnit projects in eng/helix.proj, ensuring these test projects are recognized and available for test runs.

Pipeline changes:

  • Commented out the steps in eng/pipelines/arcade/stage-unit-tests.yml that run and publish results for both
    Controls.Xaml.UnitTests and Resizetizer.UnitTests, effectively disabling their execution in the CI pipeline for now.

Works fine from VS
Screenshot 2026-01-29 at 18 30 05

Copilot AI review requested due to automatic review settings January 16, 2026 14:45
@rmarinho rmarinho added area-testing Unit tests, device tests testing-infrastructure Issue relating to testing infrastructure labels Jan 16, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds two unit test projects (Controls.Xaml.UnitTests and Resizetizer.UnitTests) to the Helix test infrastructure while temporarily disabling their execution in the CI pipeline. The changes prepare these tests to run on Helix by including them in the test project configuration, but comment out their actual execution steps pending further validation.

Changes:

  • Added Controls.Xaml.UnitTests and Resizetizer.UnitTests to the list of XUnit projects in eng/helix.proj
  • Commented out CI pipeline steps that execute and publish results for both test projects in eng/pipelines/arcade/stage-unit-tests.yml

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/helix.proj Added two test projects to XUnit project list for Helix test execution
eng/pipelines/arcade/stage-unit-tests.yml Commented out execution and result publishing steps for the two test projects

@rmarinho rmarinho force-pushed the more-helix-tests branch 2 times, most recently from 0951f65 to 7ef7f2b Compare January 27, 2026 11:20
Copilot AI added a commit that referenced this pull request Jan 28, 2026
- Add run-helix-tests skill for submitting unit tests to Helix
  - Submit-HelixTests.ps1: Submit tests to Helix queues
  - Get-HelixJobStatus.ps1: Monitor job completion
  - Get-HelixWorkItemLog.ps1: Fetch work item console logs
- Update eng/helix.proj to include Xaml and Resizetizer unit tests
- Add HelixCorrelationPayload for SourceGen DLL (required by XAML tests)
- Update eng/pipelines/arcade/stage-unit-tests.yml to run XAML/Resizetizer tests on Helix instead of inline
- Clean up duplicate documentation in helix-device-tests.instructions.md

Extracted from PR #33567 - infrastructure changes only, no test-specific fixes included.

Co-authored-by: rmarinho <1235097+rmarinho@users.noreply.github.com>
@rmarinho
Copy link
Member Author

/rebase

This PR enables running XAML and Resizetizer unit tests on Helix infrastructure.

Changes:
- Add XAML and Resizetizer test projects to Helix configuration (eng/helix.proj)
- Add Helix correlation payloads for SourceGen DLL and MSBuild test files
- Create Helix-specific Directory.Build files for MSBuild tests
- Update test infrastructure to find files in Helix payload paths
- Fix CA1307/CA1865 analyzer conflicts in string.LastIndexOf calls
- Add run-helix-tests skill for local Helix test submission

Test results on Helix:
- XAML Unit Tests: 1814 tests passing
- Resizetizer Unit Tests: 590 tests passing
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.

@rmarinho rmarinho merged commit c2cc041 into main Jan 30, 2026
23 of 28 checks passed
@rmarinho rmarinho deleted the more-helix-tests branch January 30, 2026 18:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testing Unit tests, device tests testing-infrastructure Issue relating to testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants