[XSG] Refactor MemberAccess to remove double negatives by Copilot · Pull Request #33449 · dotnet/maui

Copilot · 2026-01-09T16:01:49Z

Original prompt

This section details on the original issue you should resolve

<issue_title>[XSG][Compiled bindings] Refactor code to remove double negatives in MemberAccess</issue_title>
<issue_description>I always get confused because of MemberAccess properties bool IsGetterInaccessible and IsSetterInaccessible. Let's change them to IsGetterAccessible and IsSetterAccessible.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes [XSG][Compiled bindings] Refactor code to remove double negatives in MemberAccess #33448

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

…ssible to IsGetterAccessible/IsSetterAccessible Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

Copilot

Pull request overview

This PR refactors the MemberAccess record properties from double negatives (IsGetterInaccessible, IsSetterInaccessible) to positive form (IsGetterAccessible, IsSetterAccessible) to improve code readability throughout the BindingSourceGen code generator.

Key Changes:

Property defaults changed from false to true (members are accessible by default)
Logic inversions applied where properties are checked
Pattern matching expressions updated to check for false instead of true

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
PathPart.cs	Renamed properties to positive form, updated defaults to `true`, inverted logic in `HasInaccessibleAccessor` computation
PathParser.cs	Simplified assignment by removing double negation when setting property values
Setter.cs	Updated pattern matching from `IsSetterInaccessible: true` to `IsSetterAccessible: false`
AccessExpressionBuilder.cs	Updated pattern matching from `IsGetterInaccessible: true` to `IsGetterAccessible: false`
BindingCodeWriter.cs	Updated condition checks to negate positive properties (`!member.IsGetterAccessible`)
SetterBuilderTests.cs	Updated test data to use new property names with appropriate boolean values
BindingRepresentationGenTests.cs	Updated test expectations to use new property names
AccessExpressionBuilderTests.cs	Updated test data to use new property names

simonrozsival · 2026-01-12T09:47:42Z

/azp run maui-pr-devicetests

azure-pipelines · 2026-01-12T09:47:57Z

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival · 2026-01-15T13:33:10Z

/azp run maui-pr-uitests

azure-pipelines · 2026-01-15T13:33:22Z

Azure Pipelines successfully started running 1 pipeline(s).

simonrozsival · 2026-01-15T15:09:48Z

@copilot I'm seeing this failure in maui-pr-uitests:

src/Controls/src/BindingSourceGen/PathParser.cs(102,5): Error CS1739: The best overload for 'MemberAccess' does not have a parameter named 'IsGetterInaccessible'

…ty names Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

Copilot · 2026-01-15T15:33:21Z

@copilot I'm seeing this failure in maui-pr-uitests:

src/Controls/src/BindingSourceGen/PathParser.cs(102,5): Error CS1739: The best overload for 'MemberAccess' does not have a parameter named 'I...

Fixed in 93e4dab. The base branch had added RelayCommand support code that was using the old property names (IsGetterInaccessible, IsSetterInaccessible). I've merged that code with the refactored property names (IsGetterAccessible, IsSetterAccessible).

simonrozsival · 2026-01-15T16:32:59Z

/azp run maui-pr,maui-pr-devicetests,maui-pr-uitests

azure-pipelines · 2026-01-15T16:33:05Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

simonrozsival · 2026-01-15T16:51:23Z

/azp run maui-pr,maui-pr-devicetests,maui-pr-uitests

azure-pipelines · 2026-01-15T16:51:42Z

Azure Pipelines successfully started running 3 pipeline(s).

- [x] Refactor `IsGetterInaccessible` to `IsGetterAccessible` in `MemberAccess` record (PathPart.cs) - [x] Refactor `IsSetterInaccessible` to `IsSetterAccessible` in `MemberAccess` record (PathPart.cs) - [x] Update the computed property `HasInaccessibleAccessor` to use the new properties - [x] Update `PathParser.cs` to use the new property names (simplified assignment) - [x] Update `Setter.cs` to check for `IsSetterAccessible: false` instead of `IsSetterInaccessible: true` - [x] Update `AccessExpressionBuilder.cs` to check for `IsGetterAccessible: false` instead of `IsGetterInaccessible: true` - [x] Update `BindingCodeWriter.cs` to use the new property names - [x] Update all test files to use the new property names: - [x] `SetterBuilderTests.cs` - [x] `BindingRepresentationGenTests.cs` - [x] `AccessExpressionBuilderTests.cs` - [x] Build and verify tests pass (all 119 tests pass) - [x] Run code review (passed with no comments) - [x] Run CodeQL security scan (no issues found) - [x] Fix CI failure by adding missing RelayCommand support code from base branch (updated to use new property names)  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>[XSG][Compiled bindings] Refactor code to remove double negatives in MemberAccess</issue_title> > <issue_description>I always get confused because of `MemberAccess` properties `bool IsGetterInaccessible` and `IsSetterInaccessible`. Let's change them to `IsGetterAccessible` and `IsSetterAccessible`.</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details>  - Fixes #33448  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/dotnet/maui/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com> Co-authored-by: Šimon Rozsíval <simon@rozsival.com>

Initial plan

132095d

Copilot AI assigned Copilot and simonrozsival Jan 9, 2026

Copilot started work on behalf of simonrozsival January 9, 2026 16:02 View session

Copilot AI and others added 3 commits January 9, 2026 16:10

Initial plan for refactoring MemberAccess properties

418bdb7

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

Refactor MemberAccess properties: IsGetterInaccessible/IsSetterInacce…

ea69a07

…ssible to IsGetterAccessible/IsSetterAccessible Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

Revert unrelated changes to HybridWebView files

27e5c5e

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Refactor MemberAccess properties to use positive terms~~ [XSG] Refactor MemberAccess to remove double negatives Jan 9, 2026

Copilot finished work on behalf of simonrozsival January 9, 2026 16:17

Copilot AI requested a review from simonrozsival January 9, 2026 16:17

simonrozsival marked this pull request as ready for review January 9, 2026 17:15

Copilot AI review requested due to automatic review settings January 9, 2026 17:15

Copilot started reviewing on behalf of simonrozsival January 9, 2026 17:16 View session

Copilot AI reviewed Jan 9, 2026

View reviewed changes

Copilot started work on behalf of simonrozsival January 15, 2026 15:12 View session

Copilot AI and others added 2 commits January 15, 2026 15:32

Fix CI failure: add missing RelayCommand support code with new proper…

dbf7847

…ty names Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

Remove accidentally committed HybridWebView.js.map file

93e4dab

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

Copilot finished work on behalf of simonrozsival January 15, 2026 15:36

Merge branch 'net11.0' into copilot/refactor-member-access-properties

d08086d

build-analysis bot mentioned this pull request Jan 15, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

StephaneDelcroix approved these changes Jan 19, 2026

View reviewed changes

jfversluis approved these changes Jan 19, 2026

View reviewed changes

PureWeen merged commit 3733513 into net11.0 Jan 19, 2026
168 checks passed

PureWeen deleted the copilot/refactor-member-access-properties branch January 19, 2026 17:55

github-actions bot locked and limited conversation to collaborators Feb 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[XSG] Refactor MemberAccess to remove double negatives#33449

[XSG] Refactor MemberAccess to remove double negatives#33449
PureWeen merged 7 commits intonet11.0from
copilot/refactor-member-access-properties

Copilot AI commented Jan 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

simonrozsival commented Jan 12, 2026

Uh oh!

azure-pipelines bot commented Jan 12, 2026

Uh oh!

simonrozsival commented Jan 15, 2026

Uh oh!

azure-pipelines bot commented Jan 15, 2026

Uh oh!

simonrozsival commented Jan 15, 2026

Uh oh!

Copilot AI commented Jan 15, 2026

Uh oh!

simonrozsival commented Jan 15, 2026

Uh oh!

azure-pipelines bot commented Jan 15, 2026

Uh oh!

simonrozsival commented Jan 15, 2026

Uh oh!

azure-pipelines bot commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Copilot AI commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @copilot in this section)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

simonrozsival commented Jan 12, 2026

Uh oh!

azure-pipelines bot commented Jan 12, 2026

Uh oh!

simonrozsival commented Jan 15, 2026

Uh oh!

azure-pipelines bot commented Jan 15, 2026

Uh oh!

simonrozsival commented Jan 15, 2026

Uh oh!

Copilot AI commented Jan 15, 2026

Uh oh!

simonrozsival commented Jan 15, 2026

Uh oh!

azure-pipelines bot commented Jan 15, 2026

Uh oh!

simonrozsival commented Jan 15, 2026

Uh oh!

azure-pipelines bot commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Copilot AI commented Jan 9, 2026 •

edited

Loading