[Testing] Fixed Test case failure in PR 33363 - [01/05/2026] Candidate - 1#33384
Merged
PureWeen merged 1 commit intodotnet:inflight/candidatefrom Jan 7, 2026
Merged
Conversation
Contributor
|
Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
StephaneDelcroix
approved these changes
Jan 7, 2026
Contributor
StephaneDelcroix
left a comment
There was a problem hiding this comment.
✅ Approved
Validation Summary:
- Tested on Android (Pixel 9 API 35 emulator)
- All SearchBar scenarios validated:
- Default SearchBar (no SearchIconColor): Icon visible with platform default color ✅
- SearchBar with Red SearchIconColor: Red icon visible ✅
- SearchBar with Blue SearchIconColor: Blue icon visible ✅
- No crashes during rendering
Code Review:
- Correct approach using
TryGetDefaultStateColorwithTextColorPrimary- consistent withUpdateCancelButtonColorpattern - Minimal, surgical change that only fixes the specific fallback behavior
- Preserves the crash fix from PR #33071 by continuing to use
SafeSetTint
The fix correctly addresses the regression where search icons became invisible when no custom SearchIconColor was set.
PureWeen
pushed a commit
that referenced
this pull request
Jan 9, 2026
…e - 1 (#33384) This pull request refines the logic for setting the search icon color in the Android `SearchView`. This PR #33071 set the search icon color to transparent if no color was specified, which caused the search icon to become invisible and led to search bar-related test failures. Now, if no custom search icon color is provided, the icon will use the platform's default primary text color instead of becoming transparent. **Android SearchView icon color handling:** * Updated `UpdateSearchIconColor` in `SearchViewExtensions.cs` to apply the default primary text color (`TextColorPrimary`) to the search icon when no custom color is set, instead of making it transparent. <table> <tr> <td> Before fix </td> <td> After fix </td> </tr> <tr> <td> https://github.com/user-attachments/assets/22c5dc6f-2e8a-417d-89da-afaa422c9e15 </td> <td> https://github.com/user-attachments/assets/b4289eb2-7266-48a2-be12-eb0eabecb40f </td> </tr> </table>
PureWeen
pushed a commit
that referenced
this pull request
Jan 9, 2026
…e - 1 (#33384) This pull request refines the logic for setting the search icon color in the Android `SearchView`. This PR #33071 set the search icon color to transparent if no color was specified, which caused the search icon to become invisible and led to search bar-related test failures. Now, if no custom search icon color is provided, the icon will use the platform's default primary text color instead of becoming transparent. **Android SearchView icon color handling:** * Updated `UpdateSearchIconColor` in `SearchViewExtensions.cs` to apply the default primary text color (`TextColorPrimary`) to the search icon when no custom color is set, instead of making it transparent. <table> <tr> <td> Before fix </td> <td> After fix </td> </tr> <tr> <td> https://github.com/user-attachments/assets/22c5dc6f-2e8a-417d-89da-afaa422c9e15 </td> <td> https://github.com/user-attachments/assets/b4289eb2-7266-48a2-be12-eb0eabecb40f </td> </tr> </table>
PureWeen
pushed a commit
that referenced
this pull request
Jan 13, 2026
…e - 1 (#33384) This pull request refines the logic for setting the search icon color in the Android `SearchView`. This PR #33071 set the search icon color to transparent if no color was specified, which caused the search icon to become invisible and led to search bar-related test failures. Now, if no custom search icon color is provided, the icon will use the platform's default primary text color instead of becoming transparent. **Android SearchView icon color handling:** * Updated `UpdateSearchIconColor` in `SearchViewExtensions.cs` to apply the default primary text color (`TextColorPrimary`) to the search icon when no custom color is set, instead of making it transparent. <table> <tr> <td> Before fix </td> <td> After fix </td> </tr> <tr> <td> https://github.com/user-attachments/assets/22c5dc6f-2e8a-417d-89da-afaa422c9e15 </td> <td> https://github.com/user-attachments/assets/b4289eb2-7266-48a2-be12-eb0eabecb40f </td> </tr> </table>
PureWeen
pushed a commit
that referenced
this pull request
Jan 13, 2026
…e - 1 (#33384) This pull request refines the logic for setting the search icon color in the Android `SearchView`. This PR #33071 set the search icon color to transparent if no color was specified, which caused the search icon to become invisible and led to search bar-related test failures. Now, if no custom search icon color is provided, the icon will use the platform's default primary text color instead of becoming transparent. **Android SearchView icon color handling:** * Updated `UpdateSearchIconColor` in `SearchViewExtensions.cs` to apply the default primary text color (`TextColorPrimary`) to the search icon when no custom color is set, instead of making it transparent. <table> <tr> <td> Before fix </td> <td> After fix </td> </tr> <tr> <td> https://github.com/user-attachments/assets/22c5dc6f-2e8a-417d-89da-afaa422c9e15 </td> <td> https://github.com/user-attachments/assets/b4289eb2-7266-48a2-be12-eb0eabecb40f </td> </tr> </table>
kubaflo
pushed a commit
to kubaflo/maui
that referenced
this pull request
Jan 16, 2026
…e - 1 (dotnet#33384) This pull request refines the logic for setting the search icon color in the Android `SearchView`. This PR dotnet#33071 set the search icon color to transparent if no color was specified, which caused the search icon to become invisible and led to search bar-related test failures. Now, if no custom search icon color is provided, the icon will use the platform's default primary text color instead of becoming transparent. **Android SearchView icon color handling:** * Updated `UpdateSearchIconColor` in `SearchViewExtensions.cs` to apply the default primary text color (`TextColorPrimary`) to the search icon when no custom color is set, instead of making it transparent. <table> <tr> <td> Before fix </td> <td> After fix </td> </tr> <tr> <td> https://github.com/user-attachments/assets/22c5dc6f-2e8a-417d-89da-afaa422c9e15 </td> <td> https://github.com/user-attachments/assets/b4289eb2-7266-48a2-be12-eb0eabecb40f </td> </tr> </table>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines the logic for setting the search icon color in the Android
SearchView. This PR #33071 set the search icon color to transparent if no color was specified, which caused the search icon to become invisible and led to search bar-related test failures. Now, if no custom search icon color is provided, the icon will use the platform's default primary text color instead of becoming transparent.Android SearchView icon color handling:
UpdateSearchIconColorinSearchViewExtensions.csto apply the default primary text color (TextColorPrimary) to the search icon when no custom color is set, instead of making it transparent.Screen.Recording.2026-01-06.at.6.18.31.PM.mov
Screen.Recording.2026-01-06.at.6.25.09.PM.mov