Add accessibility identifier to MauiDoneAccessoryView Done button for UI testing by Copilot · Pull Request #32828 · dotnet/maui

Copilot · 2025-11-24T09:29:19Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

The Done button in numeric keyboard's input accessory view was not accessible for UI testing due to missing accessibility identifier.

Changes:

Set AccessibilityIdentifier = "Microsoft.Maui.Platform.MauiDoneAccessory.DoneButton" on UIBarButtonItem in both MauiDoneAccessoryView constructors
Added UI test verifying Done button accessibility and tap behavior

Usage in tests:

App.WaitForElement("Microsoft.Maui.Platform.MauiDoneAccessory.DoneButton");
App.Tap("Microsoft.Maui.Platform.MauiDoneAccessory.DoneButton");

Issues Fixed

Fixes #32825

Original prompt

This section details on the original issue you should resolve

<issue_title>Make MauiDoneAccessoryView DoneButton accessible</issue_title>
<issue_description>### Description

PR #24645 added a Done button to numeric entry's keyboard.

Currently it's not accessible because no Id is assigned.
IMHO Maui should set some Id(Microsoft.Maui.Platform.MauiDoneAccessory.DoneButton?) to enable UI-Tests

Steps to Reproduce

Add a Entry with numeric keyboard to a page

Inspect elements

Link to public reproduction project repository

No response

Version with bug

10.0.10

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

No response

Affected platforms

iOS

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output
```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

Fixes Make MauiDoneAccessoryView DoneButton accessible #32825

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

jfversluis · 2025-11-24T10:14:49Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-11-24T10:15:02Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-11-24T10:30:03Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This PR adds an accessibility identifier to the Done button in iOS numeric keyboard's input accessory view to enable UI testing automation. The change addresses GitHub issue #32825 by adding the identifier "Microsoft.Maui.Platform.MauiDoneAccessory.DoneButton" to the UIBarButtonItem in both MauiDoneAccessoryView constructors and includes a comprehensive UI test to verify the functionality.

Key Changes

Added accessibility identifier constant and assignment to UIBarButtonItems in MauiDoneAccessoryView
Created UI test infrastructure to verify the Done button is accessible and functional
Implemented test page with Entry control using numeric keyboard to demonstrate the feature

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/Core/src/Platform/iOS/MauiDoneAccessoryView.cs	Added constant for automation ID and assigned it to Done button in both constructors
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/MauiDoneAccessoryButton.cs	NUnit UI test that verifies Done button accessibility and tap behavior
src/Controls/tests/TestCases.HostApp/Issues/MauiDoneAccessoryButton.cs	Test page with numeric Entry demonstrating Done button functionality

src/Controls/tests/TestCases.HostApp/Issues/MauiDoneAccessoryButton.cs

…utton.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

azure-pipelines · 2025-11-24T15:13:32Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-11-24T16:03:28Z

Azure Pipelines successfully started running 1 pipeline(s).

jfversluis

Failing test unrelated

…2828) Add accessibility identifier to MauiDoneAccessoryView Done button Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> Address code review feedback - extract constant and improve comment Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> Update src/Controls/tests/TestCases.HostApp/Issues/MauiDoneAccessoryButton.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…tton (#32828)" This reverts commit 6c59667.

…2828) Add accessibility identifier to MauiDoneAccessoryView Done button Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> Address code review feedback - extract constant and improve comment Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> Update src/Controls/tests/TestCases.HostApp/Issues/MauiDoneAccessoryButton.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

64f40eb

Copilot AI assigned Copilot and jfversluis Nov 24, 2025

Copilot started work on behalf of jfversluis November 24, 2025 09:29 View session

Copilot AI and others added 2 commits November 24, 2025 09:49

Add accessibility identifier to MauiDoneAccessoryView Done button

501ee79

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Address code review feedback - extract constant and improve comment

9ea8125

Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add Id to Done button for accessibility~~ Add accessibility identifier to MauiDoneAccessoryView Done button for UI testing Nov 24, 2025

Copilot AI requested a review from jfversluis November 24, 2025 09:55

Copilot finished work on behalf of jfversluis November 24, 2025 09:55

jfversluis marked this pull request as ready for review November 24, 2025 10:29

Copilot AI review requested due to automatic review settings November 24, 2025 10:29

Copilot started reviewing on behalf of jfversluis November 24, 2025 10:31 View session

Copilot finished reviewing on behalf of jfversluis November 24, 2025 10:32

Copilot AI reviewed Nov 24, 2025

View reviewed changes

src/Controls/tests/TestCases.HostApp/Issues/MauiDoneAccessoryButton.cs Outdated Show resolved Hide resolved

Update src/Controls/tests/TestCases.HostApp/Issues/MauiDoneAccessoryB…

ce36202

…utton.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jfversluis approved these changes Nov 26, 2025

View reviewed changes

jfversluis changed the base branch from main to inflight/current November 26, 2025 13:47

jfversluis merged commit 9ff4e77 into inflight/current Nov 26, 2025
115 of 118 checks passed

jfversluis deleted the copilot/make-done-button-accessible branch November 26, 2025 13:48

jfversluis added a commit that referenced this pull request Dec 5, 2025

Revert "Add accessibility identifier to MauiDoneAccessoryView Done bu…

4587ae1

…tton (#32828)" This reverts commit 6c59667.

PureWeen added the area-controls-entry Entry label Dec 18, 2025

github-actions bot locked and limited conversation to collaborators Jan 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add accessibility identifier to MauiDoneAccessoryView Done button for UI testing#32828

Add accessibility identifier to MauiDoneAccessoryView Done button for UI testing#32828
jfversluis merged 4 commits intoinflight/currentfrom
copilot/make-done-button-accessible

Copilot AI commented Nov 24, 2025 •

edited by jfversluis

Loading

Uh oh!

jfversluis commented Nov 24, 2025 •

edited

Loading

Uh oh!

azure-pipelines bot commented Nov 24, 2025

Uh oh!

azure-pipelines bot commented Nov 24, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

azure-pipelines bot commented Nov 24, 2025

Uh oh!

azure-pipelines bot commented Nov 24, 2025

Uh oh!

jfversluis left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Nov 24, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Issues Fixed

Steps to Reproduce

Link to public reproduction project repository

Version with bug

Is this a regression from previous behavior?

Last version that worked well

Affected platforms

Affected platform versions

Did you find any workaround?

Relevant log output

Uh oh!

jfversluis commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Nov 24, 2025

Uh oh!

azure-pipelines bot commented Nov 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

azure-pipelines bot commented Nov 24, 2025

Uh oh!

azure-pipelines bot commented Nov 24, 2025

Uh oh!

jfversluis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Nov 24, 2025 •

edited by jfversluis

Loading

jfversluis commented Nov 24, 2025 •

edited

Loading