Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the variable group declarations in the pipeline configuration to make the MAUI variable group unconditionally available instead of being conditionally included based on build definition names.
Key Changes
- The MAUI variable group is moved from conditional inclusion to unconditional inclusion at the top level
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
/backport to release/10.0.1xx-sr1 |
Contributor
|
Started backporting to |
Contributor
|
@PureWeen backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128 |
Copilot AI
added a commit
that referenced
this pull request
Nov 20, 2025
Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
PureWeen
added a commit
that referenced
this pull request
Nov 20, 2025
…#32781) * Initial plan * Backport PRs #32610, #32694, #32779 - pipeline configuration fixes Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
We need a couple of variables from this variable group.
Change other variables to control internal vs public builds.
Small cleanup
This pull request updates build and pipeline configuration files to simplify variable handling, improve conditional logic for build stages, and clean up unused parameters. The primary focus is on streamlining how build arguments and variable groups are set for different build scenarios, including official, public, and internal builds.
Build and variable configuration simplification
_InternalBuildArgsvariable and its assignment fromeng/pipelines/common/variables.yml, and updated how theMAUIvariable group is included to always be present, rather than conditionally. [1] [2]_PublishArgsineng/pipelines/arcade/variables.ymlto use build definition names instead of checking for public/internal builds and pull requests, making the conditions more explicit and maintainable._OfficialBuildIdArgsto an empty value instead of passing parameters, simplifying the official build argument handling.Pipeline cleanup and conditional logic improvements
UseProvisionatorparameter and related provisioning logic fromeng/pipelines/ci-uitests.yml, reducing complexity and potential confusion in test pipeline configuration. [1] [2]Minor fix
Creatorproperty condition ineng/helix.projto check for an existing value before setting a default, preventing unwanted overrides.