[iOS] Fix DatePicker to consistently display 4-digit years by Copilot · Pull Request #32451 · dotnet/maui

Copilot · 2025-11-07T21:14:32Z

Analyze existing PR changes and feedback
Fix test assertions to correctly validate 4-digit year format
Apply @mattleibow's fix for format inconsistency
Rename test files from Issue31117 to Issue31167
Run code review
Run CodeQL security scan (no issues)
Complete takeover of PR

Summary of Changes

1. Test Assertion Fix (commit `9d07ee8`)

Removed incorrect /24 pattern checks that failed on valid dates like 12/24/2024
Tests now verify presence of 4-digit years only

2. Format Inconsistency Fix (commit `fdd3ade`)

Root Cause: The picker is not null condition caused different formatting paths:

Initial display → C# DateTime.ToString() → format like 6/15/2024
After interaction → iOS NSDateFormatter → format like 2023/06/15

Solution Applied (per @mattleibow's analysis):

Removed picker is not null check to always use iOS formatting
Changed from picker.Date to datePicker.Date.Value.ToNSDate() for consistent date source
Both initial and post-interaction now use same iOS NSDateFormatter with yMd template
Maintains 4-digit years while ensuring format consistency

3. Test File Naming Fix (commit `9843652`)

Renamed test files from Issue31117 to Issue31167 to match the actual issue number
Fixed XAML file naming from Issues31117.xaml to Issue31167.xaml (singular "Issue")
Updated all class names and references
Updated [Issue] attribute to reference issue [iOS] DatePicker initially shows year in 4 digits, but after changing the year it displays only 2 digits in net 10.0 #31167

Result

✅ Fixes 2-digit year bug (4-digit years always displayed)
✅ Fixes format inconsistency bug (format stays consistent across interactions)
✅ Respects iOS locale settings consistently
✅ Custom formats preserved (bypass this code path)
✅ Test files correctly named to match issue number

Testing

The fix ensures format consistency across different locale settings while maintaining 4-digit year display. All tests build successfully.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

mattleibow · 2025-11-08T02:15:24Z

My machine shows wildly different dates when default/empty pickers change.

Before picking	After picking

My region:

For me, this PR does nothing. I am not sure why the initial dates are different. But this PR does not change as a result.

mattleibow · 2025-11-08T02:58:10Z

✅ Root Cause Identified and Fix Proposed

After thorough investigation and testing, I've identified the root cause of the format inconsistency issue and implemented a fix.

🔍 Root Cause Analysis

The format inconsistency happens because of a conditional check on line 83 of DatePickerExtensions.cs:

else if (picker is not null && (string.IsNullOrWhiteSpace(format) || format.Equals("d", StringComparison.OrdinalIgnoreCase)))

This condition means the iOS native formatting path only executes when picker is not null.

The Problem:

During initial setup (when picker might be null during handler initialization):
- Condition fails because picker is null
- Falls through to line 109: platformDatePicker.Text = datePicker.Date?.ToString(format)
- Uses C# DateTime.ToString() which follows CultureInfo.CurrentCulture
After user interaction (when picker is fully initialized):
- Condition passes because picker is not null
- Uses iOS NSDateFormatter with yMd template
- Follows iOS's interpretation of the locale
Result: C# and iOS interpret the same locale differently, causing format changes like:
- 6/15/2024 (C# M/d/yyyy) → 2023/06/15 (iOS yyyy/MM/dd)

✅ The Fix

Remove the picker is not null check and always use iOS formatting for consistency.

Code Change

-else if (picker is not null && (string.IsNullOrWhiteSpace(format) || format.Equals("d", StringComparison.OrdinalIgnoreCase)))
+else if (string.IsNullOrWhiteSpace(format) || format.Equals("d", StringComparison.OrdinalIgnoreCase))
 {
     NSDateFormatter dateFormatter = new NSDateFormatter
     {
         TimeZone = NSTimeZone.FromGMT(0)
     };
 
+    // Use datePicker.Date (the source date) for formatting
+    // This ensures consistent formatting whether picker is initialized or not
+    var nsDate = datePicker.Date.Value.ToNSDate();
+
     if (format.Equals("D", StringComparison.Ordinal) == true)
     {
         dateFormatter.DateStyle = NSDateFormatterStyle.Long;
-        var strDate = dateFormatter.StringFor(picker.Date);
+        var strDate = dateFormatter.StringFor(nsDate);
         platformDatePicker.Text = strDate;
     }
     else
     {
         dateFormatter.SetLocalizedDateFormatFromTemplate("yMd");
-        var strDate = dateFormatter.StringFor(picker.Date);
+        var strDate = dateFormatter.StringFor(nsDate);
         platformDatePicker.Text = strDate;
     }
 }

Key Changes:

Removed picker is not null check → iOS formatting now runs regardless of picker state
Added var nsDate = datePicker.Date.Value.ToNSDate() → Use the source date instead of picker.Date
Changed picker.Date → nsDate in both formatting paths

🎯 Why This Works

Before Fix:

Initial: C# formats 6/15/2024 (C# culture interpretation)
After interaction: iOS formats 2023/06/15 (iOS locale interpretation)
Result: Format changes ❌

After Fix:

Initial: iOS formats using yMd template
After interaction: iOS formats using yMd template
Result: Format stays consistent ✅

Both initial and post-interaction now use the same formatting system (iOS NSDateFormatter with yMd template), ensuring consistency.

✅ Benefits

Fixes format inconsistency: Initial and post-interaction formats now match
Maintains 4-digit years: The yMd template still forces 4-digit years
Respects iOS locale: Users see dates formatted according to their iOS settings consistently
No breaking changes: Custom formats still work exactly as before (they bypass this code path)

🧪 Testing

I've built and tested this fix with the Sandbox app on iOS 26.0. The fix ensures:

✅ Initial display uses iOS formatter
✅ Post-interaction uses iOS formatter
✅ Format stays consistent throughout
✅ 4-digit years are maintained
✅ Custom formats (MM/dd/yyyy, yyyy-MM-dd) continue to work

📝 Recommendation

This fix should be applied on top of the existing PR to resolve the format inconsistency issue while maintaining the 4-digit year fix.

Next Steps:

Apply this fix to the PR
Test on multiple locales (US, UK, Arabic, Japanese)
Verify format consistency across all scenarios
Update tests to verify format consistency (not just 4-digit years)

mattleibow · 2025-11-08T03:02:55Z

@copilot please look ath the fix propsed and apply it. Look at the comments and reviews on this PR

Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>

Copilot · 2025-11-08T03:08:51Z

@copilot please look ath the fix propsed and apply it. Look at the comments and reviews on this PR

Applied your fix in commit fdd3ade. The changes remove the picker is not null condition and use datePicker.Date.Value.ToNSDate() for consistent formatting. This ensures both initial display and post-interaction use the same iOS NSDateFormatter, preventing format changes like 6/15/2024 → 2023/06/15.

mattleibow · 2025-11-08T03:18:06Z

Quick Follow-up on Minor Suggestions

The two remaining suggestions from my review are optional improvements and don't block merge:

1. Test File Naming (Issue31117 → Issue31167)

Current state: Test files are named Issue31117.* but the linked issue is #31167.

Impact: Minor - Tests function correctly, but the naming mismatch could confuse future maintainers looking for tests related to issue #31167.

If you choose to fix: Rename these 3 files:

src/Controls/tests/TestCases.HostApp/Issues/Issues31117.xaml → Issue31167.xaml (also change "Issues" to "Issue")
src/Controls/tests/TestCases.HostApp/Issues/Issues31117.xaml.cs → Issue31167.xaml.cs
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31117.cs → Issue31167.cs

And update all references to the class name from Issue31117 to Issue31167.

If you choose not to fix: The tests work fine as-is, so this is purely a naming consistency concern.

2. Remove `#if IOS` Wrapper from UI Test

Current state: The UI test class Issue31117.cs (line 1) has #if IOS wrapping the entire class.

Why it might be unnecessary:

The [Issue] attribute in the HostApp already specifies PlatformAffected.iOS
The test infrastructure handles platform targeting automatically
Per UI testing guidelines, #if directives should only be used when there's a technical limitation (e.g., platform-specific compilation issues)

Impact: Very minor - The test compiles and runs correctly on iOS. The #if IOS just prevents it from compiling on other platforms, which may or may not be necessary.

If you choose to remove it: Delete line 1 (#if IOS) and the corresponding #endif at the end of the file. The test will compile on all platforms but still only run on iOS due to the PlatformAffected attribute.

If you choose to keep it: There may be a valid reason for the compilation restriction that I'm not aware of, so it's fine to leave as-is.

Bottom line: Both suggestions are cosmetic/organizational improvements. The PR is functionally correct and ready to merge regardless of whether you address them. 🎉

mattleibow · 2025-11-08T03:20:07Z

@copilot 1. Test File Naming (Issue31117 → Issue31167)
Current state: Test files are named Issue31117.* but the linked issue is #31167.

Impact: Minor - Tests function correctly, but the naming mismatch could confuse future maintainers looking for tests related to issue #31167.

If you choose to fix: Rename these 3 files:

src/Controls/tests/TestCases.HostApp/Issues/Issues31117.xaml → Issue31167.xaml (also change "Issues" to "Issue")
src/Controls/tests/TestCases.HostApp/Issues/Issues31117.xaml.cs → Issue31167.xaml.cs
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31117.cs → Issue31167.cs
And update all references to the class name from Issue31117 to Issue31167.

If you choose not to fix: The tests work fine as-is, so this is purely a naming consistency concern.

Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>

Copilot · 2025-11-08T03:26:35Z

@copilot 1. Test File Naming (Issue31117 → Issue31167)
Current state: Test files are named Issue31117.* but the linked issue is #31167.
...

Renamed test files in commit 9843652. Changes:

Issues31117.xaml → Issue31167.xaml (also fixed "Issues" to "Issue")
Issues31117.xaml.cs → Issue31167.xaml.cs
Issue31117.cs → Issue31167.cs
Updated all class names from Issue31117 to Issue31167
Updated [Issue] attribute from 31117 to 31167

Tests build successfully with the new naming.

mattleibow · 2025-11-08T03:30:59Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-11-08T03:31:11Z

Azure Pipelines successfully started running 1 pipeline(s).

* More device tests * Fix the issue * Added UITests * Avoid Regex * Updated comment * Updated snapshots * Updated tests * Initial plan * Fix test assertions to correctly validate 4-digit year format Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * Fix format inconsistency by always using iOS formatting Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com> * Rename test files from Issue31117 to Issue31167 to match issue number Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com> --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>

jsuarezruiz and others added 9 commits October 22, 2025 22:41

More device tests

c9e8c80

Fix the issue

6badc38

Added UITests

3d3d5ac

Avoid Regex

d501c23

Updated comment

c9088a8

Updated snapshots

a053d07

Updated tests

f299fc4

Merge branch 'net10.0' into fix-31167-II

1f2ba33

Initial plan

b30bf21

Copilot AI assigned Copilot and PureWeen Nov 7, 2025

Copilot AI mentioned this pull request Nov 7, 2025

[iOS] Fix DatePicker to consistently display 4-digit years #31464

Closed

Copilot started work on behalf of PureWeen November 7, 2025 21:14 View session

Fix test assertions to correctly validate 4-digit year format

9d07ee8

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix DatePicker to display 4-digit years consistently~~ [iOS] Fix DatePicker to consistently display 4-digit years Nov 7, 2025

Copilot AI requested a review from PureWeen November 7, 2025 21:27

Copilot finished work on behalf of PureWeen November 7, 2025 21:27

PureWeen closed this Nov 7, 2025

PureWeen reopened this Nov 7, 2025

PureWeen changed the base branch from fix-31167-II to main November 7, 2025 21:30

PureWeen added this to the .NET 10.0 SR1 milestone Nov 7, 2025

PureWeen added the p/0 Current heighest priority issues that we are targeting for a release. label Nov 7, 2025

PureWeen added this to MAUI SDK Ongoing Nov 7, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Nov 7, 2025

PureWeen added platform/ios area-controls-datetimepicker DatePicker, TimePicker labels Nov 7, 2025

PureWeen marked this pull request as ready for review November 7, 2025 21:36

Copilot AI review requested due to automatic review settings November 7, 2025 21:36

Copilot AI reviewed Nov 7, 2025

View reviewed changes

Copilot started work on behalf of mattleibow November 8, 2025 03:03 View session

Fix format inconsistency by always using iOS formatting

fdd3ade

Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>

Copilot AI requested a review from mattleibow November 8, 2025 03:10

Copilot finished work on behalf of mattleibow November 8, 2025 03:10

Copilot started work on behalf of mattleibow November 8, 2025 03:20 View session

Rename test files from Issue31117 to Issue31167 to match issue number

9843652

Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>

Copilot finished work on behalf of mattleibow November 8, 2025 03:29

mattleibow approved these changes Nov 8, 2025

View reviewed changes

PureWeen changed the base branch from main to inflight/current November 11, 2025 17:21

PureWeen merged commit 122a872 into inflight/current Nov 11, 2025
99 of 102 checks passed

github-project-automation bot moved this from Changes Requested to Done in MAUI SDK Ongoing Nov 11, 2025

PureWeen deleted the copilot/sub-pr-31464 branch November 11, 2025 17:22

github-actions bot locked and limited conversation to collaborators Dec 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iOS] Fix DatePicker to consistently display 4-digit years#32451

[iOS] Fix DatePicker to consistently display 4-digit years#32451
PureWeen merged 12 commits intoinflight/currentfrom
copilot/sub-pr-31464

Copilot AI commented Nov 7, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

mattleibow commented Nov 8, 2025 •

edited

Loading

Uh oh!

mattleibow commented Nov 8, 2025

Uh oh!

mattleibow commented Nov 8, 2025

Uh oh!

Copilot AI commented Nov 8, 2025

Uh oh!

mattleibow commented Nov 8, 2025 •

edited

Loading

Uh oh!

mattleibow commented Nov 8, 2025

Uh oh!

Copilot AI commented Nov 8, 2025

Uh oh!

mattleibow commented Nov 8, 2025

Uh oh!

azure-pipelines bot commented Nov 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Copilot AI commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

1. Test Assertion Fix (commit 9d07ee8)

2. Format Inconsistency Fix (commit fdd3ade)

3. Test File Naming Fix (commit 9843652)

Result

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

mattleibow commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattleibow commented Nov 8, 2025

✅ Root Cause Identified and Fix Proposed

🔍 Root Cause Analysis

✅ The Fix

Code Change

🎯 Why This Works

✅ Benefits

🧪 Testing

📝 Recommendation

Uh oh!

mattleibow commented Nov 8, 2025

Uh oh!

Copilot AI commented Nov 8, 2025

Uh oh!

mattleibow commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Quick Follow-up on Minor Suggestions

1. Test File Naming (Issue31117 → Issue31167)

2. Remove #if IOS Wrapper from UI Test

Uh oh!

mattleibow commented Nov 8, 2025

Uh oh!

Copilot AI commented Nov 8, 2025

Uh oh!

mattleibow commented Nov 8, 2025

Uh oh!

azure-pipelines bot commented Nov 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Nov 7, 2025 •

edited

Loading

1. Test Assertion Fix (commit `9d07ee8`)

2. Format Inconsistency Fix (commit `fdd3ade`)

3. Test File Naming Fix (commit `9843652`)

mattleibow commented Nov 8, 2025 •

edited

Loading

mattleibow commented Nov 8, 2025 •

edited

Loading

2. Remove `#if IOS` Wrapper from UI Test