Fix keyboard overlap on Android when SoftInput.AdjustResize is set by Copilot · Pull Request #32405 · dotnet/maui

Copilot · 2025-11-05T14:43:00Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

Fixed a regression in .NET 10 RC2 where the keyboard overlaps Entry controls when developers set SoftInput.AdjustResize in MainActivity, breaking the standard Android resize behavior that worked in .NET 9.

Root Cause: WindowCompat.SetDecorFitsSystemWindows(Window, false) in MauiAppCompatActivity disabled automatic window resizing. The inset handler only applied keyboard padding when SafeAreaRegions.SoftInput was explicitly set, ignoring the window's SoftInputMode.

Changes Made:

SafeAreaExtensions.cs - Enhanced to detect window's SoftInputMode and apply keyboard insets when AdjustResize is set, regardless of SafeAreaRegions settings
- Apply keyboard insets to all container types (drawer layouts, coordinator layouts, etc.) when AdjustResize is set
- Replaced magic numbers (0, 1, 2, 3) with named constants (EdgeLeft, EdgeTop, EdgeRight, EdgeBottom) for better code readability
- Refactored duplicated inset consumption logic in ApplyAdjustedSafeAreaInsetsPx
- Fixed GetSafeAreaForEdge to return 0 for SoftInput-only regions when keyboard is hidden
- Ensured keyboard-related padding only applies when keyboard is actually visible
UI Tests - Added comprehensive test coverage:
- Issue32041.xaml/.cs: Tests AdjustResize mode - verifies keyboard insets ARE applied when keyboard shows
- Issue32041AdjustPan.xaml/.cs: Tests AdjustPan mode - verifies keyboard insets are NOT applied (Android handles panning)
Cross-platform build fixes - Wrapped using Android.Views; with #if ANDROID in 14 test files to fix build errors on iOS, Windows, and MacCatalyst

Key Behavior:

When SoftInput.AdjustResize is set: Keyboard insets are applied to push content up, avoiding overlap
When SoftInput.AdjustPan is set: No insets applied (Android natively pans the window)
When SafeAreaEdges=SoftInput only and keyboard is hidden: Returns 0 padding (no unnecessary safe area insets)

All existing unit tests pass (45/45 SafeArea tests).

Issues Fixed

Fixes #32041

Original prompt

This section details on the original issue you should resolve

<issue_title>net 10 rc2 keyboard overlap android</issue_title>
<issue_description>### Description

if you have an entry at the bottom of the screen , the keyboards ovelarps it and you cannot see anything, as you can imagine we have applications where a user is asked to input lots of data and all the entries are overlapped!

Steps to Reproduce

Create a page in maui .net 10 rc2

Place an entry at the bottom of the screen

Start typing.. and the keyboard will overlap the entry

Add below to MainActivity

I have attached both repo - net 9 and 10
protected override void OnCreate(Bundle? savedInstanceState)
       {
           base.OnCreate(savedInstanceState);
           Window?.SetSoftInputMode(SoftInput.AdjustResize | SoftInput.StateUnspecified);

       }
Works in .net 9 but not in .net 10See below net 9 on the left and .net 10 RC2 on the right!

MauiAppNe10Overlap.zip
MauiNet9Overlap.zip

Link to public reproduction project repository

No response

Version with bug

10.0.0-rc.2

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

9.0.111 SR11.1

Affected platforms

Android

Affected platform versions

No response

Did you find any workaround?

none

Relevant log output
```</issue_description>

<agent_instructions>If the user has set the Android Window's SoftInput mode to AdjustResize then we should inset the top level view on the android app if the softinput is open . I'm not sure the best fix here, what we might do is set the inset listener on the container view at the top level and then pad that if the softinput is open and they've set the window to adjust resize, or we add the inset listener to the DecorView. Not sure, need to test out a few scenarios</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
<comment_new><author>@jsuarezruiz</author><body>
@NirmalKumarYuvaraj I have seen Shane assigned you to review it. My thoughts:
- I think the regression comes from https://github.com/dotnet/maui/pull/31798/files
- The issue occurs because `WindowCompat.SetDecorFitsSystemWindows(Window, false)` was being called in `MauiAppCompatActivity.OnCreate()`. When set to false, this tells Android that the app will handle all window insets manually, which disables the default `SoftInput.AdjustResize` behavior.</body></comment_new>
<comment_new><author>@PureWeen</author><body>
@TedMobile as a workaround

I think you can set SafeAreaEdges on your ContentPages to "Container" and that should fix for now</body></comment_new>
<comment_new><author>@NirmalKumarYuvaraj</author><body>
@TedMobile , You can set SafeAreaEdges on your ContentPages to "All". This will fix the issue, I have attached a video reference.

https://github.com/user-attachments/assets/6d11a017-0c30-46d8-bccf-d9188329e00f

</body></comment_new>
<comment_new><author>@PureWeen</author><body>
> [@NirmalKumarYuvaraj](https://github.com/NirmalKumarYuvaraj) [@PureWeen](https://github.com/PureWeen) well, Adding SafeAreasEdges.All I have noticed that creates an overlap in iOS on many of my screens but fixes android.

do you have a repro on iOS by chance?</body></comment_new>
</comments>

Fixes net 10 rc2 keyboard overlap android #32041

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

jsuarezruiz · 2025-11-06T07:19:16Z

/azp run

azure-pipelines · 2025-11-06T07:19:23Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

jsuarezruiz · 2025-11-06T07:29:03Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32041.cs

+
+	[Test]
+	[Category(UITestCategories.SafeAreaEdges)]
+	public void VerifyKeyboardDoesNotOverlapEntryWithAdjustResize()


Add a test for AdjustPan Mode. Current test validates AdjustResize; adding a pan-mode assertion ensures no regressions where pan doesn't apply insets incorrectly.

Added AdjustPan test in commit ff901a2. The new test verifies that when SoftInput.AdjustPan is set, no keyboard insets are applied (the window pans instead).

NirmalKumarYuvaraj · 2025-11-06T09:19:43Z

@copilot , Add a test for AdjustPan Mode. Current test validates AdjustResize; adding a pan-mode assertion ensures no regressions where pan doesn't apply insets incorrectly.

Copilot · 2025-11-06T09:38:51Z

@copilot , Add a test for AdjustPan Mode. Current test validates AdjustResize; adding a pan-mode assertion ensures no regressions where pan doesn't apply insets incorrectly.

Added AdjustPan test in commit ff901a2. Created Issue32041AdjustPan test page and test case that verifies no insets are applied when AdjustPan mode is set.

jsuarezruiz

@copilot Fix current conflict.

Copilot · 2025-11-07T08:06:03Z

@copilot Fix current conflict.

Merged main into branch in commit e93315f. The merge completed successfully with no conflicts.

PureWeen · 2025-11-08T23:06:01Z

/rebase

PureWeen · 2025-11-09T00:09:58Z

@copilot i have rebased this pr

can you asses if your changes on this pr still seem correct?

- Wrapped 'using Android.Views;' with #if ANDROID in Issue28986_FlyoutPage.cs - Wrapped 'using Android.Views;' with #if ANDROID in Issue28986_NavigationPage.cs - Wrapped 'using Android.Views;' with #if ANDROID in Issue28986_Shell.cs - Fixes cross-platform build errors where Android.Views is not available on iOS, Windows, and MacCatalyst Co-authored-by: NirmalKumarYuvaraj <97871636+NirmalKumarYuvaraj@users.noreply.github.com>

…d padding behavior - Removed duplicated AdjustPan check in ApplyAdjustedSafeAreaInsetsPx (lines 117-132) - Removed duplicated keyboard inset logic in GetSafeAreaForEdge (lines 313-322) - Ensured keyboard padding only applies when keyboard is actually showing - Fixed indentation and formatting issues - All existing SafeArea unit tests pass (45/45) Co-authored-by: NirmalKumarYuvaraj <97871636+NirmalKumarYuvaraj@users.noreply.github.com>

… is only SoftInput - Moved SafeAreaRegions.None check to the top of the method - Added check for when keyboard is NOT showing and SafeAreaEdges is ONLY SoftInput to return 0 - Ensures that when keyboard is hidden, views with SafeAreaEdges=SoftInput don't get unnecessary padding - All existing SafeArea unit tests pass (45/45) Co-authored-by: NirmalKumarYuvaraj <97871636+NirmalKumarYuvaraj@users.noreply.github.com>

- SafeAreaExtensions: Check AdjustResize BEFORE SafeAreaRegions.None This ensures keyboard insets are applied even when page has no explicit SafeAreaEdges set, fixing the regression where AdjustResize was ignored - Issue32041 test: Measure bottom marker position instead of container height ContentPage's Grid height doesn't change when padding is applied to wrapper, but the bottom marker's Y position correctly reflects the upward movement when keyboard appears. This tests actual user-visible behavior. Fixes the failing VerifyContainerResizesWithAdjustResize test while maintaining compatibility with FlyoutPage, Shell, and TabbedPage tests.

PureWeen

based on our chats

we need to fix adjustresize here so it works at the root level of the view, not just on the layouts inside the page. For example, if a page has bottom tabs those tabs should also resize up
I do still think there's a bug here to fix around the timing of the keyboad though because I think this issue will still happen if you were to set the layout itself to SafeAreaEdges.All

Can you create a new PR for a different implementation of AdjustResize to cover the first point and then lets keep working on this one to fix the timing. I still think there's a possible solution here that doesn't involve the magic 500px number check

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

PureWeen · 2025-12-24T14:34:25Z

#33145

IeuanWalker · 2025-12-27T14:30:01Z

I do still think there's a bug here to fix around the timing of the keyboad though because I think this issue will still happen if you were to set the layout itself to SafeAreaEdges.All

@PureWeen there is also a timing issue on iOS - #25185

Copilot AI assigned Copilot and PureWeen Nov 5, 2025

Copilot started work on behalf of PureWeen November 5, 2025 14:43 View session

Copilot AI changed the title ~~[WIP] Fix keyboard overlap issue in .NET 10 RC2~~ Fix keyboard overlap on Android when SoftInput.AdjustResize is set Nov 5, 2025

Copilot AI requested a review from PureWeen November 5, 2025 15:30

Copilot finished work on behalf of PureWeen November 5, 2025 15:30

jsuarezruiz suggested changes Nov 6, 2025

View reviewed changes

Copilot started work on behalf of NirmalKumarYuvaraj November 6, 2025 09:20 View session

Copilot AI requested a review from NirmalKumarYuvaraj November 6, 2025 09:40

Copilot finished work on behalf of NirmalKumarYuvaraj November 6, 2025 09:40

github-actions bot force-pushed the copilot/improve-copilot-agent-strategies branch from c036163 to c004621 Compare November 6, 2025 22:22

jsuarezruiz reviewed Nov 7, 2025

View reviewed changes

Copilot started work on behalf of jsuarezruiz November 7, 2025 07:56 View session

Copilot AI requested a review from jsuarezruiz November 7, 2025 08:07

Copilot finished work on behalf of jsuarezruiz November 7, 2025 08:07

Base automatically changed from copilot/improve-copilot-agent-strategies to main November 7, 2025 20:00

PureWeen added this to the .NET 10.0 SR1 milestone Nov 8, 2025

PureWeen added this to MAUI SDK Ongoing Nov 8, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Nov 8, 2025

PureWeen added the p/0 Current heighest priority issues that we are targeting for a release. label Nov 8, 2025

PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Nov 8, 2025

PureWeen force-pushed the copilot/fix-keyboard-overlap-issue branch from e93315f to 756a5f5 Compare November 9, 2025 00:09

Copilot started work on behalf of PureWeen November 9, 2025 00:10 View session

Copilot AI and others added 6 commits December 11, 2025 01:37

added after keyboard close check

f945eab

address test case failures

6673467

github-actions bot force-pushed the copilot/fix-keyboard-overlap-issue branch from 17fda3d to 6673467 Compare December 11, 2025 01:37

PureWeen requested changes Dec 12, 2025

View reviewed changes

Copilot started work on behalf of PureWeen December 12, 2025 14:51 View session

Copilot stopped work on behalf of PureWeen due to an error December 12, 2025 14:51
Copilot has encountered an error. See logs for additional details.

Copilot AI requested a review from PureWeen December 12, 2025 14:51

This was referenced Dec 12, 2025

Configure Android SoftInput for Issue28986 SafeArea tests #33144

Closed

Fix keyboard overlap issue and add UI tests for SoftInput modes on Android (Issue #32041) #33145

Open

Copilot AI added a commit that referenced this pull request Dec 12, 2025

Add Issue32041 testing files from PR #32405

8aeef7d

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

PureWeen modified the milestones: .NET 10.0 SR2, .NET 10.0 SR3 Dec 13, 2025

kubaflo mentioned this pull request Dec 22, 2025

.NET 10: Android 16 edge-to-edge layout changes when using keyboard #33237

Open

Conversation

Copilot AI commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Issues Fixed

Steps to Reproduce

Link to public reproduction project repository

Version with bug

Is this a regression from previous behavior?

Last version that worked well

Affected platforms

Affected platform versions

Did you find any workaround?

Relevant log output

Uh oh!

jsuarezruiz commented Nov 6, 2025

Uh oh!

azure-pipelines bot commented Nov 6, 2025

Uh oh!

jsuarezruiz Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

NirmalKumarYuvaraj commented Nov 6, 2025

Uh oh!

Copilot AI commented Nov 6, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Nov 7, 2025

Uh oh!

PureWeen commented Nov 8, 2025

Uh oh!

PureWeen commented Nov 9, 2025

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

PureWeen commented Dec 24, 2025

Uh oh!

IeuanWalker commented Dec 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Copilot AI commented Nov 5, 2025 •

edited

Loading