November 3rd Inflight Candidate Build#32299
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR is a candidate build for November 3rd that includes bug fixes and new test coverage across several areas. The changes address issues with IndicatorView interactivity, DisplayAlert handling, shape rendering, picker extensions, and Windows UI styling, while adding comprehensive Grid feature matrix tests.
Key Changes
- Fixed critical bugs in IndicatorView (Android), DisplayAlert (Android), Shape stroke rendering, and Picker extension logic
- Added extensive Grid feature testing infrastructure with ViewModel, UI pages, and test cases
- Introduced new issue test cases for reported bugs (Issue31063, Issue25585, Issue19095, Issue17414)
Reviewed Changes
Copilot reviewed 22 out of 162 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Core/tests/UnitTests/TestCategory.cs | Added new "Extensions" test category |
| src/Core/tests/UnitTests/Extensions/IPickerExtensionTests.cs | Added unit tests for IPicker extension methods |
| src/Core/src/Platform/Windows/MauiNavigationView.cs | Fixed corner radius for navigation view to remove unwanted default styling |
| src/Core/src/Platform/Android/MauiPageControl.cs | Fixed IndicatorView to respect IsEnabled property |
| src/Core/src/Graphics/ShapeDrawable.cs | Fixed stroke rendering order to ensure strokes are fully visible |
| src/Core/src/Core/Extensions/IPickerExtension.cs | Fixed GetItemsAsList bug where elements weren't being added to the list |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31063.cs | Added test for IndicatorView IsEnabled fix |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25585.cs | Added test for DisplayAlert responsiveness fix |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19095.cs | Added test for shape stroke rendering fix |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17414.cs | Added test for Windows corner radius fix |
| src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/GridFeatureTests.cs | Added comprehensive Grid feature matrix tests |
| src/Controls/tests/TestCases.HostApp/Issues/Issue31063.cs | Added host app implementation for IndicatorView test case |
| src/Controls/tests/TestCases.HostApp/Issues/Issue25585.cs | Added host app implementation for DisplayAlert test case |
| src/Controls/tests/TestCases.HostApp/Issues/Issue19095.cs | Added host app implementation for shape stroke test case |
| src/Controls/tests/TestCases.HostApp/Issues/Issue17414.cs | Added host app implementation for corner radius test case |
| src/Controls/tests/TestCases.HostApp/FeatureMatrix/Grid/GridViewModel.cs | Added ViewModel for Grid feature testing |
| src/Controls/tests/TestCases.HostApp/FeatureMatrix/Grid/GridOptionsPage.xaml.cs | Added code-behind for Grid options configuration |
| src/Controls/tests/TestCases.HostApp/FeatureMatrix/Grid/GridOptionsPage.xaml | Added XAML for Grid options configuration |
| src/Controls/tests/TestCases.HostApp/FeatureMatrix/Grid/GridControlPage.xaml.cs | Added code-behind for Grid test page |
| src/Controls/tests/TestCases.HostApp/FeatureMatrix/Grid/GridControlPage.xaml | Added XAML for Grid test page |
| src/Controls/tests/TestCases.HostApp/CoreViews/CorePageView.cs | Added Grid Feature Matrix to gallery navigation |
| src/Controls/src/Core/Platform/AlertManager/AlertManager.Android.cs | Fixed DisplayAlert to wait for handler before showing dialogs |
Member
Author
|
/rebase |
…ed="False" (#31457) * Fix for IndicatorView IsEnabled * Removed Private Keyword * Test restricted on windows * Remove unwanted file * Modified the fix * Modify fix
#31838) * Update AlertManager.Android.cs * Update AlertManager.Android.cs * Update AlertManager.Android.cs * Update AlertManager.Android.cs * Test case added * Update Issue25585.cs * Update Issue25585.cs * Update AlertManager.Android.cs * Update AlertManager.Android.cs * Curly braces added * unused namespace removed
* Fixed polygon non zero fill issue * Added pending snaps
* Grid feature tests added * changes updated * Added base images * Added base images # Conflicts: # src/Controls/tests/TestCases.HostApp/CoreViews/CorePageView.cs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
… an empty list (#31879) * Fixed bug where IPickerExtensions.GetItemsAsList() would always return an empty list. * Added unit tests for IPickerExtension. * Fixed unit tests.
* Set a RootSplitView corner radius to Zero. * Fixed the transparency issue at the corner * Added test case
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…tal (#31395) * Fix the vertical scrolling issue * Modified the logics * Added test case * modified the test case * Modified the test case * modified the test case * Added test case for vertical orientation * Added test cases
* Fixed the CarouselView2 rendering issues * Modified the test case * Fixed the 7678_1 issue * Re-fixed the issue7678_1 based on conflicts file * Removed the GetDesiredSize code * Removed spaces * Fixed the 31339 crash issue and position update related issue * Fixed the crash when setting position is greater than itemcount * Included the more test scenarios and included the recipe test * Added the Log for debugging purposes * Fixed the CarouselView2 rendering issues * Modified the test case * Fixed the 7678_1 issue * Re-fixed the issue7678_1 based on conflicts file * Removed the GetDesiredSize code * Removed spaces * Fixed the 31339 crash issue and position update related issue * Fixed the crash when setting position is greater than itemcount * Included the more test scenarios and included the recipe test * Added the Log for debugging purposes * Committed the review changes
…d EmptyView not resized in CollectionView (#31916) * Update StructuredItemsViewController2.cs * fix updated * Test case added * Update StructuredItemsViewController2.cs * Update Issue31899.cs * Update Issue31899.cs * Test fail changes updated * Order value changed * Added snapshots
#32317) * Added_base_Images * Resaved_Images_for_gridfeaturetests
426160d to
d5b10e0
Compare
Member
Author
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mattleibow
approved these changes
Nov 5, 2025
| } | ||
|
|
||
| await Task.Delay(500); | ||
| await Task.Delay(50); |
There was a problem hiding this comment.
Reducing the delay from 500ms to 50ms improves test execution time significantly. However, ensure this reduced delay doesn't cause flakiness in the test. If the test becomes unstable, consider increasing to 100ms as a middle ground.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.