[CV2] Fix CarouselView vertical scrolling when orientation is horizontal#31395
Merged
PureWeen merged 8 commits intodotnet:inflight/candidatefrom Oct 31, 2025
Merged
[CV2] Fix CarouselView vertical scrolling when orientation is horizontal#31395PureWeen merged 8 commits intodotnet:inflight/candidatefrom
PureWeen merged 8 commits intodotnet:inflight/candidatefrom
Conversation
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in CarouselView where content was unintentionally scrolling vertically even when the orientation was set to horizontal on iOS. The issue was caused by improper bounce behavior configuration in the underlying UICollectionView.
Key changes:
- Added proper bounce direction configuration based on CarouselView orientation
- Created UI tests to validate the fix behavior
- Ensured bounce only occurs in the intended scroll direction
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Controls/src/Core/Handlers/Items2/iOS/CarouselViewController2.cs |
Added UpdateScrollingConstraints() method to configure bounce behavior based on orientation |
src/Controls/src/Core/Handlers/Items2/CarouselViewHandler2.iOS.cs |
Called the new constraint update method when layout changes |
src/Controls/tests/TestCases.HostApp/Issues/Issue31361.cs |
Created UI test page that demonstrates the carousel behavior with scroll detection |
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31361.cs |
Added automated test to verify vertical scrolling is prevented in horizontal CarouselView |
Comment on lines
+52
to
+58
| carouselView.Scrolled += (s, e) => | ||
| { | ||
| if (e.VerticalDelta < 0) | ||
| { | ||
| contentLabel.Text = "The content is scrollable"; | ||
| } | ||
| }; |
There was a problem hiding this comment.
The scroll detection logic only checks for VerticalDelta < 0 (upward scrolling), but vertical scrolling in either direction should indicate the bug is present. This should check e.VerticalDelta != 0 to detect any vertical movement.
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
reviewed
Sep 16, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
suggested changes
Sep 24, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Oct 23, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
…tal (#31395) * Fix the vertical scrolling issue * Modified the logics * Added test case * modified the test case * Modified the test case * modified the test case * Added test case for vertical orientation * Added test cases
This was referenced Nov 11, 2025
Closed
This was referenced Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
The CarouselView's current item content scrolls vertically even when the orientation is set to horizontal.
Root Cause
The bounce behavior was not properly disabled in CarouselView. Specifically, the UICollectionView’s AlwaysBounceVertical and AlwaysBounceHorizontal properties were not configured according to the CarouselView's orientation.
Description of Change
Configured the UICollectionView’s AlwaysBounceVertical and AlwaysBounceHorizontal properties based on the CarouselView's orientation to prevent unintended scrolling.
Validated the behavior in the following platforms
Issues Fixed
Fixes #31361
Output ScreenShot
BeforeFix.mov
AfterFix.mov