[Android, iOS, MacOS] Fixed Entry ClearButton Color Not Updating on AppThemeBinding Change by NanthiniMahalingam · Pull Request #30817 · dotnet/maui

NanthiniMahalingam · 2025-07-24T15:51:07Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

Entry ClearButton Color Not Updating on AppThemeBinding Change on Android, iOS and macOS platform

Root cause

On Android, the Entry clear button icon color does not update because the icon is not refreshed when the text color changes.
On iOS, the clear button color is not updated when the theme changes due to a missing call to the method responsible for updating the icon color.

Description of Change

On Android, I implemented an internal static method UpdateClearButtonColor in EditTextExtensions to update the clear button icon color. This method is invoked via the text color mapper in the Entry handler to ensure the clear button icon reflects theme and text color changes.
On iOS and macOS, I updated the text color mapper in the Entry handler to invoke UpdateClearButtonIconColor on the platform view. This ensures the clear button icon color is properly updated when the theme or text color changes.

Validated the behaviour in the following platforms

Android
Windows ,
iOS,
MacOS

Issues Fixed

Fixes #19997
Fixes #31326

Output images

Android

Before	After
Before_Android.mov	After_Android.mov

iOS

Before	After
Before_iOS.mov	After_iOS.mov

macOS

Before	After
Before_macOS.mov	After_macOS.mov

jsuarezruiz · 2025-07-25T08:40:54Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-07-25T08:41:06Z

Azure Pipelines successfully started running 1 pipeline(s).

src/Core/src/Handlers/Entry/EntryHandler.Android.cs

Copilot

Pull Request Overview

This PR fixes a bug where the Entry control's clear button color does not update when the app theme changes on Android, iOS, and macOS platforms. The issue occurred because the clear button icon color was not being refreshed when the text color changed due to AppThemeBinding updates.

Key changes implemented:

Added a new method to update clear button color on Android when text color changes
Modified Entry handlers on iOS and macOS to call the clear button color update method when text color changes
Refactored Android clear button color logic to use the new extension method

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`src/Core/src/Platform/Android/EditTextExtensions.cs`	Added new `UpdateClearButtonColor` method to handle clear button icon color updates
`src/Core/src/Handlers/Entry/EntryHandler.iOS.cs`	Modified `MapTextColor` to call clear button color update when clear button is visible
`src/Core/src/Handlers/Entry/EntryHandler.Android.cs`	Updated `MapTextColor` and `ShowClearButton` to use the new color update method
`src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19997.cs`	Added UI test to verify clear button color updates on theme change
`src/Controls/tests/TestCases.HostApp/Issues/Issue19997.cs`	Created test page with Entry using AppThemeBinding and theme toggle button

Comments suppressed due to low confidence (1)

src/Core/src/Handlers/Entry/EntryHandler.Android.cs:86

[nitpick] The variable name 'platformHandler' is misleading since 'handler' is already the platform handler. Consider renaming to 'entryHandler' or 'concreteHandler' for clarity.

			if (handler is EntryHandler platformHandler && platformHandler._clearButtonVisible)

jsuarezruiz · 2025-07-29T07:22:40Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-07-29T07:22:52Z

Azure Pipelines successfully started running 1 pipeline(s).

src/Controls/tests/TestCases.HostApp/Issues/Issue19997.cs

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19997.cs

jfversluis · 2025-08-27T12:13:53Z

/rebase

azure-pipelines · 2025-08-27T12:37:45Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-08-28T08:28:46Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-08-29T10:01:46Z

Azure Pipelines successfully started running 1 pipeline(s).

Added the fix for android platform Remove unwanted code changes Updated the code changes Updated the code changes Updated the fix Updated the code changes Added the test case Added the output images Updated the test case Updated the fix Added the pending snapshots Updated the test case Added the updated output images for mac and windows platform Added the output images for entry feature matrix test case

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jul 24, 2025

jsuarezruiz added platform/macos macOS / Mac Catalyst platform/android platform/ios labels Jul 25, 2025

jsuarezruiz reviewed Jul 25, 2025

View reviewed changes

src/Core/src/Handlers/Entry/EntryHandler.Android.cs Show resolved Hide resolved

NanthiniMahalingam marked this pull request as ready for review July 26, 2025 05:04

Copilot AI review requested due to automatic review settings July 26, 2025 05:04

NanthiniMahalingam requested a review from a team as a code owner July 26, 2025 05:04

NanthiniMahalingam requested review from StephaneDelcroix and mattleibow July 26, 2025 05:04

Copilot AI reviewed Jul 26, 2025

View reviewed changes

MartyIX reviewed Jul 30, 2025

View reviewed changes

src/Controls/tests/TestCases.HostApp/Issues/Issue19997.cs Outdated Show resolved Hide resolved

MartyIX reviewed Jul 30, 2025

View reviewed changes

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19997.cs Outdated Show resolved Hide resolved

MartyIX reviewed Jul 30, 2025

View reviewed changes

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19997.cs Outdated Show resolved Hide resolved

MartyIX reviewed Jul 30, 2025

View reviewed changes

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19997.cs Outdated Show resolved Hide resolved

Tamilarasan-Paranthaman mentioned this pull request Aug 25, 2025

[iOS] Clear button does not apply TextColor when set at runtime #31326

Closed

NanthiniMahalingam force-pushed the fix-19997 branch from 5944910 to 588d9ee Compare August 26, 2025 08:12

Tamilarasan-Paranthaman added the area-controls-entry Entry label Aug 26, 2025

jfversluis approved these changes Sep 1, 2025

View reviewed changes

jfversluis changed the base branch from main to inflight/current September 1, 2025 12:34

Fixed the issue on iOS and macOS platform

c866552

NanthiniMahalingam added 14 commits September 1, 2025 14:49

Added the fix for android platform

9c78237

Remove unwanted code changes

8748f9e

Updated the code changes

83d4fa5

Updated the code changes

810c1c9

Updated the fix

e4e804b

Updated the code changes

ee53f2e

Added the test case

caae52e

Added the output images

29374df

Updated the test case

ca98750

Updated the fix

1c455e8

Added the pending snapshots

b62333d

Updated the test case

3c45f74

Added the updated output images for mac and windows platform

79e7460

Added the output images for entry feature matrix test case

94e158c

jfversluis force-pushed the fix-19997 branch from 040c4ee to 94e158c Compare September 1, 2025 12:50

jfversluis merged commit 312a1ed into dotnet:inflight/current Sep 1, 2025
1 check passed

jfversluis added this to the .NET 9 SR11 milestone Sep 1, 2025

github-actions bot locked and limited conversation to collaborators Oct 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android, iOS, MacOS] Fixed Entry ClearButton Color Not Updating on AppThemeBinding Change#30817

[Android, iOS, MacOS] Fixed Entry ClearButton Color Not Updating on AppThemeBinding Change#30817
jfversluis merged 15 commits intodotnet:inflight/currentfrom
NanthiniMahalingam:fix-19997

NanthiniMahalingam commented Jul 24, 2025 •

edited

Loading

Uh oh!

jsuarezruiz commented Jul 25, 2025 •

edited by jfversluis

Loading

Uh oh!

azure-pipelines bot commented Jul 25, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

jsuarezruiz commented Jul 29, 2025 •

edited by jfversluis

Loading

Uh oh!

azure-pipelines bot commented Jul 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jfversluis commented Aug 27, 2025

Uh oh!

azure-pipelines bot commented Aug 27, 2025

Uh oh!

azure-pipelines bot commented Aug 28, 2025

Uh oh!

azure-pipelines bot commented Aug 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

NanthiniMahalingam commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Details

Root cause

Description of Change

Issues Fixed

Output images

Uh oh!

jsuarezruiz commented Jul 25, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Jul 25, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

jsuarezruiz commented Jul 29, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Jul 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jfversluis commented Aug 27, 2025

Uh oh!

azure-pipelines bot commented Aug 27, 2025

Uh oh!

azure-pipelines bot commented Aug 28, 2025

Uh oh!

azure-pipelines bot commented Aug 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NanthiniMahalingam commented Jul 24, 2025 •

edited

Loading

jsuarezruiz commented Jul 25, 2025 •

edited by jfversluis

Loading

jsuarezruiz commented Jul 29, 2025 •

edited by jfversluis

Loading