[iOS]CarouselView Position Not Respected When Changing From Hidden to Visible in CV2 - fix#29999
Merged
PureWeen merged 3 commits intodotnet:inflight/currentfrom Aug 22, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the CarouselView's position is not respected when changing from hidden to visible by updating the test case to use CarouselView2 and adding a guard in the iOS controller.
- Updated CarouselViewUpdatePosition.xaml to use CarouselView2 instead of CarouselView1.
- Added an early return in CarouselViewController2.cs when the control is not visible in order to prevent resetting the initial position.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.HostApp/Issues/CarouselViewUpdatePosition.xaml | Updated control tags from CarouselView1 to CarouselView2 for test consistency. |
| src/Controls/src/Core/Handlers/Items2/iOS/CarouselViewController2.cs | Added visibility check in UpdateInitialPosition to improve behavior when control is hidden. |
Comments suppressed due to low confidence (1)
src/Controls/tests/TestCases.HostApp/Issues/CarouselViewUpdatePosition.xaml:16
- [nitpick] Consider updating the TODO comment to reflect the current usage of CarouselView2 to avoid confusion for future maintainers.
<!-- TODO: Replace CarouselView1 with CarouselView once the issues mentioned in the GitHub issue are resolved. -->
Contributor
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
requested changes
Jun 16, 2025
Member
rmarinho
left a comment
There was a problem hiding this comment.
We have a way to run both tests handlers for CarouselView1 and CarouselView2 ? so using CarouselView instead of CarouselView2 should run the tests against both.
Contributor
Author
Right! Fixed |
Member
|
/rebase |
b5f3858 to
37fac1c
Compare
PureWeen
approved these changes
Aug 22, 2025
c4564b1 to
be4d18d
Compare
jfversluis
pushed a commit
that referenced
this pull request
Aug 25, 2025
… Visible in CV2 - fix (#29999) * [iOS]CarouselView Position Not Respected When Changing From Hidden to Visible in CV2 - fix * Update CarouselViewUpdatePosition.xaml * Update CarouselViewUpdatePosition.xaml
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2025
… Visible in CV2 - fix (#29999) * [iOS]CarouselView Position Not Respected When Changing From Hidden to Visible in CV2 - fix * Update CarouselViewUpdatePosition.xaml * Update CarouselViewUpdatePosition.xaml
github-actions bot
pushed a commit
that referenced
this pull request
Sep 5, 2025
… Visible in CV2 - fix (#29999) * [iOS]CarouselView Position Not Respected When Changing From Hidden to Visible in CV2 - fix * Update CarouselViewUpdatePosition.xaml * Update CarouselViewUpdatePosition.xaml
PureWeen
pushed a commit
that referenced
this pull request
Sep 5, 2025
… Visible in CV2 - fix (#29999) * [iOS]CarouselView Position Not Respected When Changing From Hidden to Visible in CV2 - fix * Update CarouselViewUpdatePosition.xaml * Update CarouselViewUpdatePosition.xaml
This was referenced Sep 10, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issues Fixed
Fixes #29309