Fixed Test case failure in PR 29473 - [2025/05/19] Candidate#29457
Merged
PureWeen merged 3 commits intodotnet:inflight/candidatefrom May 20, 2025
Merged
Fixed Test case failure in PR 29473 - [2025/05/19] Candidate#29457PureWeen merged 3 commits intodotnet:inflight/candidatefrom
PureWeen merged 3 commits intodotnet:inflight/candidatefrom
Conversation
MartyIX
reviewed
May 13, 2025
Comment on lines
+326
to
+340
| if (isHeader) | ||
| _headerHeight = itemHeight; | ||
| else | ||
| _footerHeight = itemHeight; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (isHeader) | |
| _headerHeight = itemHeight; | |
| else | |
| _footerHeight = itemHeight; | |
| if (isHeader) | |
| { | |
| _headerHeight = itemHeight; | |
| } | |
| else | |
| { | |
| _footerHeight = itemHeight; | |
| } |
MartyIX
reviewed
May 13, 2025
Comment on lines
+339
to
+359
| case LinearItemsLayout linearLayout: | ||
| { | ||
| return linearLayout.Orientation == ItemsLayoutOrientation.Vertical; | ||
| } | ||
| case GridItemsLayout gridItemsLayout: | ||
| { | ||
| return gridItemsLayout.Orientation == ItemsLayoutOrientation.Vertical; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| case LinearItemsLayout linearLayout: | |
| { | |
| return linearLayout.Orientation == ItemsLayoutOrientation.Vertical; | |
| } | |
| case GridItemsLayout gridItemsLayout: | |
| { | |
| return gridItemsLayout.Orientation == ItemsLayoutOrientation.Vertical; | |
| } | |
| } | |
| case LinearItemsLayout linearLayout: | |
| { | |
| return linearLayout.Orientation == ItemsLayoutOrientation.Vertical; | |
| } | |
| case GridItemsLayout gridItemsLayout: | |
| { | |
| return gridItemsLayout.Orientation == ItemsLayoutOrientation.Vertical; | |
| } | |
| } |
Contributor
Author
There was a problem hiding this comment.
@MartyIX, Thank you! I have updated the changes as per your suggestion.
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
4a18803 to
eb5e9a3
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
ad50b51 to
adc5792
Compare
4d4d66d to
66aaa73
Compare
eb5e9a3 to
a4c0c8e
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
3c27edc to
9eba629
Compare
6959478 to
71de10f
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
May 19, 2025
Member
PureWeen
left a comment
There was a problem hiding this comment.
I think there's some ordering considerations we need to figure out here
Like, if I click the buttons in this order
"Add header"
"add footer"
"add empty View"
"change ItemsLayout"
it looks like this
Contributor
@PureWeen The known issue occurs when the actions are performed in the mentioned order. It also occurs on the main branch and will be resolved by this PR #29474 |
PureWeen
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description
Issue28622test, which was introduced by the changes made in PR #29381.Cause
HeaderandFooterheight in the horizontal measurement. This affects the available space for theEmptyView, causing the EmptyView to appear misaligned from the center.Description of Changes
Introduced a helper method
IsVerticalItemsLayout()to determine if the CollectionView uses a vertical layout. It evaluates the ItemsLayout property for bothLinearItemsLayoutandGridItemsLayout, defaulting to vertical when the orientation is unspecified.Updated the
UpdateHeaderFooterHeightmethod to use the newIsVerticalItemsLayout()method when calculating the height of headers and footers, ensuring the logic applies only to vertical layouts.Updated the latest macOS image to address the failure of the
Issue29372Test.Issues Fixed
Fixes #29473
Output