[Windows] Fixed Shell flyout background image does not displayed#28977
Merged
PureWeen merged 9 commits intodotnet:inflight/currentfrom May 21, 2025
Merged
[Windows] Fixed Shell flyout background image does not displayed#28977PureWeen merged 9 commits intodotnet:inflight/currentfrom
PureWeen merged 9 commits intodotnet:inflight/currentfrom
Conversation
Contributor
|
Hey there @@SubhikshaSf4851! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
suggested changes
Apr 15, 2025
jsuarezruiz
suggested changes
Apr 15, 2025
| } | ||
|
|
||
| var service = provider.GetRequiredImageSourceService(imageSource); | ||
| var nativeImageSource = await service.GetImageSourceAsync(imageSource); |
Contributor
There was a problem hiding this comment.
if nativeImageSource is null at this point, can directly set the pane background to null.
Contributor
Author
There was a problem hiding this comment.
I have updated the requested changes
c5ab0b6 to
fa90415
Compare
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fa90415 to
c5ab0b6
Compare
jsuarezruiz
suggested changes
Apr 23, 2025
| { | ||
| public Issue21472ContentPage() | ||
| { | ||
| Content = new Label |
Contributor
There was a problem hiding this comment.
To cover all the scenarios, could this be replaced by a Button and tapping it set the FlyoutBackgroundImage to null? In this way, with the test we can verify that we can set the background image and also remove it.
Contributor
Author
There was a problem hiding this comment.
I have modified the test sample as per your suggestion
c5ab0b6 to
258a93b
Compare
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
suggested changes
May 12, 2025
|
|
||
| [Test, Order(2)] | ||
| [Category(UITestCategories.Shell)] | ||
| public void VerifyShellFlyoutBackgroundImageSetNull() |
Contributor
There was a problem hiding this comment.
Pending snapshot on Mac and Windows. Available in the latest build.
Contributor
Author
There was a problem hiding this comment.
Pending Snapshots were added.
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
approved these changes
May 20, 2025
4 tasks
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
) * [Windows] Fix for FlyoutBackgroundImage * [Windows] Fix for Flyout Background Image * Test case sample for FlyoutBackgroundImage * [Windows] Fix for FlyoutBackgroundImage * [Windows] Fix for FlyoutBackgroundImage * Updated Test sample * Changed test sample and added snapshots for android and iOS * BackgroundImage set Snapshot for windows and mac * BackgroundImage set Null Snapshot for windows and mac
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
) * [Windows] Fix for FlyoutBackgroundImage * [Windows] Fix for Flyout Background Image * Test case sample for FlyoutBackgroundImage * [Windows] Fix for FlyoutBackgroundImage * [Windows] Fix for FlyoutBackgroundImage * Updated Test sample * Changed test sample and added snapshots for android and iOS * BackgroundImage set Snapshot for windows and mac * BackgroundImage set Null Snapshot for windows and mac
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2025
) * [Windows] Fix for FlyoutBackgroundImage * [Windows] Fix for Flyout Background Image * Test case sample for FlyoutBackgroundImage * [Windows] Fix for FlyoutBackgroundImage * [Windows] Fix for FlyoutBackgroundImage * Updated Test sample * Changed test sample and added snapshots for android and iOS * BackgroundImage set Snapshot for windows and mac * BackgroundImage set Null Snapshot for windows and mac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause :
The FlyoutBackgroundImage and FlyoutBackgroundImageAspect were not implemented in Shell, resulting in the Flyout background image not being rendered on the Windows platform.
Description of Change:
I have implemented the necessary mappers for FlyoutBackgroundImage and FlyoutBackgroundImageAspect, updated them, and resolved the issue
Tested the behaviour in the following platforms
Issue Fixed:
Fixes #21472
Screenshot