Cleanup virtual layer measure invalidation#28756
Merged
rmarinho merged 1 commit intodotnet:mainfrom Apr 8, 2025
Merged
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
I wonder what the impact of the PR is in terms of performance. Did you happen to measure the impact, please? |
Contributor
Author
I think there's a slight performance improve, these are two examples. Android: iOS: (other kind of test) Consider that the app switch I've inserted could make this even better. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Apr 8, 2025
Member
|
Failing tests are not related. |
rmarinho
added a commit
that referenced
this pull request
Apr 8, 2025
albyrock87
added a commit
to albyrock87/maui
that referenced
this pull request
Apr 8, 2025
)" (dotnet#28872)" This reverts commit 4ff875a.
rmarinho
pushed a commit
that referenced
this pull request
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Now that we have merged #28225, and soon will merge #28670, we can finally start getting rid of
MeasureInvalidatedevent and also enhance some features.Compatibility.Layoutuseless and harming code (causing additional unneeded invalidations/arranges)ComputeConstraintForViewfromCompatibility.LayouttoVisualElementso new layouts will be able to use it out of the box so that we can leverage Stop iOS SetNeedsLayout propagation by looking at VisualElement computed Constraint #28479MeasureInvalidatedtotal propagation, basically "revert"s MakeMeasureInvalidatedevent work correctly #23052 and goes back to 8.0.82 behavior where the propagation was happening only while using legacy layoutsIssues Fixed
Fixes #25264