[Windows] Fixed the OneWayBinding issue with MultiBindingConverter on Slider and Stepper Value#28219
Merged
StephaneDelcroix merged 2 commits intodotnet:inflight/currentfrom Dec 3, 2025
Merged
Conversation
Contributor
|
Hey there @Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
MartyIX
reviewed
Mar 6, 2025
| using System.ComponentModel; | ||
| using System.Globalization; | ||
|
|
||
| namespace Maui.Controls.Sample.Issues |
Contributor
There was a problem hiding this comment.
Super-nit: After #28040, you can convert this to file-scope namespace by CTRL+. in Visual Studio (I believe it's the same in VS Code).
If it is converted, then new files will use file-scope namespaces more and more as people IMO copy old files to create new code.
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion , I have changed the file-scope namespace. @MartyIX
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/rebase |
77b538c to
7b62837
Compare
Contributor
|
/rebase |
7b62837 to
82536a6
Compare
Contributor
|
/rebase |
82536a6 to
3c158d9
Compare
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephaneDelcroix
approved these changes
Dec 3, 2025
121039d
into
dotnet:inflight/current
72 of 77 checks passed
PureWeen
pushed a commit
that referenced
this pull request
Dec 3, 2025
… Slider and Stepper Value (#28219) * Fixed the OneWayBinding issue with MultiBindingConverter on Slider and Stepper Value * Change file namespace scope
PureWeen
pushed a commit
that referenced
this pull request
Dec 3, 2025
… Slider and Stepper Value (#28219) * Fixed the OneWayBinding issue with MultiBindingConverter on Slider and Stepper Value * Change file namespace scope
PureWeen
pushed a commit
that referenced
this pull request
Dec 3, 2025
… Slider and Stepper Value (#28219) * Fixed the OneWayBinding issue with MultiBindingConverter on Slider and Stepper Value * Change file namespace scope
PureWeen
pushed a commit
that referenced
this pull request
Dec 3, 2025
… Slider and Stepper Value (#28219) * Fixed the OneWayBinding issue with MultiBindingConverter on Slider and Stepper Value * Change file namespace scope
PureWeen
pushed a commit
that referenced
this pull request
Dec 3, 2025
… Slider and Stepper Value (#28219) * Fixed the OneWayBinding issue with MultiBindingConverter on Slider and Stepper Value * Change file namespace scope
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
… Slider and Stepper Value (#28219) * Fixed the OneWayBinding issue with MultiBindingConverter on Slider and Stepper Value * Change file namespace scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause of the issue
VirtualView.Valueis updated unnecessarily even when it has already been updated, causing an issue with the MultiBinding Converter.Description of Change
unnecessaryupdates toVirtualView.Valueresolved the One-Way binding issue with the MultiBinding Converter.Issues Fixed
Fixes #28208
Tested the behaviour in the following platforms
Screenshot
OneWayBindingModeIssueVideo.mp4
OneWayBindingModeFixVideo.mp4