Mark BindingUpdatesFromInteractiveRefresh UI test as flaky#28179
Closed
jfversluis wants to merge 1 commit intomainfrom
Closed
Mark BindingUpdatesFromInteractiveRefresh UI test as flaky#28179jfversluis wants to merge 1 commit intomainfrom
BindingUpdatesFromInteractiveRefresh UI test as flaky#28179jfversluis wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR marks the UI test BindingUpdatesFromInteractiveRefresh as flaky due to its unstable behavior in other PRs.
- Added the [FlakyTest] attribute to ignore the unstable test.
- References issue #28178 for future re-enablement.
Reviewed Changes
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16910.cs | Added [FlakyTest] attribute to mark the unstable test as flaky |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16910.cs:31
- While marking the test as flaky is a good temporary measure, please ensure that the test cases in both TestCases.HostApp and TestCases.Shared.Tests are updated accordingly to handle this state, and consider adding a reminder in the test documentation to re-enable it once issue #28178 is resolved.
[FlakyTest("Issue to reenable this test: https://github.com/dotnet/maui/issues/28178")]
jsuarezruiz
reviewed
Mar 5, 2025
| } | ||
| #if TEST_FAILS_ON_CATALYST //Scroll actions cannot be performed on the macOS test server | ||
| [Test] | ||
| [FlakyTest("Issue to reenable this test: https://github.com/dotnet/maui/issues/28178")] |
Contributor
There was a problem hiding this comment.
I think it should be fixed by #28137. Could we merge it, and if still fails sometimes mark it as Flaky?
Member
Author
|
Assuming this is fixed by #28137 for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This test was added in #27764 but proves to be not really stable in other PRs. Marking as flaky to ignore it for now and opened #28178 to reenable later
cc: @LogishaSelvarajSF4525