Skip to content

[Testing] Enabling more UI Tests by removing platform specific condition - 11#27764

Merged
jfversluis merged 7 commits intomainfrom
unknown repository
Feb 25, 2025
Merged

[Testing] Enabling more UI Tests by removing platform specific condition - 11#27764
jfversluis merged 7 commits intomainfrom
unknown repository

Conversation

@LogishaSelvarajSF4525
Copy link
Copy Markdown
Contributor

Description of Change

The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 11th group of tests enabled.

Test Cases:

  • Issue16910
  • Issue17283
  • Issue19338
  • Issue20903
  • Issue21967
  • Issue22417
  • Issue22674
  • Issue968

Fixes #22902

@LogishaSelvarajSF4525 LogishaSelvarajSF4525 added area-testing Unit tests, device tests partner/syncfusion Issues / PR's with Syncfusion collaboration labels Feb 13, 2025
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 13, 2025
@LogishaSelvarajSF4525 LogishaSelvarajSF4525 marked this pull request as ready for review February 13, 2025 06:24
Copilot AI review requested due to automatic review settings February 13, 2025 06:24
@LogishaSelvarajSF4525 LogishaSelvarajSF4525 requested a review from a team as a code owner February 13, 2025 06:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.

Files not reviewed (3)
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20903.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19338.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16910.cs: Evaluated as low risk

@@ -1,4 +1,5 @@
using NUnit.Framework;
#if TEST_FAILS_ON_WINDOWS //This test is failing, likely due to product issue, for mor information: https://github.com/dotnet/maui/issues/27059
Copy link

Copilot AI Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment contains a spelling mistake: 'for mor information' should be 'for more information'.

Suggested change
#if TEST_FAILS_ON_WINDOWS //This test is failing, likely due to product issue, for mor information: https://github.com/dotnet/maui/issues/27059
#if TEST_FAILS_ON_WINDOWS //This test is failing, likely due to product issue, for more information: https://github.com/dotnet/maui/issues/27059

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the small typo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated these changes in the latest commit.

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@@ -1,4 +1,4 @@
#if ANDROID
#if TEST_FAILS_ON_CATALYST //TapCoordinates is not working on Catalyst
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed by #27603
After merge it, can re-enable the test on Catalyst.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged the linked PR, can we update it for this one please? :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated these changes in the latest commit.

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis self-assigned this Feb 20, 2025
jsuarezruiz
jsuarezruiz previously approved these changes Feb 21, 2025
@jfversluis
Copy link
Copy Markdown
Member

Sorry new conflict here. Can you rebase this one?

@LogishaSelvarajSF4525
Copy link
Copy Markdown
Contributor Author

Sorry new conflict here. Can you rebase this one?

@jfversluis I have resolved the conflicts and rebased the branch.

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis merged commit 2fdc54a into dotnet:main Feb 25, 2025
tj-devel709 pushed a commit that referenced this pull request Mar 3, 2025
…ion - 11 (#27764)

* enable test case for all platforms

* update the changes

* modified changes

* replace snapshot

* update the changes

* modified changes

* modified
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TEST] Review all (UI) Tests and remove platform-specific runs where possible

4 participants