[Testing] Enabling more UI Tests by removing platform specific condition - 19#28060
[Testing] Enabling more UI Tests by removing platform specific condition - 19#28060PureWeen merged 4 commits intoinflight/currentfrom unknown repository
Conversation
|
Hey there @HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (11)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue6484.cs:19
- Ensure that WaitForElementTillPageNavigationSettled provides an adequate timeout and handles UI transitions reliably after removing the platform-specific condition.
App.WaitForElementTillPageNavigationSettled("Success");
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25371.cs:25
- The original code explicitly asserted the text while the new code only waits for the element; consider restoring an explicit text assertion to verify the expected content.
App.WaitForElement("FirstPageLabel", timeout: TimeSpan.FromSeconds(3));
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue7534.cs:1
- Removal of the platform-specific conditional compilation for Android tests may expose issues on that platform; please verify that the test remains stable across all targeted platforms.
using NUnit.Framework;
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue9006.cs:31
- Confirm that WaitForElementTillPageNavigationSettled robustly waits for the FinalLabel element to avoid flaky test outcomes during UI transitions.
App.WaitForElementTillPageNavigationSettled(FinalLabel);
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue9006.cs:37
- Ensure the subsequent use of WaitForElementTillPageNavigationSettled consistently handles UI navigation waits to prevent timing issues.
App.WaitForElementTillPageNavigationSettled(FinalLabel);
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25193.cs:1
- The removal of platform-specific conditional compilation warrants a review of test stability on all platforms that were previously excluded.
using NUnit.Framework;
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue1414.cs:1
- Verify that removing the Catalyst-specific conditional directive does not compromise the stability of scrolling and refresh tests on MacCatalyst.
using NUnit.Framework;
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla56298.cs:28
- Check whether the newly added wait for 'btnAdd' after toggling is necessary, and confirm that it improves the reliability of the test across all platforms.
App.WaitForElement("btnAdd");
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla60123.cs:1
- Removing the Catalyst-specific directive requires ensuring that the test criteria remain valid and that the test passes reliably on all intended platforms.
using NUnit.Framework;
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue7453.cs:1
- Removal of the Catalyst-specific conditional directive should be accompanied by verification that the test functions correctly across different platforms.
using System;
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18751.cs:1
- Updating the conditional directive to TEST_FAILS_ON_ANDROID should be validated to ensure that the test runs as intended on Android devices only.
#if TEST_FAILS_ON_ANDROID //related issues: https://github.com/dotnet/maui/issues/15994
|
/rebase |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| @@ -22,5 +21,4 @@ public void BackgroundGradientsShouldRenderCorrectly() | |||
| App.WaitForElement("label"); | |||
There was a problem hiding this comment.
This test is failing on macOS:
Snapshot different than baseline: BackgroundGradientsShouldRenderCorrectly.png (size differs - baseline is 789x563 pixels, actual is 1920x1051 pixels)
There was a problem hiding this comment.
Hi @jsuarezruiz ,
It appears that the CI generated the latest image for Mac with unexpected dimensions. The images from the drop files have dimensions of 1920 × 1051, while we were expecting dimensions of 789 × 563. I'm not sure why this change occurred. Do you have any insights on this, or could you try re-triggering the CI again?
|
/rebase |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…ion - 19 (#28060) * Enable the product and Appium related Issues * Added snapshots * Updated Changes * Update Issue25193.cs
…ion - 19 (#28060) * Enable the product and Appium related Issues * Added snapshots * Updated Changes * Update Issue25193.cs
…ion - 19 (#28060) * Enable the product and Appium related Issues * Added snapshots * Updated Changes * Update Issue25193.cs
Description of Change
The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 19th group of tests enabled.
Test Cases: