Skip to content

[iOS] Trigger OnNavigatedTo method when hide the nav bar and using swipe gesture#27186

Closed
kubaflo wants to merge 24 commits intodotnet:inflight/candidatefrom
kubaflo:Not-trigger-OnNavigatedTo-method-when-hide-the-navi-bar-and-using-swipe-back-on-iOS
Closed

[iOS] Trigger OnNavigatedTo method when hide the nav bar and using swipe gesture#27186
kubaflo wants to merge 24 commits intodotnet:inflight/candidatefrom
kubaflo:Not-trigger-OnNavigatedTo-method-when-hide-the-navi-bar-and-using-swipe-back-on-iOS

Conversation

@kubaflo
Copy link
Copy Markdown
Contributor

@kubaflo kubaflo commented Jan 16, 2025

Issues Fixed

Fixes #27143

@kubaflo kubaflo requested a review from a team as a code owner January 16, 2025 16:48
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 16, 2025
@jfversluis
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include a test?

@jingliancui

This comment was marked as off-topic.

praveenkumarkarunanithi and others added 19 commits March 18, 2025 13:19
…Control (dotnet#27220)

* fix code updated

* updated failing ios ui test case images.

* updated ui test images for mac and windows

* resolving branch conflicts
…dotnet#27873)

* Fixed Shadow not updated when Clipping a View with a shadow

* FIxed shadow not updating with vlip

* Updated code changes

* Updated testcase image

* Updated test case

* updated test case image

* Added pending snapshots
…ion - 15 (dotnet#27965)

* enable the test case for all platforms

* enable ScrollViewObjectDisposed.cs

* updated the changes

* modified

* added the snapshot

* added snapshot

* modified changes

* Update Issue17453.cs

* modified Issue17453.cs
…ion - 19 (dotnet#28060)

* Enable the product and Appium related Issues

* Added snapshots

* Updated Changes

* Update Issue25193.cs
* Fixed Label Display on macOS and IOS When Padding is Applied

* Optimized the fix

* Added test case

* Added Snapshot for android and iOS

* Added snapshot for winUI and macOS, updated test sample
…s into device tests - 5 (dotnet#28193)

* Test case added

* Update LabelTests.iOS.cs

* test case added

* code changes

* reverted changes

* Update src/Controls/tests/DeviceTests/Elements/TemplatedView/TemplatedViewTests.Android.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* handler code change

* conflict code changes

* flow direction test

* Revert "flow direction test"

This reverts commit 1f5c535.

* Reverted changes

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com>
…dows (dotnet#28367)

* Fixed Using CollectionView.EmptyView results in an Exception on Windows

* Test case written and fix slightly modified

* Test case modified

* Snap added for android and iOS

* Test case modified

* snap removed

* Test case modified

* Removed curly braces

* Test case modified
)

* Fix for stepper allows to increment value

* Updating naming concern

* Updates on minimum value and test case sample
…s into device tests - 7 (dotnet#28409)

* Enabled the Shell and ObservableItemsSource for device test

* Updated CollectionViewTests.Android.cs

* Addressed the feedback

* Removed three test cases from the CollectionView test

* Corrected the misspelled words
…net#28133)

* Fixed Blank Screen on navigating back to Previous Page

* Updated class naming

* Updated test sample

* Updated fix in ObservableGroupedSource

* Added snapshots

* Updated  test file namespace

* Added test case for CollectionView with grouped data
* Make IShape in MauiCALayer a WeakReference

* Added DeviceTest

---------

Co-authored-by: Rain336 <rain336@live.de>
…erly to the Tab Icon (dotnet#26757)

* Tab icon color fix

* Test sample changes

* Added snapshots

* Added details

* Added Mac snapshots

* Removed unwanted parameters and modified the test sample

* Committed the proper mac snap

* Removed the unwanted issue list comments

* Addressed the review concerns

---------

Co-authored-by: Ahamed-Ali <102580874+Ahamed-Ali@users.noreply.github.com>
Remove ShapeableImageView Padding immediately after it is set in its
onMeasure method to avoid double padding (ContentPadding + Padding).
…able Issue14471 test which fails in CI randomly (dotnet#28540)

* Improve stability for flaky test

* Update Issue14471.cs

* Don t allow pre release

---------

Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com>
Co-authored-by: Rui Marinho <me@ruimarinho.net>
…ollMode when collection modified (dotnet#26608)

* Added sample

* Added test

* Added UITest to validate Windows CarouselView scrolling behavior

* Updated test

* Updated test

* More changes

* Commit for 25991

* Commit for testcase changes

* Update CarouselViewController2.cs

* commit for unwanted changes

* commit for unwanted changes

* commit for testcase removal

* commit for refactor

* commit for method name change

* Added sample

* Added test

* Added UITest to validate Windows CarouselView scrolling behavior

* Updated test

* Updated test

* More changes

* Fix the test

* Update Issue25991.cs with minor fixes and additions

* Fix Issue25991 test assertions and string format

* Commit for testcase failure

* commit for testcase changes

* commit for testcase changes

* Create ItemShouldbeScrolledbasedOnGroupHeader.png

* Delete ItemShouldbeScrolledbasedOnGroupHeader.png

* Add check for empty ItemsSource in CarouselViewController2.

* Fix item addition logic in Issue25991 test

* Update issue comments in Issue8964.cs

---------

Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
… hovering over it. (dotnet#27147)

* Fixed the Hovering issue of text and icon color in the DatePicker in windows.

* Included the UI test sample and test case

* Modified the test

* Added Device Test

---------

Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
…otnet#28456)

* Update PropertyPropagationExtensions.cs

* Update PropertyPropagationExtensions.cs

* Update PropertyPropagationExtensions.cs
Co-authored-by: Rui Marinho <me@ruimarinho.net>
kubaflo and others added 2 commits March 24, 2025 13:38
* Resaved Image For RadioButtonUpdateValueInserBorder

* updated test case code

---------

Co-authored-by: praveenkumarkarunanithi <praveenkumar.karunanithi@syncfusion.com>
@jfversluis jfversluis added this to the .NET 9 SR7 milestone Mar 25, 2025
@kubaflo kubaflo force-pushed the Not-trigger-OnNavigatedTo-method-when-hide-the-navi-bar-and-using-swipe-back-on-iOS branch from dfb5111 to 62adde2 Compare March 25, 2025 15:46
@kubaflo kubaflo changed the base branch from main to inflight/candidate March 25, 2025 15:47
@kubaflo kubaflo self-assigned this Mar 25, 2025
@kubaflo kubaflo force-pushed the Not-trigger-OnNavigatedTo-method-when-hide-the-navi-bar-and-using-swipe-back-on-iOS branch from 62adde2 to b5356f7 Compare March 25, 2025 16:23
@PureWeen PureWeen force-pushed the inflight/candidate branch from a9246ce to 5a4e1f1 Compare March 26, 2025 18:38
@jfversluis
Copy link
Copy Markdown
Member

@kubaflo I think @PureWeen mightve made a mistake here and brought in too many commits? Sorry 😅

@github-actions github-actions bot force-pushed the inflight/candidate branch from 0622a37 to 06e8924 Compare March 27, 2025 21:50
@PureWeen PureWeen deleted the branch dotnet:inflight/candidate March 28, 2025 15:47
@PureWeen PureWeen closed this Mar 28, 2025
@PureWeen PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Mar 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-navigation NavigationPage community ✨ Community Contribution platform/ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not trigger OnNavigatedTo method when hide the navi bar and using swipe back on iOS